Re: [libvirt] [PATCH 15/18] event-test: Add VIR_DOMAIN_EVENT_ID_JOB_COMPLETED

2016-04-18 Thread Ján Tomko
On Thu, Apr 14, 2016 at 05:52:40PM +0200, Peter Krempa wrote:
> ---
>  examples/object-events/event-test.c | 45 
> -
>  1 file changed, 34 insertions(+), 11 deletions(-)
> 

ACK

Jan

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH 15/18] event-test: Add VIR_DOMAIN_EVENT_ID_JOB_COMPLETED

2016-04-14 Thread Peter Krempa
---
 examples/object-events/event-test.c | 45 -
 1 file changed, 34 insertions(+), 11 deletions(-)

diff --git a/examples/object-events/event-test.c 
b/examples/object-events/event-test.c
index 0abcfe4..70f1d4c 100644
--- a/examples/object-events/event-test.c
+++ b/examples/object-events/event-test.c
@@ -625,19 +625,12 @@ myNetworkEventCallback(virConnectPtr conn 
ATTRIBUTE_UNUSED,
 return 0;
 }

-
-static int
-myDomainEventTunableCallback(virConnectPtr conn ATTRIBUTE_UNUSED,
- virDomainPtr dom,
- virTypedParameterPtr params,
- int nparams,
- void *opaque ATTRIBUTE_UNUSED)
+static void
+eventTypedParamsPrint(virTypedParameterPtr params,
+  int nparams)
 {
 size_t i;

-printf("%s EVENT: Domain %s(%d) tunable updated:\n",
-   __func__, virDomainGetName(dom), virDomainGetID(dom));
-
 for (i = 0; i < nparams; i++) {
 switch (params[i].type) {
 case VIR_TYPED_PARAM_INT:
@@ -667,6 +660,20 @@ myDomainEventTunableCallback(virConnectPtr conn 
ATTRIBUTE_UNUSED,
 printf("\t%s: unknown type\n", params[i].field);
 }
 }
+}
+
+
+static int
+myDomainEventTunableCallback(virConnectPtr conn ATTRIBUTE_UNUSED,
+ virDomainPtr dom,
+ virTypedParameterPtr params,
+ int nparams,
+ void *opaque ATTRIBUTE_UNUSED)
+{
+printf("%s EVENT: Domain %s(%d) tunable updated:\n",
+   __func__, virDomainGetName(dom), virDomainGetID(dom));
+
+eventTypedParamsPrint(params, nparams);

 return 0;
 }
@@ -779,6 +786,22 @@ myDomainEventMigrationIterationCallback(virConnectPtr conn 
ATTRIBUTE_UNUSED,
 }


+static int
+myDomainEventJobCompletedCallback(virConnectPtr conn ATTRIBUTE_UNUSED,
+  virDomainPtr dom,
+  virTypedParameterPtr params,
+  int nparams,
+  void *opaque ATTRIBUTE_UNUSED)
+{
+printf("%s EVENT: Domain %s(%d) job completed:\n",
+   __func__, virDomainGetName(dom), virDomainGetID(dom));
+
+eventTypedParamsPrint(params, nparams);
+
+return 0;
+}
+
+
 static void
 myFreeFunc(void *opaque)
 {
@@ -829,7 +852,7 @@ struct domainEventData domainEvents[] = {
 DOMAIN_EVENT(VIR_DOMAIN_EVENT_ID_AGENT_LIFECYCLE, 
myDomainEventAgentLifecycleCallback),
 DOMAIN_EVENT(VIR_DOMAIN_EVENT_ID_DEVICE_ADDED, 
myDomainEventDeviceAddedCallback),
 DOMAIN_EVENT(VIR_DOMAIN_EVENT_ID_MIGRATION_ITERATION, 
myDomainEventMigrationIterationCallback),
-/* VIR_DOMAIN_EVENT_ID_JOB_COMPLETED */
+DOMAIN_EVENT(VIR_DOMAIN_EVENT_ID_JOB_COMPLETED, 
myDomainEventJobCompletedCallback),
 /* VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED */
 };

-- 
2.8.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list