Re: [libvirt] [PATCH 2/2] Add new elements source, access and allocation

2016-06-21 Thread Pavel Hrdina
On Tue, Jun 21, 2016 at 10:33:51AM +, Safka, JaroslavX wrote:
> This change introduces support for preallocated shared file descriptor based 
> memory backing.
> 
> It  allows vhost-user to be used without hugepages. This is achieved by 
> introducing 3 new sub elements to the memoryBacking element: source, access & 
> allocation which will configure qemu commandline during VM startup 
> accordingly.
> 
> 
> 
> First patch adds parsing of elements and storing the values in mem structure.
> 
> Second patch configures the qemu commandline on the base of values in mem 
> structure.

Hi, thanks for contributing to libvirt.  However this is not a good way how to
submit patches and it's also hard to review and provide the best feedback to
your patches.

Please read HACKING, we prefer using "git send-email", it will create a nice
thread where cover-letter is used to describe the patch series like you are
doing in this email.  You may need to install git-email or appropriate package
first (depends on your OS).

Thanks,

Pavel

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH 2/2] Add new elements source, access and allocation

2016-06-21 Thread Safka, JaroslavX
This change introduces support for preallocated shared file descriptor based 
memory backing.

It  allows vhost-user to be used without hugepages. This is achieved by 
introducing 3 new sub elements to the memoryBacking element: source, access & 
allocation which will configure qemu commandline during VM startup accordingly.



First patch adds parsing of elements and storing the values in mem structure.

Second patch configures the qemu commandline on the base of values in mem 
structure.



--
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.


0002-Add-xml-to-argv-for-memorybacking-access-source.patch
Description: 0002-Add-xml-to-argv-for-memorybacking-access-source.patch
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list