Re: [libvirt] [PATCH 2/2] vbox: handle 'saved' state of VMs

2013-10-15 Thread Daniel P. Berrange
On Tue, Oct 15, 2013 at 01:19:42AM +0900, Ryota Ozaki wrote:
> VirtualBox has 'saved' state for VMs saved by the hypervisor.
> However, the state is treated as VIR_DOMAIN_NOSTATE by the vbox
> driver, resulting that virsh shows 'no state' for saved VMs.
> 
> The fix treats the state as VIR_DOMAIN_SHUTOFF as same as
> other domains such as qemu.
> 
> Signed-off-by: Ryota Ozaki 
> ---
>  src/vbox/vbox_tmpl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
> index 10a3775..cf34f5c 100644
> --- a/src/vbox/vbox_tmpl.c
> +++ b/src/vbox/vbox_tmpl.c
> @@ -1923,6 +1923,7 @@ static virDomainState vboxConvertState(enum 
> MachineState state) {
>  case MachineState_Stopping:
>  return VIR_DOMAIN_SHUTDOWN;
>  case MachineState_PoweredOff:
> +case MachineState_Saved:
>  return VIR_DOMAIN_SHUTOFF;
>  case MachineState_Aborted:
>  return VIR_DOMAIN_CRASHED;

ACK & pushed to GIT.

Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH 2/2] vbox: handle 'saved' state of VMs

2013-10-14 Thread Ryota Ozaki
VirtualBox has 'saved' state for VMs saved by the hypervisor.
However, the state is treated as VIR_DOMAIN_NOSTATE by the vbox
driver, resulting that virsh shows 'no state' for saved VMs.

The fix treats the state as VIR_DOMAIN_SHUTOFF as same as
other domains such as qemu.

Signed-off-by: Ryota Ozaki 
---
 src/vbox/vbox_tmpl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index 10a3775..cf34f5c 100644
--- a/src/vbox/vbox_tmpl.c
+++ b/src/vbox/vbox_tmpl.c
@@ -1923,6 +1923,7 @@ static virDomainState vboxConvertState(enum MachineState 
state) {
 case MachineState_Stopping:
 return VIR_DOMAIN_SHUTDOWN;
 case MachineState_PoweredOff:
+case MachineState_Saved:
 return VIR_DOMAIN_SHUTOFF;
 case MachineState_Aborted:
 return VIR_DOMAIN_CRASHED;
-- 
1.8.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list