Re: [libvirt] [PATCH 2/2] virsh: Document bandwidth maximum more clearly

2014-07-17 Thread Peter Krempa
On 07/17/14 01:35, John Ferlan wrote:
> Commit id '0e2d7305' modified the code to allow a negative value to be
> supplied for the bandwidth argument of the various block virsh commands

Technically that commit didn't allow it. It was allowed before that
commit kept it in that same state.

> and the migrate-setspeed; however, it failed to update the man page to
> describe the "feature" whereby a very large value could be interpreted
> by the hypervisor to mean maximum value allowed. Although initially
> designed to handle a -1 value, the reality is just about any negative
> value could be provided and essentially perform the same feature.
> 
> Signed-off-by: John Ferlan 
> ---
>  tools/virsh.pod | 23 +++
>  1 file changed, 19 insertions(+), 4 deletions(-)

ACK, I like the wording where you specify that the hypervisor may reject
that.

Peter




signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/2] virsh: Document bandwidth maximum more clearly

2014-07-16 Thread John Ferlan
Commit id '0e2d7305' modified the code to allow a negative value to be
supplied for the bandwidth argument of the various block virsh commands
and the migrate-setspeed; however, it failed to update the man page to
describe the "feature" whereby a very large value could be interpreted
by the hypervisor to mean maximum value allowed. Although initially
designed to handle a -1 value, the reality is just about any negative
value could be provided and essentially perform the same feature.

Signed-off-by: John Ferlan 
---
 tools/virsh.pod | 23 +++
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/tools/virsh.pod b/tools/virsh.pod
index e02ff5d..849ae31 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -865,7 +865,10 @@ to a unique target name () or source 
file () for one of the disk devices attached to I (see
 also B for listing these names).
 I specifies copying bandwidth limit in MiB/s, although for
-qemu, it may be non-zero only for an online domain.
+qemu, it may be non-zero only for an online domain. Specifying a negative
+value is interpreted as an unsigned long long value or essentially
+unlimited. The hypervisor can choose whether to reject the value or
+convert it to the maximum value allowed.
 
 =item B I I I [I] [I<--shallow>]
 [I<--reuse-external>] [I<--raw>] [I<--wait> [I<--async>] [I<--verbose>]]
@@ -908,7 +911,10 @@ as fast as possible, otherwise the command may continue to 
block a little
 while longer until the job has actually cancelled.
 
 I specifies fully-qualified path of the disk.
-I specifies copying bandwidth limit in MiB/s.
+I specifies copying bandwidth limit in MiB/s. Specifying a negative
+value is interpreted as an unsigned long long value or essentially
+unlimited. The hypervisor can choose whether to reject the value or
+convert it to the maximum value allowed.
 
 =item B I I [I] [I]
 [I<--wait> [I<--verbose>] [I<--timeout> B] [I<--async>]]
@@ -939,7 +945,10 @@ I specifies fully-qualified path of the disk; it 
corresponds
 to a unique target name () or source file () for one of the disk devices attached to I (see
 also B for listing these names).
-I specifies copying bandwidth limit in MiB/s.
+I specifies copying bandwidth limit in MiB/s. Specifying a negative
+value is interpreted as an unsigned long long value or essentially
+unlimited. The hypervisor can choose whether to reject the value or
+convert it to the maximum value allowed.
 
 =item B I I
 [[I<--config>] [I<--live>] | [I<--current>]]
@@ -995,6 +1004,9 @@ commit job be pivoted over to the new image.
 If I<--info> is specified, the active job information on the specified
 disk will be printed.
 I can be used to set bandwidth limit for the active job.
+Specifying a negative value is interpreted as an unsigned long long
+value or essentially unlimited. The hypervisor can choose whether to
+reject the value or convert it to the maximum value allowed.
 
 =item B I I I
 
@@ -1390,7 +1402,10 @@ obtained from domjobinfo.
 =item B I I
 
 Set the maximum migration bandwidth (in MiB/s) for a domain which is being
-migrated to another host.
+migrated to another host. I is interpreted as an unsigned long
+long value. Specifying a negative value results in an essentially unlimited
+value being provided to the hypervisor. The hypervisor can choose whether to
+reject the value or convert it to the maximum value allowed.
 
 =item B I
 
-- 
1.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list