[libvirt] [PATCH 2/3] build: remove ssp-buffer-size

2014-06-11 Thread Ján Tomko
This option only makes sense for -fstack-protector.
With -fstack-protector-all or -fstack-protector-strong,
functions are protected regardless of buffer size.

https://bugzilla.redhat.com/show_bug.cgi?id=1105456
---
 m4/virt-compile-warnings.m4 | 13 -
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4
index fb82238..196afa7 100644
--- a/m4/virt-compile-warnings.m4
+++ b/m4/virt-compile-warnings.m4
@@ -166,16 +166,11 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
*-*-linux*)
dnl Fedora only uses -fstack-protector, but doesn't seem to
dnl be great overhead in adding -fstack-protector-all instead
-   dnl wantwarn=$wantwarn -fstack-protector
+   dnl
+   dnl We also don't need ssp-buffer-size with -all,
+   dnl since functions are protected regardless of buffer size.
+   dnl wantwarn=$wantwarn --param=ssp-buffer-size=4
wantwarn=$wantwarn -fstack-protector-all
-   wantwarn=$wantwarn --param=ssp-buffer-size=4
-   dnl Even though it supports it, clang complains about
-   dnl use of --param=ssp-buffer-size=4 unless used with
-   dnl the -c arg. It doesn't like it when used with args
-   dnl that just link together .o files. Unfortunately
-   dnl we can't avoid that with automake, so we must turn
-   dnl off the following clang specific warning
-   wantwarn=$wantwarn -Wno-unused-command-line-argument
;;
*-*-freebsd*)
dnl FreeBSD ships old gcc 4.2.1 which doesn't handle
-- 
1.8.5.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH 2/3] build: remove ssp-buffer-size

2014-06-11 Thread Eric Blake
On 06/11/2014 03:00 AM, Ján Tomko wrote:
 This option only makes sense for -fstack-protector.
 With -fstack-protector-all or -fstack-protector-strong,
 functions are protected regardless of buffer size.
 
 https://bugzilla.redhat.com/show_bug.cgi?id=1105456
 ---
  m4/virt-compile-warnings.m4 | 13 -
  1 file changed, 4 insertions(+), 9 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list