[libvirt] [PATCH 2/4] vz: remove unused struct field

[Mikhail Feoktistov]

In commit 7039bb3c we have removed code that saves uuid to vzDomObj.uuid
So this field is no longer needed.
---
 src/vz/vz_sdk.c   | 5 -
 src/vz/vz_utils.h | 1 -
 2 files changed, 6 deletions(-)

diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index a47c5d6..3b7d7b3 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -419,7 +419,6 @@ prlsdkDomObjFreePrivate(void *p)
 PrlHandle_Free(pdom->sdkdom);
 PrlHandle_Free(pdom->cache.stats);
 virCondDestroy(>cache.cond);
-VIR_FREE(pdom->uuid);
 VIR_FREE(pdom->home);
 VIR_FREE(p);
 };
@@ -1287,10 +1286,6 @@ prlsdkLoadDomain(vzConnPtr privconn,
 
 def->id = -1;
 
-/* we will remove this field in the near future, so let's set it
- * to NULL temporarily */
-pdom->uuid = NULL;
-
 pdom->cache.stats = PRL_INVALID_HANDLE;
 pdom->cache.count = -1;
 if (virCondInit(>cache.cond) < 0) {
diff --git a/src/vz/vz_utils.h b/src/vz/vz_utils.h
index b7a4c81..417f821 100644
--- a/src/vz/vz_utils.h
+++ b/src/vz/vz_utils.h
@@ -76,7 +76,6 @@ typedef struct _vzCountersCache vzCountersCache;
 
 struct vzDomObj {
 int id;
-char *uuid;
 char *home;
 PRL_HANDLE sdkdom;
 vzCountersCache cache;
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/4] vz: remove unused struct field

[Nikolay Shirokovskiy]

On 28.01.2016 18:38, Mikhail Feoktistov wrote:
> In commit 7039bb3c we have removed code that saves uuid to vzDomObj.uuid
> So this field is no longer needed.
> ---
>  src/vz/vz_sdk.c   | 5 -
>  src/vz/vz_utils.h | 1 -
>  2 files changed, 6 deletions(-)
> 
> diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
> index 8181149..40ab2d9 100644
> --- a/src/vz/vz_sdk.c
> +++ b/src/vz/vz_sdk.c
> @@ -417,7 +417,6 @@ prlsdkDomObjFreePrivate(void *p)
>  PrlHandle_Free(pdom->sdkdom);
>  PrlHandle_Free(pdom->cache.stats);
>  virCondDestroy(>cache.cond);
> -VIR_FREE(pdom->uuid);
>  VIR_FREE(pdom->home);
>  VIR_FREE(p);
>  };
> @@ -1282,10 +1281,6 @@ prlsdkLoadDomain(vzConnPtr privconn,
>  
>  def->id = -1;
>  
> -/* we will remove this field in the near future, so let's set it
> - * to NULL temporarily */
> -pdom->uuid = NULL;
> -
>  pdom->cache.stats = PRL_INVALID_HANDLE;
>  pdom->cache.count = -1;
>  if (virCondInit(>cache.cond) < 0) {
> diff --git a/src/vz/vz_utils.h b/src/vz/vz_utils.h
> index 84cf08f..0fbbfc7 100644
> --- a/src/vz/vz_utils.h
> +++ b/src/vz/vz_utils.h
> @@ -75,7 +75,6 @@ typedef struct _vzCountersCache vzCountersCache;
>  
>  struct vzDomObj {
>  int id;
> -char *uuid;
>  char *home;
>  PRL_HANDLE sdkdom;
>  vzCountersCache cache;
> 

ACK

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/4] vz: remove unused struct field

[Mikhail Feoktistov]

In commit 7039bb3c we have removed code that saves uuid to vzDomObj.uuid
So this field is no longer needed.
---
 src/vz/vz_sdk.c   | 5 -
 src/vz/vz_utils.h | 1 -
 2 files changed, 6 deletions(-)

diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 8181149..40ab2d9 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -417,7 +417,6 @@ prlsdkDomObjFreePrivate(void *p)
 PrlHandle_Free(pdom->sdkdom);
 PrlHandle_Free(pdom->cache.stats);
 virCondDestroy(>cache.cond);
-VIR_FREE(pdom->uuid);
 VIR_FREE(pdom->home);
 VIR_FREE(p);
 };
@@ -1282,10 +1281,6 @@ prlsdkLoadDomain(vzConnPtr privconn,
 
 def->id = -1;
 
-/* we will remove this field in the near future, so let's set it
- * to NULL temporarily */
-pdom->uuid = NULL;
-
 pdom->cache.stats = PRL_INVALID_HANDLE;
 pdom->cache.count = -1;
 if (virCondInit(>cache.cond) < 0) {
diff --git a/src/vz/vz_utils.h b/src/vz/vz_utils.h
index 84cf08f..0fbbfc7 100644
--- a/src/vz/vz_utils.h
+++ b/src/vz/vz_utils.h
@@ -75,7 +75,6 @@ typedef struct _vzCountersCache vzCountersCache;
 
 struct vzDomObj {
 int id;
-char *uuid;
 char *home;
 PRL_HANDLE sdkdom;
 vzCountersCache cache;
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list