[libvirt] [PATCH 3/6] remote: Avoid calling virAuthConfigLookup() if 'credname' is NULL.

2013-01-07 Thread John Ferlan 
---
 src/remote/remote_driver.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index c078cb5..65fcc5b 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -3738,7 +3738,8 @@ static int remoteAuthFillFromConfig(virConnectPtr conn,
 break;
 }
 
-if (virAuthConfigLookup(state-config,
+if (credname 
+virAuthConfigLookup(state-config,
 libvirt,
 VIR_URI_SERVER(conn-uri),
 credname,
-- 
1.7.11.7

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/6] remote: Avoid calling virAuthConfigLookup() if 'credname' is NULL.

2013-01-07 Thread Daniel P. Berrange 
On Mon, Jan 07, 2013 at 12:09:31PM -0500, John Ferlan wrote:
 ---
  src/remote/remote_driver.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
 
 diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
 index c078cb5..65fcc5b 100644
 --- a/src/remote/remote_driver.c
 +++ b/src/remote/remote_driver.c
 @@ -3738,7 +3738,8 @@ static int remoteAuthFillFromConfig(virConnectPtr conn,
  break;
  }
  
 -if (virAuthConfigLookup(state-config,
 +if (credname 
 +virAuthConfigLookup(state-config,
  libvirt,
  VIR_URI_SERVER(conn-uri),
  credname,

ACK

Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list