[libvirt] [PATCH 5/8] qemu: hotplug: Add wrapper for disk hotplug code

2018-09-27 Thread Peter Krempa
The disk hotplug code also overloads media change which is not ideal.
This will allow splitting out of the media change code.

Signed-off-by: Peter Krempa 
---
 src/qemu/qemu_hotplug.c | 27 +++
 1 file changed, 23 insertions(+), 4 deletions(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 1ec696e2aa..6227a130da 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1061,10 +1061,10 @@ qemuDomainAttachUSBMassStorageDevice(virQEMUDriverPtr 
driver,
 }


-int
-qemuDomainAttachDeviceDiskLive(virQEMUDriverPtr driver,
-   virDomainObjPtr vm,
-   virDomainDeviceDefPtr dev)
+static int
+qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriverPtr driver,
+   virDomainObjPtr vm,
+   virDomainDeviceDefPtr dev)
 {
 size_t i;
 virDomainDiskDefPtr disk = dev->data.disk;
@@ -1157,6 +1157,25 @@ qemuDomainAttachDeviceDiskLive(virQEMUDriverPtr driver,
 }


+/**
+ * qemuDomainAttachDeviceDiskLive:
+ * @driver: qemu driver struct
+ * @vm: domain object
+ * @dev: device to attach (expected type is DISK)
+ *
+ * Attach a new disk or in case of cdroms/floppies change the media in the 
drive.
+ * This function handles all the necessary steps to attach a new storage source
+ * to the VM.
+ */
+int
+qemuDomainAttachDeviceDiskLive(virQEMUDriverPtr driver,
+   virDomainObjPtr vm,
+   virDomainDeviceDefPtr dev)
+{
+return qemuDomainAttachDeviceDiskLiveInternal(driver, vm, dev);
+}
+
+
 static void
 qemuDomainNetDeviceVportRemove(virDomainNetDefPtr net)
 {
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH 5/8] qemu: hotplug: Add wrapper for disk hotplug code

2018-10-02 Thread John Ferlan



On 9/27/18 11:09 AM, Peter Krempa wrote:
> The disk hotplug code also overloads media change which is not ideal.
> This will allow splitting out of the media change code.
> 
> Signed-off-by: Peter Krempa 
> ---
>  src/qemu/qemu_hotplug.c | 27 +++
>  1 file changed, 23 insertions(+), 4 deletions(-)
> 

Making future review/life easier ;-)

Reviewed-by: John Ferlan 

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list