Re: [libvirt] [PATCH 7/8] travis: Install more build dependencies
On Thu, Sep 14, 2017 at 04:09:37PM +0200, Andrea Bolognani wrote: > On Thu, 2017-09-14 at 14:50 +0100, Daniel P. Berrange wrote: > > > @@ -5,37 +5,60 @@ addons: > > >apt: > > > # Please keep this list sorted alphabetically > > > packages: > [...] > > > + - zfs-fuse > > > > Did you check if travis actually lets you install all these ? They have > > to whitelist each individual package that's desired. So if some of these > > aren't in the whitelist, adding them here will have no effect IIUC. > > That's kind of insane. They don't fully trust the security of the container env in which they populate the packages I guess. > Anyway, it looks like all the packages in the list are allowed, > so whatever :) Ok, Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 7/8] travis: Install more build dependencies
On Thu, 2017-09-14 at 14:50 +0100, Daniel P. Berrange wrote: > > @@ -5,37 +5,60 @@ addons: > >apt: > > # Please keep this list sorted alphabetically > > packages: [...] > > + - zfs-fuse > > Did you check if travis actually lets you install all these ? They have > to whitelist each individual package that's desired. So if some of these > aren't in the whitelist, adding them here will have no effect IIUC. That's kind of insane. Anyway, it looks like all the packages in the list are allowed, so whatever :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 7/8] travis: Install more build dependencies
On Thu, Sep 14, 2017 at 03:09:07PM +0200, Andrea Bolognani wrote: > Since configure automatically picks up as many optional dependencies > as possible, installing more packages allows us to improve our test > coverage. > > Signed-off-by: Andrea Bolognani > --- > .travis.yml | 37 ++--- > 1 file changed, 30 insertions(+), 7 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 154727fa3..f56e6ae6f 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -5,37 +5,60 @@ addons: >apt: > # Please keep this list sorted alphabetically > packages: > + - autoconf > + - automake >- autopoint > + - ccache >- dnsmasq-base > -# - dwarves > + - ebtables > + - gcc >- gettext > + - glusterfs-client > + - libacl1-dev >- libapparmor-dev > + - libattr1-dev >- libaudit-dev >- libavahi-client-dev > + - libblkid-dev > + - libc6-dev >- libcap-ng-dev > + - libcurl4-gnutls-dev > + - libdbus-1-dev >- libdevmapper-dev > - - libgcrypt11-dev > + - libfuse-dev >- libgnutls-dev > - - libncurses5-dev >- libnetcf-dev >- libnl-3-dev >- libnl-route-3-dev >- libnuma-dev > - - libparted0-dev > - - libpcap0.8-dev > + - libopenwsman-dev > + - libparted-dev > + - libpcap-dev >- libpciaccess-dev >- librbd-dev >- libreadline-dev >- libsasl2-dev > + - libssh2-1-dev > + - libssl-dev > + - libtool >- libudev-dev >- libxen-dev >- libxml2-dev >- libxml2-utils >- libyajl-dev >- lvm2 > - - uuid-dev > + - make > + - nfs-common > + - open-iscsi > + - parted > + - patch > + - pkg-config > + - policykit-1 > + - scrub > + - sheepdog > + - systemtap-sdt-dev >- xsltproc > - - zlib1g-dev > + - zfs-fuse > > notifications: >irc: Did you check if travis actually lets you install all these ? They have to whitelist each individual package that's desired. So if some of these aren't in the whitelist, adding them here will have no effect IIUC. Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH 7/8] travis: Install more build dependencies
Since configure automatically picks up as many optional dependencies as possible, installing more packages allows us to improve our test coverage. Signed-off-by: Andrea Bolognani --- .travis.yml | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index 154727fa3..f56e6ae6f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,37 +5,60 @@ addons: apt: # Please keep this list sorted alphabetically packages: + - autoconf + - automake - autopoint + - ccache - dnsmasq-base -# - dwarves + - ebtables + - gcc - gettext + - glusterfs-client + - libacl1-dev - libapparmor-dev + - libattr1-dev - libaudit-dev - libavahi-client-dev + - libblkid-dev + - libc6-dev - libcap-ng-dev + - libcurl4-gnutls-dev + - libdbus-1-dev - libdevmapper-dev - - libgcrypt11-dev + - libfuse-dev - libgnutls-dev - - libncurses5-dev - libnetcf-dev - libnl-3-dev - libnl-route-3-dev - libnuma-dev - - libparted0-dev - - libpcap0.8-dev + - libopenwsman-dev + - libparted-dev + - libpcap-dev - libpciaccess-dev - librbd-dev - libreadline-dev - libsasl2-dev + - libssh2-1-dev + - libssl-dev + - libtool - libudev-dev - libxen-dev - libxml2-dev - libxml2-utils - libyajl-dev - lvm2 - - uuid-dev + - make + - nfs-common + - open-iscsi + - parted + - patch + - pkg-config + - policykit-1 + - scrub + - sheepdog + - systemtap-sdt-dev - xsltproc - - zlib1g-dev + - zfs-fuse notifications: irc: -- 2.13.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list