Re: [libvirt] [PATCH V1 3/9] Add documentation for VLAN filtering support

2011-11-19 Thread Stefan Berger

On 11/18/2011 07:14 PM, Eric Blake wrote:

On 10/26/2011 09:12 AM, Stefan Berger wrote:

Add documentation for the VLAN filtering support. Describe the XML attributes
that are supported.

Signed-off-by: Stefan Bergerstef...@linux.vnet.ibm.com

Not sure if this overlaps with any of the stuff you pulled in earlier
(it will be Monday before I get my development tree back into a state
where I can apply this to actually test it).  But in general, adding
docs is good.


+br/
+  Note: Rules of this type should go eitherinto thecoderoot/code  or

s/eitherinto/either into/

ACK with the typo fixed, assuming it still applies fairly easily.


Was not a problem... I now pushed the 3 VLAN related patches. Thanks.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH V1 3/9] Add documentation for VLAN filtering support

2011-11-18 Thread Eric Blake
On 10/26/2011 09:12 AM, Stefan Berger wrote:
 Add documentation for the VLAN filtering support. Describe the XML attributes
 that are supported.
 
 Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com

Not sure if this overlaps with any of the stuff you pulled in earlier
(it will be Monday before I get my development tree back into a state
where I can apply this to actually test it).  But in general, adding
docs is good.

 +  br/
 +  Note: Rules of this type should go eitherinto the coderoot/code or

s/eitherinto/either into/

ACK with the typo fixed, assuming it still applies fairly easily.

-- 
Eric Blake   ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH V1 3/9] Add documentation for VLAN filtering support

2011-10-26 Thread Stefan Berger
Add documentation for the VLAN filtering support. Describe the XML attributes
that are supported.

Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com

---
 docs/formatnwfilter.html.in |   55 
 1 file changed, 55 insertions(+)

Index: libvirt-acl/docs/formatnwfilter.html.in
===
--- libvirt-acl.orig/docs/formatnwfilter.html.in
+++ libvirt-acl/docs/formatnwfilter.html.in
@@ -412,6 +412,61 @@
 [...]
 /pre
 
+h5a name=nwfelemsRulesProtoVLANVLAN (802.1Q)/a
+  span class=since(Since 0.9.7)/span
+/h5
+p
+  Protocol ID: codevlan/code
+  br/
+  Note: Rules of this type should go eitherinto the coderoot/code or
+  codevlan/code chain.
+/p
+  table class=top_table
+   tr
+ th Attribute /th
+ th Datatype /th
+ th Semantics /th
+   /tr
+   tr
+ tdsrcmacaddr/td
+ tdMAC_ADDR/td
+ tdMAC address of sender/td
+   /tr
+   tr
+ tdsrcmacmask/td
+ tdMAC_MASK/td
+ tdMask applied to MAC address of sender/td
+   /tr
+   tr
+ tddstmacaddr/td
+ tdMAC_ADDR/td
+ tdMAC address of destination/td
+   /tr
+   tr
+ tddstmacmask/td
+ tdMAC_MASK/td
+ tdMask applied to MAC address of destination/td
+   /tr
+   tr
+ tdvlan-id/td
+ tdUINT16 (0x0-0xfff, 0 - 4095)/td
+ tdVLAN ID/td
+   /tr
+   tr
+ tdencap-protocol/td
+ tdUINT16 (0x03c-0xfff), String/td
+ tdEncapsulated layer 3 protocol ID/td
+   /tr
+   tr
+ tdcomment /td
+ tdSTRING/td
+ tdtext with max. 256 characters/td
+   /tr
+  /table
+p
+  Valid Strings for codeencap-protocol/code are: arp, ipv4, ipv6
+/p
+
 h5a name=nwfelemsRulesProtoARPARP/RARP/a/h5
 p
   Protocol ID: codearp/code or coderarp/code

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list