Re: [libvirt] [PATCH V1 6/9] Add test cases for STP traffic filtering

[Eric Blake]

On 10/26/2011 09:12 AM, Stefan Berger wrote:
 This patch adds a few test cases for the XML parsing of STP filtering nodes.
 
 Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
 
 ---
  tests/nwfilterxml2xmlin/stp-test.xml  |   26 ++
  tests/nwfilterxml2xmlout/stp-test.xml |   12 
  tests/nwfilterxml2xmltest.c   |1 +
  3 files changed, 39 insertions(+)

Looks good.  ACK.

 +  rule action='reject' direction='in'
 + stp srcmacaddr='1:2:3:4:5:6' srcmacmask='ff:ff:ff:ff:ff:ff'
 +  sender-priority='0x1234'
 +  sender-address=6:5:4:3:2:1
 +  port='123' port-hi='234'
 +  age='5544' age-hi=''
 +  max-age=''  max-age-hi=''
 +  hello-time='12345' hello-time-hi='12346'
 +  forward-delay='54321' forward-delay-hi='65432'/

That's a lot of attributes for one element, thankfully we can split it
over multiple lines.

-- 
Eric Blake   ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH V1 6/9] Add test cases for STP traffic filtering

[Stefan Berger]

This patch adds a few test cases for the XML parsing of STP filtering nodes.

Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com

---
 tests/nwfilterxml2xmlin/stp-test.xml  |   26 ++
 tests/nwfilterxml2xmlout/stp-test.xml |   12 
 tests/nwfilterxml2xmltest.c   |1 +
 3 files changed, 39 insertions(+)

Index: libvirt-acl/tests/nwfilterxml2xmlin/stp-test.xml
===
--- /dev/null
+++ libvirt-acl/tests/nwfilterxml2xmlin/stp-test.xml
@@ -0,0 +1,26 @@
+filter name='testcase' chain='stp-xyz'
+  uuid5c6d49af-b071-6127-b4ec-6f8ed4b55335/uuid
+  rule action='continue' direction='in'
+ stp srcmacaddr='1:2:3:4:5:6' srcmacmask='ff:ff:ff:ff:ff:ff'
+  type='0x12' flags='0x44'/
+  /rule
+
+  rule action='return' direction='out'
+ stp srcmacaddr='1:2:3:4:5:6' srcmacmask='ff:ff:ff:ff:ff:ff'
+  root-priority='0x1234' root-priority-hi='0x2345'
+  root-address=6:5:4:3:2:1 root-address-mask='ff:ff:ff:ff:ff:ff'
+  root-cost='0x11223344' root-cost-hi='0x22334455' /
+  /rule
+
+  rule action='reject' direction='in'
+ stp srcmacaddr='1:2:3:4:5:6' srcmacmask='ff:ff:ff:ff:ff:ff'
+  sender-priority='0x1234'
+  sender-address=6:5:4:3:2:1
+  port='123' port-hi='234'
+  age='5544' age-hi=''
+  max-age=''  max-age-hi=''
+  hello-time='12345' hello-time-hi='12346'
+  forward-delay='54321' forward-delay-hi='65432'/
+  /rule
+
+/filter
Index: libvirt-acl/tests/nwfilterxml2xmltest.c
===
--- libvirt-acl.orig/tests/nwfilterxml2xmltest.c
+++ libvirt-acl/tests/nwfilterxml2xmltest.c
@@ -109,6 +109,7 @@ mymain(void)
 
 DO_TEST(mac-test, true);
 DO_TEST(vlan-test, true);
+DO_TEST(stp-test, false);
 DO_TEST(arp-test, true);
 DO_TEST(rarp-test, true);
 DO_TEST(ip-test, true);
Index: libvirt-acl/tests/nwfilterxml2xmlout/stp-test.xml
===
--- /dev/null
+++ libvirt-acl/tests/nwfilterxml2xmlout/stp-test.xml
@@ -0,0 +1,12 @@
+filter name='testcase' chain='stp-xyz'
+  uuid5c6d49af-b071-6127-b4ec-6f8ed4b55335/uuid
+  rule action='continue' direction='in' priority='500'
+stp srcmacaddr='01:02:03:04:05:06' srcmacmask='ff:ff:ff:ff:ff:ff' 
type='0x12' flags='0x44'/
+  /rule
+  rule action='return' direction='out' priority='500'
+stp srcmacaddr='01:02:03:04:05:06' srcmacmask='ff:ff:ff:ff:ff:ff' 
root-priority='0x1234' root-priority-hi='0x2345' 
root-address='06:05:04:03:02:01' root-address-mask='ff:ff:ff:ff:ff:ff' 
root-cost='0x11223344' root-cost-hi='0x22334455'/
+  /rule
+  rule action='reject' direction='in' priority='500'
+stp srcmacaddr='01:02:03:04:05:06' srcmacmask='ff:ff:ff:ff:ff:ff' 
sender-priority='0x1234' sender-address='06:05:04:03:02:01' port='123' 
port-hi='234' age='5544' age-hi='' max-age='' max-age-hi='' 
hello-time='12345' hello-time-hi='12346' forward-delay='54321' 
forward-delay-hi='65432'/
+  /rule
+/filter

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list