Re: [libvirt] [PATCH V2 0/2] fix xen HVM pae|apic|acpi features parser

2015-01-04 Thread Jim Fehlig 
Chunyan Liu wrote:
 According to xm.config manual, HVM pae|apic|acpi feature default
 is 1 (enabled). But in conversion from xm config to libvirt xml,
 if xm config doesn't contain pae|apic|acpi, it sets default value
 to 0, this causes some problems in HVM guest.

 Update parser codes to set HVM pae|apic|acpi default value to 1
 to match xm config convension.

 Add tests data to test it.

 ---
 Changes to v1:
* update xmconfigtest

 Chunyan Liu (2):
   xenconfig: set HVM pae/apic/acpi/ default to 1
   Add tests to xmconfigtest

  src/xenconfig/xen_common.c |  6 +--
  .../xmconfigdata/test-fullvirt-default-feature.cfg | 23 +++
  .../xmconfigdata/test-fullvirt-default-feature.xml | 48 
 ++
  tests/xmconfigtest.c   | 20 -
  4 files changed, 92 insertions(+), 5 deletions(-)
  create mode 100644 tests/xmconfigdata/test-fullvirt-default-feature.cfg
  create mode 100644 tests/xmconfigdata/test-fullvirt-default-feature.xml
   

ACK series, and now pushed.  Thanks Chunyan!

Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH V2 0/2] fix xen HVM pae|apic|acpi features parser

2014-12-22 Thread Chunyan Liu 
According to xm.config manual, HVM pae|apic|acpi feature default
is 1 (enabled). But in conversion from xm config to libvirt xml,
if xm config doesn't contain pae|apic|acpi, it sets default value
to 0, this causes some problems in HVM guest.

Update parser codes to set HVM pae|apic|acpi default value to 1
to match xm config convension.

Add tests data to test it.

---
Changes to v1:
   * update xmconfigtest

Chunyan Liu (2):
  xenconfig: set HVM pae/apic/acpi/ default to 1
  Add tests to xmconfigtest

 src/xenconfig/xen_common.c |  6 +--
 .../xmconfigdata/test-fullvirt-default-feature.cfg | 23 +++
 .../xmconfigdata/test-fullvirt-default-feature.xml | 48 ++
 tests/xmconfigtest.c   | 20 -
 4 files changed, 92 insertions(+), 5 deletions(-)
 create mode 100644 tests/xmconfigdata/test-fullvirt-default-feature.cfg
 create mode 100644 tests/xmconfigdata/test-fullvirt-default-feature.xml

-- 
1.8.4.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list