Re: [libvirt] [PATCH for 1.3.3 0/5] Fix parsing our own XMLs
On Mon, Apr 04, 2016 at 08:52:22AM +0200, Michal Privoznik wrote: On 03.04.2016 21:27, Martin Kletzander wrote: Laine found out that he can't do 'virsh nodedev-detach pci_dev' because of some strange error message. That was caused by my commit, but also by all the previous ones that skipped adding tests and parsing of new functions. In order for this to work in 1.3.3, we need either a) only the first patch or b) all of them. I specifically created the first one so that it has enough in itself to fix the problem and we don't need to push more and more patches into the release. We can push the rest after release. If someone wants to have all in for 1.3.3, well, I hope I added enough tests for that ;) Martin Kletzander (5): nodedev: Fix parsing of generated XMLs Change virPCIDeviceAddress to virDevicePCIAddress Move capability formatting together schemas: Update nodedev schema to match reality conf: Parse more of our nodedev XML docs/schemas/nodedev.rng | 29 +++-- src/conf/device_conf.h | 11 +- src/conf/node_device_conf.c| 121 ++--- src/conf/node_device_conf.h| 6 +- src/libvirt_private.syms | 10 +- src/network/bridge_driver.c| 4 +- src/node_device/node_device_linux_sysfs.c | 6 +- src/util/virhostdev.c | 12 +- src/util/virnetdev.c | 4 +- src/util/virnetdev.h | 2 +- src/util/virpci.c | 80 +++--- src/util/virpci.h | 29 ++--- .../pci__00_1c_0_header_type.xml | 2 +- tests/nodedevschemadata/pci__02_10_7_sriov.xml | 23 .../pci__02_10_7_sriov_pf_vfs_all.xml | 29 + ...i__02_10_7_sriov_pf_vfs_all_header_type.xml | 30 + .../pci__02_10_7_sriov_vfs.xml | 26 + .../pci__02_10_7_sriov_zero_vfs_max_count.xml | 21 tests/nodedevxml2xmltest.c | 5 + 19 files changed, 333 insertions(+), 117 deletions(-) create mode 100644 tests/nodedevschemadata/pci__02_10_7_sriov.xml create mode 100644 tests/nodedevschemadata/pci__02_10_7_sriov_pf_vfs_all.xml create mode 100644 tests/nodedevschemadata/pci__02_10_7_sriov_pf_vfs_all_header_type.xml create mode 100644 tests/nodedevschemadata/pci__02_10_7_sriov_vfs.xml create mode 100644 tests/nodedevschemadata/pci__02_10_7_sriov_zero_vfs_max_count.xml I like this. I really do. And if we were not in the freeze, I would ACK this straight away. But since we are in the freeze, we should push only (small) bug fixes. And I think the minimum needed here is 1/5, right? Therefore, I'd suggest pushing that one and saving the rest for after the release. Is that okay with you? Yes, that's exactly what I wrote in the cover letter. So I'm pushing the first one now and we can talk about the naming and shed colours after the release ;) Thanks Michal signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH for 1.3.3 0/5] Fix parsing our own XMLs
On 03.04.2016 21:27, Martin Kletzander wrote: > Laine found out that he can't do 'virsh nodedev-detach pci_dev' > because of some strange error message. That was caused by my commit, > but also by all the previous ones that skipped adding tests and > parsing of new functions. In order for this to work in 1.3.3, we need > either a) only the first patch or b) all of them. I specifically > created the first one so that it has enough in itself to fix the > problem and we don't need to push more and more patches into the > release. We can push the rest after release. If someone wants to > have all in for 1.3.3, well, I hope I added enough tests for that ;) > > > Martin Kletzander (5): > nodedev: Fix parsing of generated XMLs > Change virPCIDeviceAddress to virDevicePCIAddress > Move capability formatting together > schemas: Update nodedev schema to match reality > conf: Parse more of our nodedev XML > > docs/schemas/nodedev.rng | 29 +++-- > src/conf/device_conf.h | 11 +- > src/conf/node_device_conf.c| 121 > ++--- > src/conf/node_device_conf.h| 6 +- > src/libvirt_private.syms | 10 +- > src/network/bridge_driver.c| 4 +- > src/node_device/node_device_linux_sysfs.c | 6 +- > src/util/virhostdev.c | 12 +- > src/util/virnetdev.c | 4 +- > src/util/virnetdev.h | 2 +- > src/util/virpci.c | 80 +++--- > src/util/virpci.h | 29 ++--- > .../pci__00_1c_0_header_type.xml | 2 +- > tests/nodedevschemadata/pci__02_10_7_sriov.xml | 23 > .../pci__02_10_7_sriov_pf_vfs_all.xml | 29 + > ...i__02_10_7_sriov_pf_vfs_all_header_type.xml | 30 + > .../pci__02_10_7_sriov_vfs.xml | 26 + > .../pci__02_10_7_sriov_zero_vfs_max_count.xml | 21 > tests/nodedevxml2xmltest.c | 5 + > 19 files changed, 333 insertions(+), 117 deletions(-) > create mode 100644 tests/nodedevschemadata/pci__02_10_7_sriov.xml > create mode 100644 > tests/nodedevschemadata/pci__02_10_7_sriov_pf_vfs_all.xml > create mode 100644 > tests/nodedevschemadata/pci__02_10_7_sriov_pf_vfs_all_header_type.xml > create mode 100644 tests/nodedevschemadata/pci__02_10_7_sriov_vfs.xml > create mode 100644 > tests/nodedevschemadata/pci__02_10_7_sriov_zero_vfs_max_count.xml > I like this. I really do. And if we were not in the freeze, I would ACK this straight away. But since we are in the freeze, we should push only (small) bug fixes. And I think the minimum needed here is 1/5, right? Therefore, I'd suggest pushing that one and saving the rest for after the release. Is that okay with you? Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH for 1.3.3 0/5] Fix parsing our own XMLs
Laine found out that he can't do 'virsh nodedev-detach pci_dev' because of some strange error message. That was caused by my commit, but also by all the previous ones that skipped adding tests and parsing of new functions. In order for this to work in 1.3.3, we need either a) only the first patch or b) all of them. I specifically created the first one so that it has enough in itself to fix the problem and we don't need to push more and more patches into the release. We can push the rest after release. If someone wants to have all in for 1.3.3, well, I hope I added enough tests for that ;) Martin Kletzander (5): nodedev: Fix parsing of generated XMLs Change virPCIDeviceAddress to virDevicePCIAddress Move capability formatting together schemas: Update nodedev schema to match reality conf: Parse more of our nodedev XML docs/schemas/nodedev.rng | 29 +++-- src/conf/device_conf.h | 11 +- src/conf/node_device_conf.c| 121 ++--- src/conf/node_device_conf.h| 6 +- src/libvirt_private.syms | 10 +- src/network/bridge_driver.c| 4 +- src/node_device/node_device_linux_sysfs.c | 6 +- src/util/virhostdev.c | 12 +- src/util/virnetdev.c | 4 +- src/util/virnetdev.h | 2 +- src/util/virpci.c | 80 +++--- src/util/virpci.h | 29 ++--- .../pci__00_1c_0_header_type.xml | 2 +- tests/nodedevschemadata/pci__02_10_7_sriov.xml | 23 .../pci__02_10_7_sriov_pf_vfs_all.xml | 29 + ...i__02_10_7_sriov_pf_vfs_all_header_type.xml | 30 + .../pci__02_10_7_sriov_vfs.xml | 26 + .../pci__02_10_7_sriov_zero_vfs_max_count.xml | 21 tests/nodedevxml2xmltest.c | 5 + 19 files changed, 333 insertions(+), 117 deletions(-) create mode 100644 tests/nodedevschemadata/pci__02_10_7_sriov.xml create mode 100644 tests/nodedevschemadata/pci__02_10_7_sriov_pf_vfs_all.xml create mode 100644 tests/nodedevschemadata/pci__02_10_7_sriov_pf_vfs_all_header_type.xml create mode 100644 tests/nodedevschemadata/pci__02_10_7_sriov_vfs.xml create mode 100644 tests/nodedevschemadata/pci__02_10_7_sriov_zero_vfs_max_count.xml -- 2.8.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
