Re: [libvirt] [PATCH qom-cpu 06/11] target-i386: check/enforce: Do not ignore hypervisor flag

2013-01-06 Thread Gleb Natapov
On Fri, Jan 04, 2013 at 08:01:07PM -0200, Eduardo Habkost wrote:
 We don't need any hack to ignore CPUID_EXT_HYPERVISOR anymore, because
 kvm_arch_get_supported_cpuid() now set CPUID_EXT_HYPERVISOR properly.
 So, this shouldn't introduce any behavior change, but it makes the code
 simpler.
 
 Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Reviewed-by: Gleb Natapov g...@redhat.com

 ---
 My goal is to eliminate the check_feat field completely, as
 kvm_arch_get_supported_cpuid() should now really return all the bits we
 can set on all CPUID leaves.
 ---
  target-i386/cpu.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/target-i386/cpu.c b/target-i386/cpu.c
 index c3e5db8..42c4c99 100644
 --- a/target-i386/cpu.c
 +++ b/target-i386/cpu.c
 @@ -970,7 +970,7 @@ static int kvm_check_features_against_host(x86_def_t 
 *guest_def)
  {guest_def-features, host_def.features,
  ~0, feature_name, 0x0001, R_EDX},
  {guest_def-ext_features, host_def.ext_features,
 -~CPUID_EXT_HYPERVISOR, ext_feature_name, 0x0001, R_ECX},
 +~0, ext_feature_name, 0x0001, R_ECX},
  {guest_def-ext2_features, host_def.ext2_features,
  ~PPRO_FEATURES, ext2_feature_name, 0x8001, R_EDX},
  {guest_def-ext3_features, host_def.ext3_features,
 -- 
 1.7.11.7
 
 --
 To unsubscribe from this list: send the line unsubscribe kvm in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
Gleb.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH qom-cpu 06/11] target-i386: check/enforce: Do not ignore hypervisor flag

2013-01-04 Thread Eduardo Habkost
We don't need any hack to ignore CPUID_EXT_HYPERVISOR anymore, because
kvm_arch_get_supported_cpuid() now set CPUID_EXT_HYPERVISOR properly.
So, this shouldn't introduce any behavior change, but it makes the code
simpler.

Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
My goal is to eliminate the check_feat field completely, as
kvm_arch_get_supported_cpuid() should now really return all the bits we
can set on all CPUID leaves.
---
 target-i386/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index c3e5db8..42c4c99 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -970,7 +970,7 @@ static int kvm_check_features_against_host(x86_def_t 
*guest_def)
 {guest_def-features, host_def.features,
 ~0, feature_name, 0x0001, R_EDX},
 {guest_def-ext_features, host_def.ext_features,
-~CPUID_EXT_HYPERVISOR, ext_feature_name, 0x0001, R_ECX},
+~0, ext_feature_name, 0x0001, R_ECX},
 {guest_def-ext2_features, host_def.ext2_features,
 ~PPRO_FEATURES, ext2_feature_name, 0x8001, R_EDX},
 {guest_def-ext3_features, host_def.ext3_features,
-- 
1.7.11.7

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list