Re: [libvirt] [PATCH v2] Report more correct information for cache control

2017-06-16 Thread Pavel Hrdina 
On Fri, Jun 09, 2017 at 10:52:20AM +0200, Martin Kletzander wrote:
> On some platforms the number of bits in the cbm_mask might not be
> divisible by 4 (and not even by 2), so we need to properly count the
> bits.  Similar file, min_cbm_bits, is properly parsed and used, but if
> the number is greater than one, we lose the information about
> granularity when reporting the data in capabilities.  For that matter
> always report granularity, but if it is not the same as the minimum,
> add that information in there as well.
> 
> Signed-off-by: Martin Kletzander 
> ---
> v2:
>  - More expressive comments for structure members
>  - Cache size adjusted to match the SKX machine (33M)
> 
> v1:
>  - https://www.redhat.com/archives/libvir-list/2017-June/msg00229.html
> 
>  docs/schemas/capability.rng|  7 -
>  src/conf/capabilities.c| 34 
> ++
>  src/conf/capabilities.h| 11 +--

Reviewed-by: Pavel Hrdina 


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2] Report more correct information for cache control

2017-06-11 Thread Eli Qiao 
Thanks martin, 

Looks good to me. 


On Friday, 9 June 2017 at 4:52 PM, Martin Kletzander wrote:

> On some platforms the number of bits in the cbm_mask might not be
> divisible by 4 (and not even by 2), so we need to properly count the
> bits. Similar file, min_cbm_bits, is properly parsed and used, but if
> the number is greater than one, we lose the information about
> granularity when reporting the data in capabilities. For that matter
> always report granularity, but if it is not the same as the minimum,
> add that information in there as well.
> 
> Signed-off-by: Martin Kletzander  (mailto:mklet...@redhat.com)>
> ---
> v2:
> - More expressive comments for structure members
> - Cache size adjusted to match the SKX machine (33M)
> 
> v1:
> - https://www.redhat.com/archives/libvir-list/2017-June/msg00229.html
> 
ACK 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2] Report more correct information for cache control

2017-06-09 Thread Martin Kletzander 
On some platforms the number of bits in the cbm_mask might not be
divisible by 4 (and not even by 2), so we need to properly count the
bits.  Similar file, min_cbm_bits, is properly parsed and used, but if
the number is greater than one, we lose the information about
granularity when reporting the data in capabilities.  For that matter
always report granularity, but if it is not the same as the minimum,
add that information in there as well.

Signed-off-by: Martin Kletzander 
---
v2:
 - More expressive comments for structure members
 - Cache size adjusted to match the SKX machine (33M)

v1:
 - https://www.redhat.com/archives/libvir-list/2017-June/msg00229.html

 docs/schemas/capability.rng|  7 -
 src/conf/capabilities.c| 34 ++
 src/conf/capabilities.h| 11 +--
 .../linux-resctrl-skx/resctrl/info/L3/cbm_mask |  1 +
 .../linux-resctrl-skx/resctrl/info/L3/min_cbm_bits |  1 +
 .../linux-resctrl-skx/resctrl/info/L3/num_closids  |  1 +
 .../linux-resctrl-skx/resctrl/schemata |  1 +
 .../system/cpu/cpu0/cache/index0/id|  1 +
 .../system/cpu/cpu0/cache/index0/level |  1 +
 .../system/cpu/cpu0/cache/index0/shared_cpu_list   |  1 +
 .../system/cpu/cpu0/cache/index0/shared_cpu_map|  1 +
 .../system/cpu/cpu0/cache/index0/size  |  1 +
 .../system/cpu/cpu0/cache/index0/type  |  1 +
 .../linux-resctrl-skx/system/cpu/cpu0/online   |  1 +
 .../system/cpu/cpu0/topology/core_id   |  1 +
 .../system/cpu/cpu0/topology/core_siblings |  1 +
 .../system/cpu/cpu0/topology/core_siblings_list|  1 +
 .../system/cpu/cpu0/topology/physical_package_id   |  1 +
 .../system/cpu/cpu0/topology/thread_siblings   |  1 +
 .../system/cpu/cpu0/topology/thread_siblings_list  |  1 +
 .../linux-resctrl-skx/system/cpu/online|  1 +
 .../linux-resctrl-skx/system/cpu/present   |  1 +
 .../linux-resctrl-skx/system/node/node0/cpu0   |  1 +
 .../linux-resctrl-skx/system/node/node0/cpulist|  1 +
 .../linux-resctrl-skx/system/node/node0/cpumap |  1 +
 .../linux-resctrl-skx/system/node/node0/distance   |  1 +
 .../linux-resctrl-skx/system/node/online   |  1 +
 .../vircaps2xmldata/vircaps-x86_64-resctrl-cdp.xml |  8 ++---
 .../vircaps2xmldata/vircaps-x86_64-resctrl-skx.xml | 31 
 tests/vircaps2xmldata/vircaps-x86_64-resctrl.xml   |  4 +--
 tests/vircaps2xmltest.c|  1 +
 31 files changed, 104 insertions(+), 16 deletions(-)
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/resctrl/info/L3/cbm_mask
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/resctrl/info/L3/min_cbm_bits
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/resctrl/info/L3/num_closids
 create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx/resctrl/schemata
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/cache/index0/id
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/cache/index0/level
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/cache/index0/shared_cpu_list
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/cache/index0/shared_cpu_map
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/cache/index0/size
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/cache/index0/type
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/online
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/topology/core_id
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/topology/core_siblings
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/topology/core_siblings_list
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/topology/physical_package_id
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/topology/thread_siblings
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/cpu0/topology/thread_siblings_list
 create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/online
 create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx/system/cpu/present
 create mode 12 
tests/vircaps2xmldata/linux-resctrl-skx/system/node/node0/cpu0
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/node/node0/cpulist
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/node/node0/cpumap
 create mode 100644 
tests/vircaps2xmldata/linux-resctrl-skx/system/node/node0/distance
 create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx/system/node/online
 create mode 100644 tests/vircaps2xmldata/vircaps-x86_64-resctrl-skx.xml

diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng
index