Re: [libvirt] [PATCH v2 0/4] various test fixes and handling of input devices
On 12.01.2016 12:59, Pavel Hrdina wrote: > Some of the patches from v1 series are already pushed, only those 4 left for > review. > > Pavel Hrdina (4): > tests: use virtTestDifferenceFull in tests where we have output file > tests: add some missing tests to qemuxml2xmltest > device: cleanup input device code > tests: update test XML files to follow input changes > > src/Makefile.am| 4 +- > src/conf/domain_conf.c | 82 > +++--- > src/libxl/libxl_domain.c | 5 ++ > src/qemu/qemu_domain.c | 23 ++ > src/xen/xen_driver.c | 5 ++ > src/xenapi/xenapi_driver.c | 5 ++ > src/xenconfig/xen_common.c | 22 ++ > src/xenconfig/xen_common.h | 2 + > .../disk_snapshot_redefine.xml | 2 + > .../external_vm_redefine.xml | 2 + > tests/domainsnapshotxml2xmlout/full_domain.xml | 2 + > tests/domainsnapshotxml2xmlout/metadata.xml| 2 + > tests/domainsnapshotxml2xmltest.c | 2 +- > tests/interfacexml2xmltest.c | 2 +- > tests/lxcconf2xmltest.c| 2 +- > tests/nodedevxml2xmltest.c | 2 +- > tests/qemuhotplugtest.c| 11 ++- > .../qemuhotplug-hotplug-base+disk-scsi.xml | 2 + > .../qemuhotplug-hotplug-base+disk-usb.xml | 2 + > .../qemuhotplug-hotplug-base+disk-virtio.xml | 2 + > tests/qemuxml2argvdata/qemuxml2argv-bios-nvram.xml | 2 + > .../qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml | 2 + > .../qemuxml2argv-blkiotune-device.xml | 2 + > tests/qemuxml2argvdata/qemuxml2argv-blkiotune.xml | 2 + > tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml | 2 + > .../qemuxml2argvdata/qemuxml2argv-boot-floppy.xml | 2 + > .../qemuxml2argv-boot-menu-disable.xml | 2 + > .../qemuxml2argv-boot-menu-enable-with-timeout.xml | 2 + > tests/qemuxml2argvdata/qemuxml2argv-boot-multi.xml | 2 + > .../qemuxml2argvdata/qemuxml2argv-boot-network.xml | 2 + > tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml | 2 + > .../qemuxml2argv-channel-guestfwd.xml | 2 + > .../qemuxml2argv-channel-virtio.xml| 2 + > .../qemuxml2argv-chardev-label.xml | 2 + > .../qemuxml2argv-clock-catchup.xml | 2 + > .../qemuxml2argv-clock-localtime.xml | 2 + > .../qemuxml2argv-clock-timer-hyperv-rtc.xml| 2 + > tests/qemuxml2argvdata/qemuxml2argv-clock-utc.xml | 2 + > .../qemuxml2argv-console-compat.xml| 2 + > .../qemuxml2argv-console-virtio-many.xml | 2 + > .../qemuxml2argv-cpu-eoi-disabled.xml | 2 + > .../qemuxml2argv-cpu-eoi-enabled.xml | 2 + > .../qemuxml2argv-cpu-host-kvmclock.xml | 2 + > .../qemuxml2argv-cpu-host-model-features.xml | 2 + > .../qemuxml2argv-cpu-host-passthrough-features.xml | 2 + > .../qemuxml2argvdata/qemuxml2argv-cpu-kvmclock.xml | 2 + > .../qemuxml2argv-cpu-numa-disjoint.xml | 2 + > .../qemuxml2argv-cpu-numa-memshared.xml| 2 + > ...xml2argv-cputune-iothreadsched-zeropriority.xml | 2 + > .../qemuxml2argv-cputune-numatune.xml | 2 + > .../qemuxml2argv-cputune-zero-shares.xml | 2 + > tests/qemuxml2argvdata/qemuxml2argv-cputune.xml| 2 + > .../qemuxml2argv-disk-active-commit.xml| 2 + > tests/qemuxml2argvdata/qemuxml2argv-disk-aio.xml | 2 + > .../qemuxml2argv-disk-cdrom-empty.xml | 2 + > tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom.xml | 2 + > .../qemuxml2argv-disk-copy_on_read.xml | 2 + > .../qemuxml2argv-disk-drive-boot-cdrom.xml | 3 + > .../qemuxml2argv-disk-drive-boot-disk.xml | 3 + > .../qemuxml2argv-disk-drive-cache-directsync.xml | 2 + > .../qemuxml2argv-disk-drive-cache-unsafe.xml | 2 + > .../qemuxml2argv-disk-drive-cache-v2-none.xml | 2 + > .../qemuxml2argv-disk-drive-cache-v2-wb.xml| 2 + > .../qemuxml2argv-disk-drive-cache-v2-wt.xml| 2 + > .../qemuxml2argv-disk-drive-copy-on-read.xml | 2 + > ...muxml2argv-disk-drive-error-policy-enospace.xml | 2 + > .../qemuxml2argv-disk-drive-error-policy-stop.xml | 2 + > ...rgv-disk-drive-error-policy-wreport-rignore.xml | 2 + > .../qemuxml2argv-disk-drive-fat.xml| 2 + > .../qemuxml2argv-disk-drive-fmt-qcow.xml | 2 + > .../qemuxml2argv-disk-drive-network-gluster.xml| 2 + > .../qemuxml2argv-disk-drive-network-iscsi-auth.xml | 2 + > .../qemuxml2argv-disk-drive-network-iscsi.xml | 2 + > .../qemuxml2argv-disk-drive-network-nbd-export.xml | 2 + > ...xml2argv-disk-drive-network-nbd-ipv6-export.xml | 2 + >
Re: [libvirt] [PATCH v2 0/4] various test fixes and handling of input devices
ping -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH v2 0/4] various test fixes and handling of input devices
Some of the patches from v1 series are already pushed, only those 4 left for review. Pavel Hrdina (4): tests: use virtTestDifferenceFull in tests where we have output file tests: add some missing tests to qemuxml2xmltest device: cleanup input device code tests: update test XML files to follow input changes src/Makefile.am| 4 +- src/conf/domain_conf.c | 82 +++--- src/libxl/libxl_domain.c | 5 ++ src/qemu/qemu_domain.c | 23 ++ src/xen/xen_driver.c | 5 ++ src/xenapi/xenapi_driver.c | 5 ++ src/xenconfig/xen_common.c | 22 ++ src/xenconfig/xen_common.h | 2 + .../disk_snapshot_redefine.xml | 2 + .../external_vm_redefine.xml | 2 + tests/domainsnapshotxml2xmlout/full_domain.xml | 2 + tests/domainsnapshotxml2xmlout/metadata.xml| 2 + tests/domainsnapshotxml2xmltest.c | 2 +- tests/interfacexml2xmltest.c | 2 +- tests/lxcconf2xmltest.c| 2 +- tests/nodedevxml2xmltest.c | 2 +- tests/qemuhotplugtest.c| 11 ++- .../qemuhotplug-hotplug-base+disk-scsi.xml | 2 + .../qemuhotplug-hotplug-base+disk-usb.xml | 2 + .../qemuhotplug-hotplug-base+disk-virtio.xml | 2 + tests/qemuxml2argvdata/qemuxml2argv-bios-nvram.xml | 2 + .../qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml | 2 + .../qemuxml2argv-blkiotune-device.xml | 2 + tests/qemuxml2argvdata/qemuxml2argv-blkiotune.xml | 2 + tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml | 2 + .../qemuxml2argvdata/qemuxml2argv-boot-floppy.xml | 2 + .../qemuxml2argv-boot-menu-disable.xml | 2 + .../qemuxml2argv-boot-menu-enable-with-timeout.xml | 2 + tests/qemuxml2argvdata/qemuxml2argv-boot-multi.xml | 2 + .../qemuxml2argvdata/qemuxml2argv-boot-network.xml | 2 + tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml | 2 + .../qemuxml2argv-channel-guestfwd.xml | 2 + .../qemuxml2argv-channel-virtio.xml| 2 + .../qemuxml2argv-chardev-label.xml | 2 + .../qemuxml2argv-clock-catchup.xml | 2 + .../qemuxml2argv-clock-localtime.xml | 2 + .../qemuxml2argv-clock-timer-hyperv-rtc.xml| 2 + tests/qemuxml2argvdata/qemuxml2argv-clock-utc.xml | 2 + .../qemuxml2argv-console-compat.xml| 2 + .../qemuxml2argv-console-virtio-many.xml | 2 + .../qemuxml2argv-cpu-eoi-disabled.xml | 2 + .../qemuxml2argv-cpu-eoi-enabled.xml | 2 + .../qemuxml2argv-cpu-host-kvmclock.xml | 2 + .../qemuxml2argv-cpu-host-model-features.xml | 2 + .../qemuxml2argv-cpu-host-passthrough-features.xml | 2 + .../qemuxml2argvdata/qemuxml2argv-cpu-kvmclock.xml | 2 + .../qemuxml2argv-cpu-numa-disjoint.xml | 2 + .../qemuxml2argv-cpu-numa-memshared.xml| 2 + ...xml2argv-cputune-iothreadsched-zeropriority.xml | 2 + .../qemuxml2argv-cputune-numatune.xml | 2 + .../qemuxml2argv-cputune-zero-shares.xml | 2 + tests/qemuxml2argvdata/qemuxml2argv-cputune.xml| 2 + .../qemuxml2argv-disk-active-commit.xml| 2 + tests/qemuxml2argvdata/qemuxml2argv-disk-aio.xml | 2 + .../qemuxml2argv-disk-cdrom-empty.xml | 2 + tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom.xml | 2 + .../qemuxml2argv-disk-copy_on_read.xml | 2 + .../qemuxml2argv-disk-drive-boot-cdrom.xml | 3 + .../qemuxml2argv-disk-drive-boot-disk.xml | 3 + .../qemuxml2argv-disk-drive-cache-directsync.xml | 2 + .../qemuxml2argv-disk-drive-cache-unsafe.xml | 2 + .../qemuxml2argv-disk-drive-cache-v2-none.xml | 2 + .../qemuxml2argv-disk-drive-cache-v2-wb.xml| 2 + .../qemuxml2argv-disk-drive-cache-v2-wt.xml| 2 + .../qemuxml2argv-disk-drive-copy-on-read.xml | 2 + ...muxml2argv-disk-drive-error-policy-enospace.xml | 2 + .../qemuxml2argv-disk-drive-error-policy-stop.xml | 2 + ...rgv-disk-drive-error-policy-wreport-rignore.xml | 2 + .../qemuxml2argv-disk-drive-fat.xml| 2 + .../qemuxml2argv-disk-drive-fmt-qcow.xml | 2 + .../qemuxml2argv-disk-drive-network-gluster.xml| 2 + .../qemuxml2argv-disk-drive-network-iscsi-auth.xml | 2 + .../qemuxml2argv-disk-drive-network-iscsi.xml | 2 + .../qemuxml2argv-disk-drive-network-nbd-export.xml | 2 + ...xml2argv-disk-drive-network-nbd-ipv6-export.xml | 2 + .../qemuxml2argv-disk-drive-network-nbd-ipv6.xml | 2 + .../qemuxml2argv-disk-drive-network-nbd-unix.xml | 2 + .../qemuxml2argv-disk-drive-network-nbd.xml| 2 + .../qemuxml2argv-disk-drive-network-r
