Re: [libvirt] [PATCH v2 05/22] qemu: Don't mess with disk-mirrorState

2015-06-10 Thread Peter Krempa
On Tue, Jun 02, 2015 at 14:34:10 +0200, Jiri Denemark wrote:
 This patch reverts commit 76c61cdca20c106960af033e5d0f5da70177af0f.
 
 VIR_DOMAIN_DISK_MIRROR_STATE_ABORT says we asked for a block job to be
 aborted rather than saying it was aborted. Let's just use
 VIR_DOMAIN_DISK_MIRROR_STATE_NONE consistently whenever a block job
 finishes since no caller depends on VIR_DOMAIN_DISK_MIRROR_STATE_ABORT
 (anymore) to check whether a block job failed or it was cancelled.
 
 Signed-off-by: Jiri Denemark jdene...@redhat.com
 ---


ACK,

Peter


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 05/22] qemu: Don't mess with disk-mirrorState

2015-06-02 Thread Jiri Denemark
This patch reverts commit 76c61cdca20c106960af033e5d0f5da70177af0f.

VIR_DOMAIN_DISK_MIRROR_STATE_ABORT says we asked for a block job to be
aborted rather than saying it was aborted. Let's just use
VIR_DOMAIN_DISK_MIRROR_STATE_NONE consistently whenever a block job
finishes since no caller depends on VIR_DOMAIN_DISK_MIRROR_STATE_ABORT
(anymore) to check whether a block job failed or it was cancelled.

Signed-off-by: Jiri Denemark jdene...@redhat.com
---

Notes:
Version 2:
- no changes

 src/qemu/qemu_blockjob.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index cefb168..51370bf 100644
--- a/src/qemu/qemu_blockjob.c
+++ b/src/qemu/qemu_blockjob.c
@@ -164,8 +164,7 @@ qemuBlockJobEventProcess(virQEMUDriverPtr driver,
 case VIR_DOMAIN_BLOCK_JOB_CANCELED:
 virStorageSourceFree(disk-mirror);
 disk-mirror = NULL;
-disk-mirrorState = status == VIR_DOMAIN_BLOCK_JOB_FAILED ?
-VIR_DOMAIN_DISK_MIRROR_STATE_ABORT : 
VIR_DOMAIN_DISK_MIRROR_STATE_NONE;
+disk-mirrorState = VIR_DOMAIN_DISK_MIRROR_STATE_NONE;
 disk-mirrorJob = VIR_DOMAIN_BLOCK_JOB_TYPE_UNKNOWN;
 save = true;
 diskPriv-blockjob = false;
-- 
2.4.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list