Re: [libvirt] [PATCH v2 1/2] news: Allow xml validation for snapshot creation

2019-07-31 Thread Eric Blake 
On 7/30/19 10:57 PM, Han Han wrote:
> Signed-off-by: Han Han 
> ---
>  docs/news.xml | 10 ++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 1134309ec2..6d90ea8389 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -76,6 +76,16 @@
>
>  
>  
> +  
> +
> +  qemu: Allow to validate xml for snapshot creation

"allow to $verb" is not idiomatic English; it is either "allow $subject
to $verb" or "allow ${verb}ing".

In this case, I'd even prefer "Allow validation of xml"

ACK; I can fix that up and push (and thanks for catching that I added
this feature without news).

> +
> +
> +  Add flag VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE to 
> validate
> +  snapshot input xml. For virsh, users can use it as virsh
> +  snapshot-create --validate.
> +
> +  
>  
>  
>  
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 1/2] news: Allow xml validation for snapshot creation

2019-07-31 Thread Andrea Bolognani 
On Wed, 2019-07-31 at 11:57 +0800, Han Han wrote:
> +
> +  qemu: Allow to validate xml for snapshot creation
> +
> +
> +  Add flag VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE to 
> validate
> +  snapshot input xml. For virsh, users can use it as virsh
> +  snapshot-create --validate.
> +

s/xml/XML/g

Reviewed-by: Andrea Bolognani 

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 1/2] news: Allow xml validation for snapshot creation

2019-07-30 Thread Han Han 
Signed-off-by: Han Han 
---
 docs/news.xml | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 1134309ec2..6d90ea8389 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -76,6 +76,16 @@
   
 
 
+  
+
+  qemu: Allow to validate xml for snapshot creation
+
+
+  Add flag VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE to validate
+  snapshot input xml. For virsh, users can use it as virsh
+  snapshot-create --validate.
+
+  
 
 
 
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list