Re: [libvirt] [PATCH v2 2/3] tests: libxl: ACPI slic table test
On 9/16/19 6:47 AM, Marek Marczykowski-Górecki wrote:
> On Mon, Sep 16, 2019 at 12:23:35PM +, Jim Fehlig wrote:
>> On 9/15/19 1:43 PM, Marek Marczykowski-Górecki wrote:
>>> Signed-off-by: Marek Marczykowski-Górecki
>>> ---
>>>tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json | 54 +-
>>>tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml | 32 -
>>>tests/libxlxml2domconfigtest.c | 2 +-
>>>3 files changed, 88 insertions(+)
>>>create mode 100644 tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
>>>create mode 100644 tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
>>>
>>> diff --git a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
>>> b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
>>> new file mode 100644
>>> index 000..5d85d75
>>> --- /dev/null
>>> +++ b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
>>> @@ -0,0 +1,54 @@
>>> +{
>>> +"c_info": {
>>> +"type": "hvm",
>>> +"name": "XenGuest2",
>>> +"uuid": "c7a5fdb2-cdaf-9455-926a-d65c16db1809"
>>> +},
>>> +"b_info": {
>>> +"max_vcpus": 1,
>>> +"avail_vcpus": [
>>> +0
>>> +],
>>> +"max_memkb": 592896,
>>> +"target_memkb": 403456,
>>> +"shadow_memkb": 5656,
>>> +"sched_params": {
>>> +},
>>> +"nested_hvm": "False",
>>
>> I had to remove the above line otherwise 'make check' fails. Did it work for
>> you
>> as is?
>
> Yes, it works for me. But what's interesting, if I remove it, it works
> too. Other modifications do cause the test to fail, so the test was
> called. Maybe it's about Xen libs version? 4.8 here.
I think so. Starting with Xen 4.10 'nested_hvm' is not included in json config
if it is set to the default value (which is consistent with other settings).
I've removed it in my local branch and will push the series soon.
BTW, the mentioning of versions got me to thinking that we should bump the
minimum supported Xen version to 4.9. According to the support matrix for older
xen versions [0], 4.8 general support ended June 2018 and security support ends
in Dec 2019 (soon). 4.9 general support ends in Jan 2020 and security support
extends until July 2020. What is your opinion on bumping the minimum version to
4.9?
Regards,
Jim
[0] https://wiki.xenproject.org/wiki/Xen_Project_Release_Features
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 2/3] tests: libxl: ACPI slic table test
On Mon, Sep 16, 2019 at 12:23:35PM +, Jim Fehlig wrote:
> On 9/15/19 1:43 PM, Marek Marczykowski-Górecki wrote:
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> > tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json | 54 +-
> > tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml | 32 -
> > tests/libxlxml2domconfigtest.c | 2 +-
> > 3 files changed, 88 insertions(+)
> > create mode 100644 tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
> > create mode 100644 tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
> >
> > diff --git a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
> > b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
> > new file mode 100644
> > index 000..5d85d75
> > --- /dev/null
> > +++ b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
> > @@ -0,0 +1,54 @@
> > +{
> > +"c_info": {
> > +"type": "hvm",
> > +"name": "XenGuest2",
> > +"uuid": "c7a5fdb2-cdaf-9455-926a-d65c16db1809"
> > +},
> > +"b_info": {
> > +"max_vcpus": 1,
> > +"avail_vcpus": [
> > +0
> > +],
> > +"max_memkb": 592896,
> > +"target_memkb": 403456,
> > +"shadow_memkb": 5656,
> > +"sched_params": {
> > +},
> > +"nested_hvm": "False",
>
> I had to remove the above line otherwise 'make check' fails. Did it work for
> you
> as is?
Yes, it works for me. But what's interesting, if I remove it, it works
too. Other modifications do cause the test to fail, so the test was
called. Maybe it's about Xen libs version? 4.8 here.
> Regards,
> Jim
>
> > +"type.hvm": {
> > +"pae": "True",
> > +"apic": "True",
> > +"acpi": "True",
> > +"acpi_firmware": "/path/to/slic.dat",
> > +"nographic": "True",
> > +"vnc": {
> > +"enable": "False"
> > +},
> > +"sdl": {
> > +"enable": "False"
> > +},
> > +"spice": {
> > +
> > +},
> > +"boot": "c",
> > +"rdm": {
> > +
> > +}
> > +},
> > +"arch_arm": {
> > +
> > +}
> > +},
> > +"disks": [
> > +{
> > +"pdev_path": "/dev/HostVG/XenGuest2",
> > +"vdev": "hda",
> > +"backend": "phy",
> > +"format": "raw",
> > +"removable": 1,
> > +"readwrite": 1
> > +}
> > +],
> > +"on_reboot": "restart",
> > +"on_crash": "restart"
> > +}
> > diff --git a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
> > b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
> > new file mode 100644
> > index 000..017fdb5
> > --- /dev/null
> > +++ b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
> > @@ -0,0 +1,32 @@
> > +
> > + XenGuest2
> > + c7a5fdb2-cdaf-9455-926a-d65c16db1809
> > + 592896
> > + 403456
> > + 1
> > +
> > +hvm
> > +
> > + /path/to/slic.dat
> > +
> > +
> > +
> > +
> > +
> > +
> > +
> > +
> > + destroy
> > + restart
> > + restart
> > +
> > +
> > +
> > +
> > +
> > +
> > +
> > +
> > +
> > +
> > +
> > diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c
> > index 3b3f634..120796b 100644
> > --- a/tests/libxlxml2domconfigtest.c
> > +++ b/tests/libxlxml2domconfigtest.c
> > @@ -212,6 +212,8 @@ mymain(void)
> > DO_TEST("fullvirt-cpuid-legacy-nest");
> > # endif
> >
> > +DO_TEST("fullvirt-acpi-slic");
> > +
> > # ifdef LIBXL_HAVE_BUILDINFO_GRANT_LIMITS
> > DO_TEST("max-gntframes-hvm");
> > # endif
> >
>
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 2/3] tests: libxl: ACPI slic table test
On 9/15/19 1:43 PM, Marek Marczykowski-Górecki wrote:
> Signed-off-by: Marek Marczykowski-Górecki
> ---
> tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json | 54 +-
> tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml | 32 -
> tests/libxlxml2domconfigtest.c | 2 +-
> 3 files changed, 88 insertions(+)
> create mode 100644 tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
> create mode 100644 tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
>
> diff --git a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
> b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
> new file mode 100644
> index 000..5d85d75
> --- /dev/null
> +++ b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
> @@ -0,0 +1,54 @@
> +{
> +"c_info": {
> +"type": "hvm",
> +"name": "XenGuest2",
> +"uuid": "c7a5fdb2-cdaf-9455-926a-d65c16db1809"
> +},
> +"b_info": {
> +"max_vcpus": 1,
> +"avail_vcpus": [
> +0
> +],
> +"max_memkb": 592896,
> +"target_memkb": 403456,
> +"shadow_memkb": 5656,
> +"sched_params": {
> +},
> +"nested_hvm": "False",
I had to remove the above line otherwise 'make check' fails. Did it work for
you
as is?
Regards,
Jim
> +"type.hvm": {
> +"pae": "True",
> +"apic": "True",
> +"acpi": "True",
> +"acpi_firmware": "/path/to/slic.dat",
> +"nographic": "True",
> +"vnc": {
> +"enable": "False"
> +},
> +"sdl": {
> +"enable": "False"
> +},
> +"spice": {
> +
> +},
> +"boot": "c",
> +"rdm": {
> +
> +}
> +},
> +"arch_arm": {
> +
> +}
> +},
> +"disks": [
> +{
> +"pdev_path": "/dev/HostVG/XenGuest2",
> +"vdev": "hda",
> +"backend": "phy",
> +"format": "raw",
> +"removable": 1,
> +"readwrite": 1
> +}
> +],
> +"on_reboot": "restart",
> +"on_crash": "restart"
> +}
> diff --git a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
> b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
> new file mode 100644
> index 000..017fdb5
> --- /dev/null
> +++ b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
> @@ -0,0 +1,32 @@
> +
> + XenGuest2
> + c7a5fdb2-cdaf-9455-926a-d65c16db1809
> + 592896
> + 403456
> + 1
> +
> +hvm
> +
> + /path/to/slic.dat
> +
> +
> +
> +
> +
> +
> +
> +
> + destroy
> + restart
> + restart
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c
> index 3b3f634..120796b 100644
> --- a/tests/libxlxml2domconfigtest.c
> +++ b/tests/libxlxml2domconfigtest.c
> @@ -212,6 +212,8 @@ mymain(void)
> DO_TEST("fullvirt-cpuid-legacy-nest");
> # endif
>
> +DO_TEST("fullvirt-acpi-slic");
> +
> # ifdef LIBXL_HAVE_BUILDINFO_GRANT_LIMITS
> DO_TEST("max-gntframes-hvm");
> # endif
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH v2 2/3] tests: libxl: ACPI slic table test
Signed-off-by: Marek Marczykowski-Górecki
---
tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json | 54 +-
tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml | 32 -
tests/libxlxml2domconfigtest.c | 2 +-
3 files changed, 88 insertions(+)
create mode 100644 tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
create mode 100644 tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
diff --git a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
new file mode 100644
index 000..5d85d75
--- /dev/null
+++ b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
@@ -0,0 +1,54 @@
+{
+"c_info": {
+"type": "hvm",
+"name": "XenGuest2",
+"uuid": "c7a5fdb2-cdaf-9455-926a-d65c16db1809"
+},
+"b_info": {
+"max_vcpus": 1,
+"avail_vcpus": [
+0
+],
+"max_memkb": 592896,
+"target_memkb": 403456,
+"shadow_memkb": 5656,
+"sched_params": {
+},
+"nested_hvm": "False",
+"type.hvm": {
+"pae": "True",
+"apic": "True",
+"acpi": "True",
+"acpi_firmware": "/path/to/slic.dat",
+"nographic": "True",
+"vnc": {
+"enable": "False"
+},
+"sdl": {
+"enable": "False"
+},
+"spice": {
+
+},
+"boot": "c",
+"rdm": {
+
+}
+},
+"arch_arm": {
+
+}
+},
+"disks": [
+{
+"pdev_path": "/dev/HostVG/XenGuest2",
+"vdev": "hda",
+"backend": "phy",
+"format": "raw",
+"removable": 1,
+"readwrite": 1
+}
+],
+"on_reboot": "restart",
+"on_crash": "restart"
+}
diff --git a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
new file mode 100644
index 000..017fdb5
--- /dev/null
+++ b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
@@ -0,0 +1,32 @@
+
+ XenGuest2
+ c7a5fdb2-cdaf-9455-926a-d65c16db1809
+ 592896
+ 403456
+ 1
+
+hvm
+
+ /path/to/slic.dat
+
+
+
+
+
+
+
+
+ destroy
+ restart
+ restart
+
+
+
+
+
+
+
+
+
+
+
diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c
index 3b3f634..120796b 100644
--- a/tests/libxlxml2domconfigtest.c
+++ b/tests/libxlxml2domconfigtest.c
@@ -212,6 +212,8 @@ mymain(void)
DO_TEST("fullvirt-cpuid-legacy-nest");
# endif
+DO_TEST("fullvirt-acpi-slic");
+
# ifdef LIBXL_HAVE_BUILDINFO_GRANT_LIMITS
DO_TEST("max-gntframes-hvm");
# endif
--
git-series 0.9.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
