Re: [libvirt] [PATCH v2 8/8] xml: report the filename (if any) when parsing files

[Jiri Denemark]

On Thu, Aug 16, 2018 at 13:10:31 +0100, Daniel P. Berrangé wrote:
> A generic "failed to parse xml document" message without telling us
> which XML file failed is quite unhelpful.
> 
> Signed-off-by: Daniel P. Berrangé 
> ---
>  src/util/virxml.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Jiri Denemark 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 8/8] xml: report the filename (if any) when parsing files

[Daniel P . Berrangé]

A generic "failed to parse xml document" message without telling us
which XML file failed is quite unhelpful.

Signed-off-by: Daniel P. Berrangé 
---
 src/util/virxml.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/util/virxml.c b/src/util/virxml.c
index a03a747e60..d1926f4605 100644
--- a/src/util/virxml.c
+++ b/src/util/virxml.c
@@ -847,7 +847,8 @@ virXMLParseHelper(int domcode,
 
 if (virGetLastErrorCode() == VIR_ERR_OK) {
 virGenericReportError(domcode, VIR_ERR_XML_ERROR,
-  "%s", _("failed to parse xml document"));
+  _("failed to parse xml document '%s'"),
+  filename ? filename : "[inline data]");
 }
 goto cleanup;
 }
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list