Re: [libvirt] [PATCH v3 0/5] qemu: add PCI bridge support

2013-04-25 Thread Ján Tomko
On 04/22/2013 08:43 PM, Ján Tomko wrote:
 Add new 'pci' controller type with two models:
 pci-root - auto-added to machines with implicit pci bus
 pci-bridge - auto-added if the devices would not leave
 at least one slot empty on bus 0 or bus 0 is specified
 
 v3:
 moved the implicit PCI root addition to qemu's post parse
 callback,
 added an xml - xml test and schema validation
 rewrote implicit controller removal and search for free slots
 check for multiple pci controllers with the same index
 added documentation
 
 Ján Tomko (4):
   qemu: call post-parse callbacks when parsing command line too
   conf: add PCI controllers
   qemu: auto-add pci-root controller for pc machine types
   qemu: auto-add bridges and allow using them
 
 liguang (1):
   qemu: build command line for pci-bridge device
 

I've pushed patches 1-5 and sent another version
of patch 6 - conf: reject controllers with duplicate indexes separately.

Thank you for your reviews.

Jan

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v3 0/5] qemu: add PCI bridge support

2013-04-22 Thread Ján Tomko
Add new 'pci' controller type with two models:
pci-root - auto-added to machines with implicit pci bus
pci-bridge - auto-added if the devices would not leave
at least one slot empty on bus 0 or bus 0 is specified

v3:
moved the implicit PCI root addition to qemu's post parse
callback,
added an xml - xml test and schema validation
rewrote implicit controller removal and search for free slots
check for multiple pci controllers with the same index
added documentation

Ján Tomko (4):
  qemu: call post-parse callbacks when parsing command line too
  conf: add PCI controllers
  qemu: auto-add pci-root controller for pc machine types
  qemu: auto-add bridges and allow using them

liguang (1):
  qemu: build command line for pci-bridge device

 docs/formatdomain.html.in  |  22 +-
 docs/schemas/domaincommon.rng  |  12 +
 src/conf/domain_conf.c |  51 +++-
 src/conf/domain_conf.h |  20 ++
 src/libvirt_private.syms   |   2 +
 src/qemu/qemu_capabilities.c   |   3 +
 src/qemu/qemu_capabilities.h   |   1 +
 src/qemu/qemu_command.c| 296 +
 src/qemu/qemu_command.h|   5 +-
 src/qemu/qemu_domain.c |  67 -
 tests/domainsnapshotxml2xmlout/disk_snapshot.xml   |   1 +
 tests/domainsnapshotxml2xmlout/external_vm.xml |   1 +
 tests/domainsnapshotxml2xmlout/full_domain.xml |   1 +
 tests/domainsnapshotxml2xmlout/metadata.xml|   1 +
 tests/qemuhelptest.c   |  21 +-
 .../qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml |   1 +
 .../qemuxml2argv-blkiotune-device.xml  |   1 +
 tests/qemuxml2argvdata/qemuxml2argv-blkiotune.xml  |   1 +
 tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml |   2 +
 .../qemuxml2argvdata/qemuxml2argv-boot-floppy.xml  |   3 +
 .../qemuxml2argv-boot-menu-disable.xml |   1 +
 tests/qemuxml2argvdata/qemuxml2argv-boot-multi.xml |   1 +
 .../qemuxml2argvdata/qemuxml2argv-boot-network.xml |   2 +
 tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml |   1 +
 .../qemuxml2argv-channel-guestfwd.xml  |   1 +
 .../qemuxml2argv-channel-virtio.xml|   1 +
 .../qemuxml2argv-clock-localtime.xml   |   2 +
 tests/qemuxml2argvdata/qemuxml2argv-clock-utc.xml  |   2 +
 .../qemuxml2argv-console-compat.xml|   2 +
 .../qemuxml2argv-console-virtio-many.xml   |   1 +
 .../qemuxml2argv-cpu-eoi-disabled.xml  |   1 +
 .../qemuxml2argv-cpu-eoi-enabled.xml   |   1 +
 .../qemuxml2argv-cpu-host-kvmclock.xml |   1 +
 .../qemuxml2argvdata/qemuxml2argv-cpu-kvmclock.xml |   1 +
 tests/qemuxml2argvdata/qemuxml2argv-cputune.xml|   1 +
 tests/qemuxml2argvdata/qemuxml2argv-disk-aio.xml   |   1 +
 .../qemuxml2argv-disk-cdrom-empty.xml  |   3 +
 tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom.xml |   3 +
 .../qemuxml2argv-disk-drive-boot-cdrom.xml |   3 +
 .../qemuxml2argv-disk-drive-boot-disk.xml  |   3 +
 .../qemuxml2argv-disk-drive-cache-directsync.xml   |   1 +
 .../qemuxml2argv-disk-drive-cache-unsafe.xml   |   1 +
 .../qemuxml2argv-disk-drive-cache-v1-none.xml  |   1 +
 .../qemuxml2argv-disk-drive-cache-v1-wb.xml|   1 +
 .../qemuxml2argv-disk-drive-cache-v1-wt.xml|   1 +
 .../qemuxml2argv-disk-drive-cache-v2-none.xml  |   1 +
 .../qemuxml2argv-disk-drive-cache-v2-wb.xml|   1 +
 .../qemuxml2argv-disk-drive-cache-v2-wt.xml|   1 +
 ...muxml2argv-disk-drive-error-policy-enospace.xml |   1 +
 .../qemuxml2argv-disk-drive-error-policy-stop.xml  |   1 +
 ...rgv-disk-drive-error-policy-wreport-rignore.xml |   1 +
 .../qemuxml2argv-disk-drive-fat.xml|   1 +
 .../qemuxml2argv-disk-drive-fmt-qcow.xml   |   1 +
 .../qemuxml2argv-disk-drive-network-gluster.xml|   1 +
 .../qemuxml2argv-disk-drive-network-iscsi-auth.xml |   1 +
 .../qemuxml2argv-disk-drive-network-iscsi.xml  |   1 +
 .../qemuxml2argv-disk-drive-network-nbd-export.xml |   1 +
 ...xml2argv-disk-drive-network-nbd-ipv6-export.xml |   1 +
 .../qemuxml2argv-disk-drive-network-nbd-ipv6.xml   |   1 +
 .../qemuxml2argv-disk-drive-network-nbd-unix.xml   |   1 +
 .../qemuxml2argv-disk-drive-network-nbd.xml|   1 +
 ...emuxml2argv-disk-drive-network-rbd-ceph-env.xml |   2 +
 .../qemuxml2argv-disk-drive-network-rbd-ipv6.xml   |   1 +
 .../qemuxml2argv-disk-drive-network-rbd.xml|   1 +
 .../qemuxml2argv-disk-drive-network-sheepdog.xml   |   1 +
 .../qemuxml2argvdata/qemuxml2argv-disk-floppy.xml  |   4 +
 tests/qemuxml2argvdata/qemuxml2argv-disk-many.xml  |   5 +
 .../qemuxml2argvdata/qemuxml2argv-disk-mirror.xml  |   1 +
 .../qemuxml2argv-disk-scsi-device.xml  |   1 +
 .../qemuxml2argv-disk-scsi-disk-vpd.xml|   1 +