Re: [libvirt] [PATCH v3 3/7] Add new migration flag VIR_MIGRATE_TLS

[Jiri Denemark]

On Fri, Mar 17, 2017 at 14:38:57 -0400, John Ferlan wrote:
> Signed-off-by: John Ferlan 
> ---
>  include/libvirt/libvirt-domain.h | 8 
>  src/qemu/qemu_migration.h| 3 ++-
>  tools/virsh-domain.c | 7 +++
>  3 files changed, 17 insertions(+), 1 deletion(-)

ACK

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v3 3/7] Add new migration flag VIR_MIGRATE_TLS

[John Ferlan]

Signed-off-by: John Ferlan 
---
 include/libvirt/libvirt-domain.h | 8 
 src/qemu/qemu_migration.h| 3 ++-
 tools/virsh-domain.c | 7 +++
 3 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index c490d71..620606c 100644
--- a/include/libvirt/libvirt-domain.h
+++ b/include/libvirt/libvirt-domain.h
@@ -815,6 +815,14 @@ typedef enum {
  * post-copy mode. See virDomainMigrateStartPostCopy for more details.
  */
 VIR_MIGRATE_POSTCOPY  = (1 << 15),
+
+/* Setting the VIR_MIGRATE_TLS flag will cause the migration to attempt
+ * to use the TLS environment configured by the hypervisor in order to
+ * perform the migration. If incorrectly configured on either source or
+ * destination, the migration will fail.
+ */
+VIR_MIGRATE_TLS   = (1 << 16),
+
 } virDomainMigrateFlags;
 
 
diff --git a/src/qemu/qemu_migration.h b/src/qemu/qemu_migration.h
index 14c6178..bcebf06 100644
--- a/src/qemu/qemu_migration.h
+++ b/src/qemu/qemu_migration.h
@@ -45,7 +45,8 @@ typedef qemuMigrationCompression *qemuMigrationCompressionPtr;
  VIR_MIGRATE_ABORT_ON_ERROR |   \
  VIR_MIGRATE_AUTO_CONVERGE |\
  VIR_MIGRATE_RDMA_PIN_ALL | \
- VIR_MIGRATE_POSTCOPY)
+ VIR_MIGRATE_POSTCOPY | \
+ VIR_MIGRATE_TLS)
 
 /* All supported migration parameters and their types. */
 # define QEMU_MIGRATION_PARAMETERS\
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 09a9f82..ebd4b33 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -10222,6 +10222,10 @@ static const vshCmdOptDef opts_migrate[] = {
  .type = VSH_OT_STRING,
  .help = N_("filename containing updated persistent XML for the target")
 },
+{.name = "tls",
+ .type = VSH_OT_BOOL,
+ .help = N_("use TLS for migration")
+},
 {.name = NULL}
 };
 
@@ -10463,6 +10467,9 @@ doMigrate(void *opaque)
 if (vshCommandOptBool(cmd, "postcopy"))
 flags |= VIR_MIGRATE_POSTCOPY;
 
+if (vshCommandOptBool(cmd, "tls"))
+flags |= VIR_MIGRATE_TLS;
+
 if (flags & VIR_MIGRATE_PEER2PEER || vshCommandOptBool(cmd, "direct")) {
 if (virDomainMigrateToURI3(dom, desturi, params, nparams, flags) == 0)
 ret = '0';
-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list