Re: [libvirt] [PATCH v4 0/3] add nodeset check in numatune
On Mon, 2014-11-03 at 14:18 +0100, Martin Kletzander wrote: > On Thu, Oct 30, 2014 at 01:44:16PM +0800, Chen Fan wrote: > >when setting elements memnode and nodeset in attribute numatune more > >than the host nodes in XML file, VM boot should fail. so add check for > >that. > > > > You should run "make syntax-check" and "make check" on those patches, > it would find at least two things ;) > > Anyway, ACK series with the changes I mentioned. If you're OK with > them, I'll push the series. I will send a new series after change them. and Thanks for your review. Chen > > Martin -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v4 0/3] add nodeset check in numatune
On Thu, Oct 30, 2014 at 01:44:16PM +0800, Chen Fan wrote: when setting elements memnode and nodeset in attribute numatune more than the host nodes in XML file, VM boot should fail. so add check for that. You should run "make syntax-check" and "make check" on those patches, it would find at least two things ;) Anyway, ACK series with the changes I mentioned. If you're OK with them, I'll push the series. Martin signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH v4 0/3] add nodeset check in numatune
when setting elements memnode and nodeset in attribute numatune more than the host nodes in XML file, VM boot should fail. so add check for that. Chen Fan (3): bitmap: add virBitmapLastSetBit for finding the last bit position of bitmap numatune: add check for numatune nodeset range virnuma: use virNumaNodesetIsAvailable checking nodeset in virNumaSetupMemoryPolicy src/conf/numatune_conf.c | 28 ++ src/conf/numatune_conf.h | 1 + src/libvirt_private.syms | 2 + src/qemu/qemu_command.c| 4 ++ src/util/virbitmap.c | 45 src/util/virbitmap.h | 3 ++ src/util/virnuma.c | 61 +++--- src/util/virnuma.h | 1 + ...rgv-numatune-static-nodeset-exceed-hostnode.xml | 36 + tests/qemuxml2argvmock.c | 9 tests/qemuxml2argvtest.c | 1 + tests/virbitmaptest.c | 13 - 12 files changed, 184 insertions(+), 20 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-numatune-static-nodeset-exceed-hostnode.xml -- 1.9.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
