Re: [libvirt] [PATCH v4 03/10] qemu: caps: Introduce a capability for egl-headless

2018-07-18 Thread Erik Skultety 
On Wed, Jul 18, 2018 at 03:08:39PM +0200, Pavel Hrdina wrote:
> On Wed, Jul 18, 2018 at 02:57:30PM +0200, Erik Skultety wrote:
> > On Wed, Jul 18, 2018 at 02:31:39PM +0200, Erik Skultety wrote:
> > > Since QEMU 2.10, it's possible to use a new type of display -
> > > egl-headless which uses drm nodes to provide OpenGL support. This patch
> > > adds a capability for that. However, since QEMU doesn't provide a QMP
> > > command to probe it, we have to base the capability on specific QEMU
> > > version.
> > >
> > > Signed-off-by: Erik Skultety 
> > > Acked-by: Michal Privoznik 
> > > Reviewed-by: Ján Tomko 
> > > Signed-off-by: Erik Skultety 
> >
> > Sigh, consider this extra SoB removed, that's probably just some interactive
> > rebase bit I forgot about.
>
> This happens if you use "-s" parameter, however, if you put your SoB
> always on the last line of the commit message "-s" will not add second
> one.

Yeah, I should start adding the RBs above the SoB to prevent that, I'm not
going to drop my auto-sign in the config, because I would just keep forgetting
to sign it.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v4 03/10] qemu: caps: Introduce a capability for egl-headless

2018-07-18 Thread Pavel Hrdina 
On Wed, Jul 18, 2018 at 02:57:30PM +0200, Erik Skultety wrote:
> On Wed, Jul 18, 2018 at 02:31:39PM +0200, Erik Skultety wrote:
> > Since QEMU 2.10, it's possible to use a new type of display -
> > egl-headless which uses drm nodes to provide OpenGL support. This patch
> > adds a capability for that. However, since QEMU doesn't provide a QMP
> > command to probe it, we have to base the capability on specific QEMU
> > version.
> >
> > Signed-off-by: Erik Skultety 
> > Acked-by: Michal Privoznik 
> > Reviewed-by: Ján Tomko 
> > Signed-off-by: Erik Skultety 
> 
> Sigh, consider this extra SoB removed, that's probably just some interactive
> rebase bit I forgot about.

This happens if you use "-s" parameter, however, if you put your SoB
always on the last line of the commit message "-s" will not add second
one.

Pavel

> 
> Erik
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v4 03/10] qemu: caps: Introduce a capability for egl-headless

2018-07-18 Thread Erik Skultety 
On Wed, Jul 18, 2018 at 02:31:39PM +0200, Erik Skultety wrote:
> Since QEMU 2.10, it's possible to use a new type of display -
> egl-headless which uses drm nodes to provide OpenGL support. This patch
> adds a capability for that. However, since QEMU doesn't provide a QMP
> command to probe it, we have to base the capability on specific QEMU
> version.
>
> Signed-off-by: Erik Skultety 
> Acked-by: Michal Privoznik 
> Reviewed-by: Ján Tomko 
> Signed-off-by: Erik Skultety 

Sigh, consider this extra SoB removed, that's probably just some interactive
rebase bit I forgot about.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v4 03/10] qemu: caps: Introduce a capability for egl-headless

2018-07-18 Thread Erik Skultety 
Since QEMU 2.10, it's possible to use a new type of display -
egl-headless which uses drm nodes to provide OpenGL support. This patch
adds a capability for that. However, since QEMU doesn't provide a QMP
command to probe it, we have to base the capability on specific QEMU
version.

Signed-off-by: Erik Skultety 
Acked-by: Michal Privoznik 
Reviewed-by: Ján Tomko 
Signed-off-by: Erik Skultety 
---
 src/qemu/qemu_capabilities.c   | 6 ++
 src/qemu/qemu_capabilities.h   | 1 +
 tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1 +
 tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml   | 1 +
 tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml   | 1 +
 tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml   | 1 +
 tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 +
 tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml   | 1 +
 tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml   | 1 +
 tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml| 1 +
 tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml   | 1 +
 14 files changed, 19 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 23b483349f..df358f8967 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -503,6 +503,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
   "machine.pseries.cap-hpt-max-page-size",
   "machine.pseries.cap-htm",
   "usb-storage.werror",
+  "egl-headless",
 );
 
 
@@ -4030,6 +4031,11 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps,
 virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_PSERIES_RESIZE_HPT);
 }
 
+/* '-display egl-headless' cmdline option is supported since QEMU 2.10, but
+ * there's no way to probe it */
+if (qemuCaps->version >= 201)
+virQEMUCapsSet(qemuCaps, QEMU_CAPS_EGL_HEADLESS);
+
 /* no way to query for -numa dist */
 if (qemuCaps->version >= 201)
 virQEMUCapsSet(qemuCaps, QEMU_CAPS_NUMA_DIST);
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index 1fa0ebfea3..55221e7e57 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -487,6 +487,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for 
syntax-check */
 QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZE, /* -machine 
pseries.cap-hpt-max-page-size */
 QEMU_CAPS_MACHINE_PSERIES_CAP_HTM, /* -machine pseries.cap-htm */
 QEMU_CAPS_USB_STORAGE_WERROR, /* -device usb-storage,werror=..,rerror=.. */
+QEMU_CAPS_EGL_HEADLESS, /* -display egl-headless */
 
 QEMU_CAPS_LAST /* this must always be the last item */
 } virQEMUCapsFlags;
diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml 
b/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml
index 169641063c..a70e050765 100644
--- a/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml
@@ -159,6 +159,7 @@
   
   
   
+  
   201
   0
   307647
diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml 
b/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml
index 92c095abd2..72709905d8 100644
--- a/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml
@@ -158,6 +158,7 @@
   
   
   
+  
   201
   0
   386992
diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml 
b/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml
index 5e22e21224..7347f5683f 100644
--- a/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml
+++ b/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml
@@ -119,6 +119,7 @@
   
   
   
+  
   201
   0
   307899
diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml 
b/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml
index 10b066bff1..d69a148cd2 100644
--- a/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml
@@ -203,6 +203,7 @@
   
   
   
+  
   201
   0
   367995
diff --git a/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml 
b/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml
index 6ca2e57ef8..b359f9a049 100644
--- a/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml
+++ b/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml
@@ -126,6 +126,7 @@
   
   
   
+  
   2011000
   0
   346751
diff --git a/tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml 
b/tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml
index c52e44a498..210f774c4e 100644
--- a/tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml
@@ -207,6 +207,7 @@
   
   
   
+  
   2011000
   0
   371455
diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml 
b/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml
index ecc029f403..80e7afec04 100644
---