Re: [libvirt] [PATCH v6 4/4] xlconfigtest: add tests for numa cell sibling distances

2017-11-12 Thread Jim Fehlig 

On 11/11/2017 06:42 AM, Wim ten Have wrote:

On Fri, 10 Nov 2017 13:59:25 -0700
Jim Fehlig  wrote:


On 11/10/2017 01:55 PM, Jim Fehlig wrote:

On 11/02/2017 09:47 AM, Wim Ten Have wrote:

From: Wim ten Have 

Test a bidirectional xen-xl domxml to and from native for vnuma
support administration as brought under this patch series.

Added tests for the libxl_domain_config generator determining
vnuma conversion for XML-2-json and json-2-XML.


I think these should be split into two patches. Essentially patch 4 in V5 plus a
patch 5 with the new ibxl_domain_config generator test.
   


Signed-off-by: Wim ten Have 
---
Changes on v5:
- Added tests for libxl_domain_config generator.
- Introduced empty stubs for xc_physinfo(), xc_sharing_freed_pages(),
    xc_sharing_used_frames to satisfy libxl_get_physinfo() under test
    simulation for libxlxml2domconfigtest.c
---
   tests/libxlxml2domconfigdata/basic-hvm.json    | 95 
+-
   tests/libxlxml2domconfigdata/basic-hvm.xml | 66 ++-


And instead of adding vNUMA config to the _basic_ test files,
vnuma-hvm.{json,xml} seems more appropriate. I've split this out into a patch 5
and attached here for completeness.

IMO this series is ready to go in. I'll wait for your ACK on the doc changes I
suggested in patch 1.


Sorry, I meant to say I'll wait for your feedback on my suggested doc changes in
patch 1 before pushing this series.




   Hi Jim, I am good with your suggested changes.  So this message is to;  ACK


Thanks, I've pushed this series now. And thanks for your perseverance! I know 
it's taken a while to get this work committed, mostly due to my delays.


BTW, I've sent a patch to mention your new features in 3.10.0 news

https://www.redhat.com/archives/libvir-list/2017-November/msg00414.html

Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v6 4/4] xlconfigtest: add tests for numa cell sibling distances

2017-11-11 Thread Wim ten Have 
On Fri, 10 Nov 2017 13:59:25 -0700
Jim Fehlig  wrote:

> On 11/10/2017 01:55 PM, Jim Fehlig wrote:
> > On 11/02/2017 09:47 AM, Wim Ten Have wrote:  
> >> From: Wim ten Have 
> >>
> >> Test a bidirectional xen-xl domxml to and from native for vnuma
> >> support administration as brought under this patch series.
> >>
> >> Added tests for the libxl_domain_config generator determining
> >> vnuma conversion for XML-2-json and json-2-XML.  
> > 
> > I think these should be split into two patches. Essentially patch 4 in V5 
> > plus a 
> > patch 5 with the new ibxl_domain_config generator test.
> >   
> >>
> >> Signed-off-by: Wim ten Have 
> >> ---
> >> Changes on v5:
> >> - Added tests for libxl_domain_config generator.
> >> - Introduced empty stubs for xc_physinfo(), xc_sharing_freed_pages(),
> >>    xc_sharing_used_frames to satisfy libxl_get_physinfo() under test
> >>    simulation for libxlxml2domconfigtest.c
> >> ---
> >>   tests/libxlxml2domconfigdata/basic-hvm.json    | 95 
> >> +-
> >>   tests/libxlxml2domconfigdata/basic-hvm.xml | 66 ++-  
> > 
> > And instead of adding vNUMA config to the _basic_ test files, 
> > vnuma-hvm.{json,xml} seems more appropriate. I've split this out into a 
> > patch 5 
> > and attached here for completeness.
> > 
> > IMO this series is ready to go in. I'll wait for your ACK on the doc 
> > changes I 
> > suggested in patch 1.  
> 
> Sorry, I meant to say I'll wait for your feedback on my suggested doc changes 
> in 
> patch 1 before pushing this series.



  Hi Jim, I am good with your suggested changes.  So this message is to;  ACK

Best regards,
- Wim.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v6 4/4] xlconfigtest: add tests for numa cell sibling distances

2017-11-10 Thread Jim Fehlig 

On 11/10/2017 01:55 PM, Jim Fehlig wrote:

On 11/02/2017 09:47 AM, Wim Ten Have wrote:

From: Wim ten Have 

Test a bidirectional xen-xl domxml to and from native for vnuma
support administration as brought under this patch series.

Added tests for the libxl_domain_config generator determining
vnuma conversion for XML-2-json and json-2-XML.


I think these should be split into two patches. Essentially patch 4 in V5 plus a 
patch 5 with the new ibxl_domain_config generator test.




Signed-off-by: Wim ten Have 
---
Changes on v5:
- Added tests for libxl_domain_config generator.
- Introduced empty stubs for xc_physinfo(), xc_sharing_freed_pages(),
   xc_sharing_used_frames to satisfy libxl_get_physinfo() under test
   simulation for libxlxml2domconfigtest.c
---
  tests/libxlxml2domconfigdata/basic-hvm.json    | 95 +-
  tests/libxlxml2domconfigdata/basic-hvm.xml | 66 ++-


And instead of adding vNUMA config to the _basic_ test files, 
vnuma-hvm.{json,xml} seems more appropriate. I've split this out into a patch 5 
and attached here for completeness.


IMO this series is ready to go in. I'll wait for your ACK on the doc changes I 
suggested in patch 1.


Sorry, I meant to say I'll wait for your feedback on my suggested doc changes in 
patch 1 before pushing this series.


Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v6 4/4] xlconfigtest: add tests for numa cell sibling distances

2017-11-10 Thread Jim Fehlig 

On 11/02/2017 09:47 AM, Wim Ten Have wrote:

From: Wim ten Have 

Test a bidirectional xen-xl domxml to and from native for vnuma
support administration as brought under this patch series.

Added tests for the libxl_domain_config generator determining
vnuma conversion for XML-2-json and json-2-XML.


I think these should be split into two patches. Essentially patch 4 in V5 plus a 
patch 5 with the new ibxl_domain_config generator test.




Signed-off-by: Wim ten Have 
---
Changes on v5:
- Added tests for libxl_domain_config generator.
- Introduced empty stubs for xc_physinfo(), xc_sharing_freed_pages(),
   xc_sharing_used_frames to satisfy libxl_get_physinfo() under test
   simulation for libxlxml2domconfigtest.c
---
  tests/libxlxml2domconfigdata/basic-hvm.json| 95 +-
  tests/libxlxml2domconfigdata/basic-hvm.xml | 66 ++-


And instead of adding vNUMA config to the _basic_ test files, 
vnuma-hvm.{json,xml} seems more appropriate. I've split this out into a patch 5 
and attached here for completeness.


IMO this series is ready to go in. I'll wait for your ACK on the doc changes I 
suggested in patch 1.


Regards,
Jim
>From dd4239cedaa125b6a9a50428d82a0b78eed9d38a Mon Sep 17 00:00:00 2001
From: Jim Fehlig 
Date: Fri, 10 Nov 2017 13:03:16 -0700
Subject: [PATCH 5/5] libxlxml2domconfigtest: add test for vNUMA config

From: Wim ten Have 

Add tests to ensure the libxl_domain_config generator properly
handles vNUMA configuration.

Signed-off-by: Wim ten Have 
Reviewed-by: Jim Fehlig 
Signed-off-by: Jim Fehlig 
---
 tests/libxlxml2domconfigdata/vnuma-hvm.json | 178 
 tests/libxlxml2domconfigdata/vnuma-hvm.xml  | 100 
 tests/libxlxml2domconfigtest.c  |   1 +
 tests/virmocklibxl.c|  13 ++
 4 files changed, 292 insertions(+)

diff --git a/tests/libxlxml2domconfigdata/vnuma-hvm.json b/tests/libxlxml2domconfigdata/vnuma-hvm.json
new file mode 100644
index 0..3a5071e14
--- /dev/null
+++ b/tests/libxlxml2domconfigdata/vnuma-hvm.json
@@ -0,0 +1,178 @@
+{
+"c_info": {
+"type": "hvm",
+"name": "test-hvm",
+"uuid": "2147d599-9cc6-c0dc-92ab-4064b5446e9b"
+},
+"b_info": {
+"max_vcpus": 6,
+"avail_vcpus": [
+0,
+1,
+2,
+3,
+4,
+5
+],
+"vnuma_nodes": [
+{
+"memkb": 2097152,
+"distances": [
+10,
+21,
+31,
+41,
+51,
+61
+],
+"vcpus": [
+0
+]
+},
+{
+"memkb": 2097152,
+"distances": [
+21,
+10,
+21,
+31,
+41,
+51
+],
+"vcpus": [
+1
+]
+},
+{
+"memkb": 2097152,
+"distances": [
+31,
+21,
+10,
+21,
+31,
+41
+],
+"vcpus": [
+2
+]
+},
+{
+"memkb": 2097152,
+"distances": [
+41,
+31,
+21,
+10,
+21,
+31
+],
+"vcpus": [
+3
+]
+},
+{
+"memkb": 2097152,
+"distances": [
+51,
+41,
+31,
+21,
+10,
+21
+],
+"vcpus": [
+4
+]
+},
+{
+"memkb": 2097152,
+"distances": [
+61,
+51,
+41,
+31,
+21,
+10
+],
+"vcpus": [
+5
+]
+}
+],
+"max_memkb": 1048576,
+"target_memkb": 1048576,
+"video_memkb": 8192,
+"shadow_memkb": 14336,
+"device_model_version": "qemu_xen",
+"device_model": "/bin/true",
+"sched_params": {
+"weight": 1000
+},
+"type.hvm": {
+"pae": "True",
+"apic": "True",
+"acpi": "True",
+"nested_hvm": "True",
+"vga": {
+"kind": "cirrus"
+},
+"vnc": {
+

[libvirt] [PATCH v6 4/4] xlconfigtest: add tests for numa cell sibling distances

2017-11-02 Thread Wim Ten Have 
From: Wim ten Have 

Test a bidirectional xen-xl domxml to and from native for vnuma
support administration as brought under this patch series.

Added tests for the libxl_domain_config generator determining
vnuma conversion for XML-2-json and json-2-XML.

Signed-off-by: Wim ten Have 
---
Changes on v5:
- Added tests for libxl_domain_config generator.
- Introduced empty stubs for xc_physinfo(), xc_sharing_freed_pages(),
  xc_sharing_used_frames to satisfy libxl_get_physinfo() under test
  simulation for libxlxml2domconfigtest.c
---
 tests/libxlxml2domconfigdata/basic-hvm.json| 95 +-
 tests/libxlxml2domconfigdata/basic-hvm.xml | 66 ++-
 tests/virmocklibxl.c   | 13 +++
 .../test-fullvirt-vnuma-autocomplete.cfg   | 26 ++
 .../test-fullvirt-vnuma-autocomplete.xml   | 85 +++
 .../test-fullvirt-vnuma-nodistances.cfg| 26 ++
 .../test-fullvirt-vnuma-nodistances.xml| 53 
 .../test-fullvirt-vnuma-partialdist.cfg| 26 ++
 .../test-fullvirt-vnuma-partialdist.xml| 60 ++
 tests/xlconfigdata/test-fullvirt-vnuma.cfg | 26 ++
 tests/xlconfigdata/test-fullvirt-vnuma.xml | 81 ++
 tests/xlconfigtest.c   |  6 ++
 12 files changed, 559 insertions(+), 4 deletions(-)
 create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma-autocomplete.cfg
 create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma-autocomplete.xml
 create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma-nodistances.cfg
 create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml
 create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma-partialdist.cfg
 create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma-partialdist.xml
 create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma.cfg
 create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma.xml

diff --git a/tests/libxlxml2domconfigdata/basic-hvm.json 
b/tests/libxlxml2domconfigdata/basic-hvm.json
index 6fa41f34f..3a5071e14 100644
--- a/tests/libxlxml2domconfigdata/basic-hvm.json
+++ b/tests/libxlxml2domconfigdata/basic-hvm.json
@@ -5,17 +5,105 @@
 "uuid": "2147d599-9cc6-c0dc-92ab-4064b5446e9b"
 },
 "b_info": {
-"max_vcpus": 4,
+"max_vcpus": 6,
 "avail_vcpus": [
 0,
 1,
 2,
-3
+3,
+4,
+5
+],
+"vnuma_nodes": [
+{
+"memkb": 2097152,
+"distances": [
+10,
+21,
+31,
+41,
+51,
+61
+],
+"vcpus": [
+0
+]
+},
+{
+"memkb": 2097152,
+"distances": [
+21,
+10,
+21,
+31,
+41,
+51
+],
+"vcpus": [
+1
+]
+},
+{
+"memkb": 2097152,
+"distances": [
+31,
+21,
+10,
+21,
+31,
+41
+],
+"vcpus": [
+2
+]
+},
+{
+"memkb": 2097152,
+"distances": [
+41,
+31,
+21,
+10,
+21,
+31
+],
+"vcpus": [
+3
+]
+},
+{
+"memkb": 2097152,
+"distances": [
+51,
+41,
+31,
+21,
+10,
+21
+],
+"vcpus": [
+4
+]
+},
+{
+"memkb": 2097152,
+"distances": [
+61,
+51,
+41,
+31,
+21,
+10
+],
+"vcpus": [
+5
+]
+}
 ],
 "max_memkb": 1048576,
 "target_memkb": 1048576,
 "video_memkb": 8192,
-"shadow_memkb": 12288,
+"shadow_memkb": 14336,
 "device_model_version": "qemu_xen",
 "device_model": "/bin/true",
 "sched_params": {
@@ -25,6 +113,7 @@
 "pae": "True",
 "apic": "True",
 "acpi": "True",
+"nested_hvm": "True",