Re: [libvirt] [PATCHv2 05/62] qemu: monitor: Remove useless 'locked' property from struct qemuDomainDiskInfo

2018-08-14 Thread Ján Tomko

s/useless/unused/ maybe?

On Mon, Aug 13, 2018 at 05:59:39PM +0200, Peter Krempa wrote:

We don't use it for anything useful so it does not make much sense to
extract it.

Signed-off-by: Peter Krempa 
---
src/qemu/qemu_domain.h   | 1 -
src/qemu/qemu_monitor_json.c | 7 ---
tests/qemumonitorjsontest.c  | 1 -
3 files changed, 9 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCHv2 05/62] qemu: monitor: Remove useless 'locked' property from struct qemuDomainDiskInfo

2018-08-13 Thread Peter Krempa
We don't use it for anything useful so it does not make much sense to
extract it.

Signed-off-by: Peter Krempa 
---
 src/qemu/qemu_domain.h   | 1 -
 src/qemu/qemu_monitor_json.c | 7 ---
 tests/qemumonitorjsontest.c  | 1 -
 3 files changed, 9 deletions(-)

diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index bff293fc0a..7b79d77257 100644
--- a/src/qemu/qemu_domain.h
+++ b/src/qemu/qemu_domain.h
@@ -438,7 +438,6 @@ struct _qemuDomainVcpuPrivate {

 struct qemuDomainDiskInfo {
 bool removable;
-bool locked;
 bool tray;
 bool tray_open;
 bool empty;
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index 0695ec8d2c..2389ebb9aa 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -2243,13 +2243,6 @@ int qemuMonitorJSONGetBlockInfo(qemuMonitorPtr mon,
 goto cleanup;
 }

-if (virJSONValueObjectGetBoolean(dev, "locked", &info->locked) < 0) {
-virReportError(VIR_ERR_INTERNAL_ERROR,
-   _("cannot read %s value"),
-   "locked");
-goto cleanup;
-}
-
 /* 'tray_open' is present only if the device has a tray */
 if (virJSONValueObjectGetBoolean(dev, "tray_open", &info->tray_open) 
== 0)
 info->tray = true;
diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
index 3a0490bd26..955892b1f6 100644
--- a/tests/qemumonitorjsontest.c
+++ b/tests/qemumonitorjsontest.c
@@ -1647,7 +1647,6 @@ testQemuMonitorJSONqemuMonitorJSONGetBlockInfo(const void 
*data)
 if (VIR_ALLOC(info) < 0)
 goto cleanup;

-info->locked = true;
 info->removable = true;
 info->tray = true;

-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list