Re: [libvirt] [PATCHv2 46/62] qemu: driver: Don't copy disk alias in qemuDomainBlocksStatsGather

[Ján Tomko]

On Mon, Aug 13, 2018 at 06:00:20PM +0200, Peter Krempa wrote:

The string is not modified so it does not make sense to have a copy.

Signed-off-by: Peter Krempa 
---
src/qemu/qemu_driver.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCHv2 46/62] qemu: driver: Don't copy disk alias in qemuDomainBlocksStatsGather

[Peter Krempa]

The string is not modified so it does not make sense to have a copy.

Signed-off-by: Peter Krempa 
---
 src/qemu/qemu_driver.c | 12 +---
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5dee701dc4..f36d4dc37f 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -11071,7 +11071,7 @@ qemuDomainBlocksStatsGather(virQEMUDriverPtr driver,
 virHashTablePtr blockstats = NULL;
 qemuBlockStatsPtr stats;
 int nstats;
-char *diskAlias = NULL;
+const char *entryname = NULL;
 int ret = -1;

 if (*path) {
@@ -11086,8 +11086,7 @@ qemuDomainBlocksStatsGather(virQEMUDriverPtr driver,
 goto cleanup;
 }

-if (VIR_STRDUP(diskAlias, disk->info.alias) < 0)
-goto cleanup;
+entryname = disk->info.alias;
 }

 qemuDomainObjEnterMonitor(driver, vm);
@@ -11103,10 +11102,10 @@ qemuDomainBlocksStatsGather(virQEMUDriverPtr driver,
 if (VIR_ALLOC(*retstats) < 0)
 goto cleanup;

-if (diskAlias) {
-if (!(stats = virHashLookup(blockstats, diskAlias))) {
+if (entryname) {
+if (!(stats = virHashLookup(blockstats, entryname))) {
 virReportError(VIR_ERR_INTERNAL_ERROR,
-   _("cannot find statistics for device '%s'"), 
diskAlias);
+   _("cannot find statistics for device '%s'"), 
entryname);
 goto cleanup;
 }

@@ -8,7 +7,6 @@ qemuDomainBlocksStatsGather(virQEMUDriverPtr driver,
 ret = nstats;

  cleanup:
-VIR_FREE(diskAlias);
 virHashFree(blockstats);
 return ret;
 }
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list