Re: [libvirt] [dbus PATCH 02/14] Implement ListNodeDevices method for Connect Interface

2018-06-19 Thread Pavel Hrdina
On Fri, Jun 15, 2018 at 07:03:38PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou 
> ---
>  data/org.libvirt.Connect.xml |  6 ++
>  src/connect.c| 38 ++
>  2 files changed, 44 insertions(+)

Reviewed-by: Pavel Hrdina 


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [dbus PATCH 02/14] Implement ListNodeDevices method for Connect Interface

2018-06-15 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou 
---
 data/org.libvirt.Connect.xml |  6 ++
 src/connect.c| 38 ++
 2 files changed, 44 insertions(+)

diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 37daed0..137e67b 100644
--- a/data/org.libvirt.Connect.xml
+++ b/data/org.libvirt.Connect.xml
@@ -160,6 +160,12 @@
   
   
 
+
+  https://libvirt.org/html/libvirt-libvirt-nodedev.html#virConnectListAllNodeDevices"/>
+  
+  
+
 
   https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virConnectListAllNWFilters"/>
diff --git a/src/connect.c b/src/connect.c
index 08898c8..919172a 100644
--- a/src/connect.c
+++ b/src/connect.c
@@ -798,6 +798,43 @@ virtDBusConnectListNetworks(GVariant *inArgs,
 *outArgs = g_variant_new_tuple(, 1);
 }
 
+static void
+virtDBusConnectListNodeDevices(GVariant *inArgs,
+   GUnixFDList *inFDs G_GNUC_UNUSED,
+   const gchar *objectPath G_GNUC_UNUSED,
+   gpointer userData,
+   GVariant **outArgs,
+   GUnixFDList **outFDs G_GNUC_UNUSED,
+   GError **error)
+{
+virtDBusConnect *connect = userData;
+g_autoptr(virNodeDevicePtr) devs = NULL;
+guint flags;
+GVariantBuilder builder;
+GVariant *gdevs;
+
+g_variant_get(inArgs, "(u)", );
+
+if (!virtDBusConnectOpen(connect, error))
+return;
+
+if (virConnectListAllNodeDevices(connect->connection, , flags) < 0)
+return virtDBusUtilSetLastVirtError(error);
+
+g_variant_builder_init(, G_VARIANT_TYPE("ao"));
+
+for (gint i = 0; devs[i]; i++) {
+g_autofree gchar *path = NULL;
+path = virtDBusUtilBusPathForVirNodeDevice(devs[i],
+   connect->devPath);
+
+g_variant_builder_add(, "o", path);
+}
+
+gdevs = g_variant_builder_end();
+*outArgs = g_variant_new_tuple(, 1);
+}
+
 static void
 virtDBusConnectListNWFilters(GVariant *inArgs,
  GUnixFDList *inFDs G_GNUC_UNUSED,
@@ -1632,6 +1669,7 @@ static virtDBusGDBusMethodTable 
virtDBusConnectMethodTable[] = {
 { "GetSysinfo", virtDBusConnectGetSysinfo },
 { "ListDomains", virtDBusConnectListDomains },
 { "ListNetworks", virtDBusConnectListNetworks },
+{ "ListNodeDevices", virtDBusConnectListNodeDevices },
 { "ListNWFilters", virtDBusConnectListNWFilters },
 { "ListSecrets", virtDBusConnectListSecrets },
 { "ListStoragePools", virtDBusConnectListStoragePools },
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list