Re: [libvirt] [dbus PATCH 3/4] Annotate properties for which we will not emit changed signal

2018-05-04 Thread Pavel Hrdina 
On Thu, May 03, 2018 at 03:21:01PM +0200, Katerina Koukiou wrote:
> On Thu, 2018-05-03 at 14:46 +0200, Pavel Hrdina wrote:
> > For some of these properties there is no libvirt event to detect the
> > change and for properties where we could somehow detect the change
> > let's annotate them as well.
> > 
> > We could change the properties to methods but with the annotation we
> > can keep them as properties in order to allow to get them by single
> > D-Bus call.
> > 
> > Signed-off-by: Pavel Hrdina 
> > ---
> >  data/org.libvirt.Connect.xml | 3 +++
> >  data/org.libvirt.Domain.xml  | 9 +
> >  data/org.libvirt.Network.xml | 3 +++
> >  3 files changed, 15 insertions(+)
> > 
> 
> Maybe it would be nicer to set `false` as the default annotation for
> EmitsChangedSignal in the enclosing interface element and explicitly
> mark the rest. But I am ok with this as well.

Good point, I missed that in D-Bus specification that the annotation can
be for the whole interface.  I'll sent v2.

Thanks,
Pavel


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 3/4] Annotate properties for which we will not emit changed signal

2018-05-03 Thread Katerina Koukiou 
On Thu, 2018-05-03 at 14:46 +0200, Pavel Hrdina wrote:
> For some of these properties there is no libvirt event to detect the
> change and for properties where we could somehow detect the change
> let's annotate them as well.
> 
> We could change the properties to methods but with the annotation we
> can keep them as properties in order to allow to get them by single
> D-Bus call.
> 
> Signed-off-by: Pavel Hrdina 
> ---
>  data/org.libvirt.Connect.xml | 3 +++
>  data/org.libvirt.Domain.xml  | 9 +
>  data/org.libvirt.Network.xml | 3 +++
>  3 files changed, 15 insertions(+)
> 

Maybe it would be nicer to set `false` as the default annotation for
EmitsChangedSignal in the enclosing interface element and explicitly
mark the rest. But I am ok with this as well.

Reviewed-by: Katerina Koukiou 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [dbus PATCH 3/4] Annotate properties for which we will not emit changed signal

2018-05-03 Thread Pavel Hrdina 
For some of these properties there is no libvirt event to detect the
change and for properties where we could somehow detect the change
let's annotate them as well.

We could change the properties to methods but with the annotation we
can keep them as properties in order to allow to get them by single
D-Bus call.

Signed-off-by: Pavel Hrdina 
---
 data/org.libvirt.Connect.xml | 3 +++
 data/org.libvirt.Domain.xml  | 9 +
 data/org.libvirt.Network.xml | 3 +++
 3 files changed, 15 insertions(+)

diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index ee7bfdc..3bddb89 100644
--- a/data/org.libvirt.Connect.xml
+++ b/data/org.libvirt.Connect.xml
@@ -11,10 +11,12 @@
 
   https://libvirt.org/html/libvirt-libvirt-host.html#virConnectGetHostname"/>
+  
 
 
   https://libvirt.org/html/libvirt-libvirt-host.html#virConnectGetLibVersion"/>
+  
 
 
   
   https://libvirt.org/html/libvirt-libvirt-host.html#virConnectGetVersion"/>
+  
 
 
   
   https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainIsActive"/>
+  
 
 
   https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetAutostart and

https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainSetAutostart"/>
+  
 
 
   https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetID"/>
+  
 
 
   https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetName"/>
+  
 
 
   https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetOSType"/>
+  
 
 
   https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainIsPersistent"/>
+  
 
 
   https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetSchedulerType"/>
+  
 
 
   https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetState"/>
+  
 
 
   https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainIsUpdated"/>
+  
 
 
   
   https://libvirt.org/html/libvirt-libvirt-network.html#virNetworkIsActive"/>
+  
 
 
   https://libvirt.org/html/libvirt-libvirt-network.html#virNetworkGetAutostart and

https://libvirt.org/html/libvirt-libvirt-network.html#virNetworkSetAutostart"/>
+  
 
 
   
   https://libvirt.org/html/libvirt-libvirt-network.html#virNetworkIsPersistent"/>
+  
 
 
   https://www.redhat.com/mailman/listinfo/libvir-list