Re: [libvirt] [dbus PATCH v2 03/17] Implement Create method for Interface Interface

2018-07-23 Thread Ján Tomko

On Fri, Jul 20, 2018 at 02:34:47PM -0400, Anya Harter wrote:

Signed-off-by: Anya Harter 
---
data/org.libvirt.Interface.xml |  5 
src/interface.c| 45 ++
2 files changed, 50 insertions(+)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [dbus PATCH v2 03/17] Implement Create method for Interface Interface

2018-07-20 Thread Anya Harter
Signed-off-by: Anya Harter 
---
 data/org.libvirt.Interface.xml |  5 
 src/interface.c| 45 ++
 2 files changed, 50 insertions(+)

diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index 93fa32f..d98a646 100644
--- a/data/org.libvirt.Interface.xml
+++ b/data/org.libvirt.Interface.xml
@@ -3,5 +3,10 @@
 
 
   
+
+  https://libvirt.org/html/libvirt-libvirt-interface.html#virInterfaceCreate"/>
+  
+
   
 
diff --git a/src/interface.c b/src/interface.c
index 3c32f0f..4a5e431 100644
--- a/src/interface.c
+++ b/src/interface.c
@@ -3,11 +3,56 @@
 
 #include 
 
+static virInterfacePtr
+virtDBusInterfaceGetVirInterface(virtDBusConnect *connect,
+ const gchar *objectPath,
+ GError **error)
+{
+virInterfacePtr interface;
+
+if (virtDBusConnectOpen(connect, error) < 0)
+return NULL;
+
+interface = virtDBusUtilVirInterfaceFromBusPath(connect->connection,
+objectPath,
+connect->interfacePath);
+if (!interface) {
+virtDBusUtilSetLastVirtError(error);
+return NULL;
+}
+
+return interface;
+}
+
+static void
+virtDBusInterfaceCreate(GVariant *inArgs,
+GUnixFDList *inFDs G_GNUC_UNUSED,
+const gchar *objectPath,
+gpointer userData,
+GVariant **outArgs G_GNUC_UNUSED,
+GUnixFDList **outFDs G_GNUC_UNUSED,
+GError **error)
+{
+virtDBusConnect *connect = userData;
+g_autoptr(virInterface) interface = NULL;
+guint flags;
+
+g_variant_get(inArgs, "(u)", );
+
+interface = virtDBusInterfaceGetVirInterface(connect, objectPath, error);
+if (!interface)
+return;
+
+if (virInterfaceCreate(interface, flags) < 0)
+virtDBusUtilSetLastVirtError(error);
+}
+
 static virtDBusGDBusPropertyTable virtDBusInterfacePropertyTable[] = {
 { 0 }
 };
 
 static virtDBusGDBusMethodTable virtDBusInterfaceMethodTable[] = {
+{ "Create", virtDBusInterfaceCreate },
 { 0 }
 };
 
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list