Re: [libvirt] [dbus PATCH v2 9/9] Remove reason to string translation in virtDBusEventsDomainDiskChange

[Pavel Hrdina]

On Fri, May 04, 2018 at 10:38:35AM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou 
> ---
>  data/org.libvirt.Domain.xml |  2 +-
>  src/events.c| 17 ++---
>  2 files changed, 3 insertions(+), 16 deletions(-)

Reviewed-by: Pavel Hrdina 


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [dbus PATCH v2 9/9] Remove reason to string translation in virtDBusEventsDomainDiskChange

[Katerina Koukiou]

Signed-off-by: Katerina Koukiou 
---
 data/org.libvirt.Domain.xml |  2 +-
 src/events.c| 17 ++---
 2 files changed, 3 insertions(+), 16 deletions(-)

diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 3627b1b..a09e868 100644
--- a/data/org.libvirt.Domain.xml
+++ b/data/org.libvirt.Domain.xml
@@ -572,7 +572,7 @@
   
   
   
-  
+  
 
 
   domainPath);
 
-switch (reason) {
-case VIR_DOMAIN_EVENT_DISK_CHANGE_MISSING_ON_START:
-reasonstr = "missing-on-start";
-break;
-case VIR_DOMAIN_EVENT_DISK_DROP_MISSING_ON_START:
-reasonstr = "missing-on-start";
-break;
-default:
-reasonstr = "";
-break;
-}
-
 g_dbus_connection_emit_signal(connect->bus,
   NULL,
   path,
   VIRT_DBUS_DOMAIN_INTERFACE,
   "DiskChange",
-  g_variant_new("()", old_src_path,
-new_src_path, device, 
reasonstr),
+  g_variant_new("(sssu)", old_src_path,
+new_src_path, device, reason),
   NULL);
 
 return 0;
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list