Re: [libvirt] [libvirt-designer][PATCH] Changes for code consistency

[Michal Privoznik]

On 21.03.2015 01:06, Jayashree Deshpande wrote:
 ---
  libvirt-designer/libvirt-designer-domain.c   | 194 
 ---
  libvirt-designer/libvirt-designer-domain.h   |  41 --
  libvirt-designer/libvirt-designer-internal.c |   3 +-
  libvirt-designer/libvirt-designer-internal.h |   4 +-
  libvirt-designer/libvirt-designer-main.c |  21 +--
  libvirt-designer/libvirt-designer-main.h |   7 +-
  6 files changed, 168 insertions(+), 102 deletions(-)

Ah! I did say I push the former patch of yours. But it seems like I
forgot to do so as I was leaving for the weekend. Lucky me, as this
patch enhances the one I forgot to push. I can merge those two together
and push as one. Cool. ACKed and pushed. Here's proof :)

http://libvirt.org/git/?p=libvirt-designer.git;a=commit;h=9c5614b60e3c98a820ac591987cca57d7f20cdd2

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt-designer][PATCH] Changes for code consistency

[Jayashree Deshpande]

---
 libvirt-designer/libvirt-designer-domain.c   | 194 ---
 libvirt-designer/libvirt-designer-domain.h   |  41 --
 libvirt-designer/libvirt-designer-internal.c |   3 +-
 libvirt-designer/libvirt-designer-internal.h |   4 +-
 libvirt-designer/libvirt-designer-main.c |  21 +--
 libvirt-designer/libvirt-designer-main.h |   7 +-
 6 files changed, 168 insertions(+), 102 deletions(-)

diff --git a/libvirt-designer/libvirt-designer-domain.c 
b/libvirt-designer/libvirt-designer-domain.c
index cefefea..adca733 100644
--- a/libvirt-designer/libvirt-designer-domain.c
+++ b/libvirt-designer/libvirt-designer-domain.c
@@ -66,7 +66,8 @@ gvir_designer_domain_error_quark(void)
 return g_quark_from_static_string(gvir-designer-domain);
 }
 
-static gboolean error_is_set(GError **error)
+static gboolean
+error_is_set(GError **error)
 {
 return ((error != NULL)  (*error != NULL));
 }
@@ -84,10 +85,11 @@ enum {
 PROP_OSINFO_DB,
 };
 
-static void gvir_designer_domain_get_property(GObject *object,
-  guint prop_id,
-  GValue *value,
-  GParamSpec *pspec)
+static void
+gvir_designer_domain_get_property(GObject *object,
+  guint prop_id,
+  GValue *value,
+  GParamSpec *pspec)
 {
 g_return_if_fail(GVIR_DESIGNER_IS_DOMAIN(object));
 
@@ -121,10 +123,11 @@ static void gvir_designer_domain_get_property(GObject 
*object,
 }
 
 
-static void gvir_designer_domain_set_property(GObject *object,
-  guint prop_id,
-  const GValue *value,
-  GParamSpec *pspec)
+static void
+gvir_designer_domain_set_property(GObject *object,
+  guint prop_id,
+  const GValue *value,
+  GParamSpec *pspec)
 {
 g_return_if_fail(GVIR_DESIGNER_IS_DOMAIN(object));
 
@@ -161,7 +164,8 @@ static void gvir_designer_domain_set_property(GObject 
*object,
 }
 
 
-static void gvir_designer_domain_finalize(GObject *object)
+static void
+gvir_designer_domain_finalize(GObject *object)
 {
 GVirDesignerDomain *conn = GVIR_DESIGNER_DOMAIN(object);
 GVirDesignerDomainPrivate *priv = conn-priv;
@@ -181,7 +185,8 @@ static void gvir_designer_domain_finalize(GObject *object)
 }
 
 
-static void gvir_designer_domain_class_init(GVirDesignerDomainClass *klass)
+static void
+gvir_designer_domain_class_init(GVirDesignerDomainClass *klass)
 {
 GObjectClass *object_class = G_OBJECT_CLASS(klass);
 
@@ -319,7 +324,8 @@ end:
 
 
 static GList *
-gvir_designer_domain_get_device_by_type(GVirDesignerDomain *design, GType type)
+gvir_designer_domain_get_device_by_type(GVirDesignerDomain *design,
+GType type)
 {
 GList *devices;
 GList *it;
@@ -341,7 +347,8 @@ gvir_designer_domain_get_device_by_type(GVirDesignerDomain 
*design, GType type)
 }
 
 
-static void gvir_designer_domain_add_clock(GVirDesignerDomain *design)
+static void
+gvir_designer_domain_add_clock(GVirDesignerDomain *design)
 {
 GVirConfigDomainClock *clock;
 GVirConfigDomainTimer *timer;
@@ -441,8 +448,9 @@ 
gvir_designer_domain_supports_spice_channel(GVirDesignerDomain *design)
 }
 
 
-static gboolean gvir_designer_domain_add_spice_channel(GVirDesignerDomain 
*design,
-   GError **error)
+static gboolean
+gvir_designer_domain_add_spice_channel(GVirDesignerDomain *design,
+   GError **error)
 {
 GVirConfigDomainChannel *channel;
 GVirConfigDomainChardevSourceSpiceVmc *vmc;
@@ -674,7 +682,8 @@ gvir_designer_domain_add_usb_controllers(GVirDesignerDomain 
*design)
  * Returns: (transfer full): the pointer to the new USB redir channel
  */
 GVirConfigDomainRedirdev *
-gvir_designer_domain_add_usb_redir(GVirDesignerDomain *design, GError **error)
+gvir_designer_domain_add_usb_redir(GVirDesignerDomain *design,
+   GError **error)
 {
 /* FIXME: check if OS/hypervisor support USB
  *check if SPICE is being used
@@ -717,7 +726,8 @@ gvir_designer_domain_add_usb_redir(GVirDesignerDomain 
*design, GError **error)
  * Returns: (transfer full): the pointer to the new smartcard device
  */
 GVirConfigDomainSmartcard *
-gvir_designer_domain_add_smartcard(GVirDesignerDomain *design, GError **error)
+gvir_designer_domain_add_smartcard(GVirDesignerDomain *design,
+   GError **error)
 {
 /* FIXME: check if OS/hypervisor support smartcard, might need
  *libosinfo improvements
@@ -742,7 +752,8 @@ gvir_designer_domain_add_smartcard(GVirDesignerDomain 
*design, GError **error)
 }
 
 
-static void