[libvirt] [libvirt-gconfig PATCHv2 25/32] GVirConfigInterface derives from GVirConfigDevice
This base class is mainly useful as a generic type when we manipulate list of devices regardless of their actual type. --- libvirt-gconfig/libvirt-gconfig-interface.c |2 +- libvirt-gconfig/libvirt-gconfig-interface.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-interface.c b/libvirt-gconfig/libvirt-gconfig-interface.c index b58a4b4..aadbc96 100644 --- a/libvirt-gconfig/libvirt-gconfig-interface.c +++ b/libvirt-gconfig/libvirt-gconfig-interface.c @@ -39,7 +39,7 @@ struct _GVirConfigInterfacePrivate gboolean unused; }; -G_DEFINE_TYPE(GVirConfigInterface, gvir_config_interface, GVIR_TYPE_CONFIG_OBJECT); +G_DEFINE_TYPE(GVirConfigInterface, gvir_config_interface, GVIR_TYPE_CONFIG_DEVICE); static void gvir_config_interface_class_init(GVirConfigInterfaceClass *klass) diff --git a/libvirt-gconfig/libvirt-gconfig-interface.h b/libvirt-gconfig/libvirt-gconfig-interface.h index 0728c29..2877341 100644 --- a/libvirt-gconfig/libvirt-gconfig-interface.h +++ b/libvirt-gconfig/libvirt-gconfig-interface.h @@ -42,7 +42,7 @@ typedef struct _GVirConfigInterfaceClass GVirConfigInterfaceClass; struct _GVirConfigInterface { -GVirConfigObject parent; +GVirConfigDevice parent; GVirConfigInterfacePrivate *priv; @@ -51,7 +51,7 @@ struct _GVirConfigInterface struct _GVirConfigInterfaceClass { -GVirConfigObjectClass parent_class; +GVirConfigDeviceClass parent_class; gpointer padding[20]; }; -- 1.7.7.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-gconfig PATCHv2 25/32] GVirConfigInterface derives from GVirConfigDevice
On Mon, Nov 21, 2011 at 07:04:22PM +0100, Christophe Fergeau wrote: > This base class is mainly useful as a generic type when we manipulate > list of devices regardless of their actual type. > --- > libvirt-gconfig/libvirt-gconfig-interface.c |2 +- > libvirt-gconfig/libvirt-gconfig-interface.h |4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Hmm, I don't believe this is correct. GVirConfigInterface is a top level XML document used for the GVirInterface object in libvirt. NB, not to be confused with the GVirConfigDomainInterface which is a device element within the GVirConfigDomain XML document. So NACK to this Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-gconfig PATCHv2 25/32] GVirConfigInterface derives from GVirConfigDevice
On Tue, Nov 22, 2011 at 01:14:41PM +, Daniel P. Berrange wrote: > On Mon, Nov 21, 2011 at 07:04:22PM +0100, Christophe Fergeau wrote: > > This base class is mainly useful as a generic type when we manipulate > > list of devices regardless of their actual type. > > --- > > libvirt-gconfig/libvirt-gconfig-interface.c |2 +- > > libvirt-gconfig/libvirt-gconfig-interface.h |4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > Hmm, I don't believe this is correct. GVirConfigInterface is a top level > XML document used for the GVirInterface object in libvirt. > > NB, not to be confused with the GVirConfigDomainInterface which is a device > element within the GVirConfigDomain XML document. Ah good catch, I indeed got confused.. Renamed to GVirConfigDomainInterface Christophe pgp1AH7RCOHv4.pgp Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list