Re: [libvirt] [libvirt-java] Add various block, snapshot and migrate methods
At Wed, 23 Jan 2013 16:19:43 +0100, Wido den Hollander wrote: Hello Claudio, On 01/23/2013 04:13 PM, Claudio Bley wrote: Hello Wido, At Sun, 13 Jan 2013 19:09:22 +0100, Wido den Hollander wrote: Hi, I've sent a series of patches like these about two weeks ago and got some great feedback from Claudio on those! The feedback from Claudio has been used for writing this series of patches. Backwards compatibility has been preserved by still using virDomainMigrate and virtDomainMigrateToUri for the exisiting methods, just to be sure. I have reviewed your changeset and basically it's OK with a few nits fixed. If you or somebody else doesn't have any objections I'd push the whole series. Thank you! I just saw your comments coming in. Since I don't know what the convention is for libvirt-java I followed most of the existing code with the implementation. Your feedback sounds good, so no objections from my side. OK, pushed now. Thanks for your submission! Claudio -- AV-Test GmbH, Henricistraße 20, 04155 Leipzig, Germany Phone: +49 341 265 310 19 Web:http://www.av-test.org Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076) Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-java] Add various block, snapshot and migrate methods
Hello Wido, At Sun, 13 Jan 2013 19:09:22 +0100, Wido den Hollander wrote: Hi, I've sent a series of patches like these about two weeks ago and got some great feedback from Claudio on those! The feedback from Claudio has been used for writing this series of patches. Backwards compatibility has been preserved by still using virDomainMigrate and virtDomainMigrateToUri for the exisiting methods, just to be sure. I have reviewed your changeset and basically it's OK with a few nits fixed. If you or somebody else doesn't have any objections I'd push the whole series. Claudio -- AV-Test GmbH, Henricistraße 20, 04155 Leipzig, Germany Phone: +49 341 265 310 19 Web:http://www.av-test.org Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076) Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-java] Add various block, snapshot and migrate methods
Hello Claudio, On 01/23/2013 04:13 PM, Claudio Bley wrote: Hello Wido, At Sun, 13 Jan 2013 19:09:22 +0100, Wido den Hollander wrote: Hi, I've sent a series of patches like these about two weeks ago and got some great feedback from Claudio on those! The feedback from Claudio has been used for writing this series of patches. Backwards compatibility has been preserved by still using virDomainMigrate and virtDomainMigrateToUri for the exisiting methods, just to be sure. I have reviewed your changeset and basically it's OK with a few nits fixed. If you or somebody else doesn't have any objections I'd push the whole series. Thank you! I just saw your comments coming in. Since I don't know what the convention is for libvirt-java I followed most of the existing code with the implementation. Your feedback sounds good, so no objections from my side. Wido Claudio -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [libvirt-java] Add various block, snapshot and migrate methods
Hi, I've sent a series of patches like these about two weeks ago and got some great feedback from Claudio on those! The feedback from Claudio has been used for writing this series of patches. Backwards compatibility has been preserved by still using virDomainMigrate and virtDomainMigrateToUri for the exisiting methods, just to be sure. Thank you, Wido -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
