Re: [libvirt] [libvirt-perl PATCH] Fix several APIs
On Mon, Sep 03, 2012 at 06:29:47PM +0800, Osier Yang wrote: On 2012年08月29日 14:44, Daniel P. Berrange wrote: On Wed, Aug 29, 2012 at 01:29:37AM -0400, Alex Jia wrote: ACK. -- Regards, Alex - Original Message - From: Osier Yangjy...@redhat.com To: libvir-list@redhat.com Sent: Tuesday, August 28, 2012 11:52:24 PM Subject: [libvirt] [libvirt-perl PATCH] Fix several APIs These APIs accept one more argument (flags), which was ignored in the XS implementations. --- Virt.xs | 46 ++ 1 files changed, 26 insertions(+), 20 deletions(-) ACK, if you also update the Domain.pm docs to mention the new flags parameters Thanks, Pushed with the doc and nits pointed out by gren updated (btw, most of the flags for APIs are not documented, and even some constants, such as constants for virTypedParameterFlags, could be later patch). Those constants should not be required, since the conversiuon is done internally. There is a test suite which validates that all libvirt public constants are present in the Perl binding, minus some blacklisted constants like virTypedParameterFlags ones Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-perl PATCH] Fix several APIs
On 2012年08月29日 14:44, Daniel P. Berrange wrote: On Wed, Aug 29, 2012 at 01:29:37AM -0400, Alex Jia wrote: ACK. -- Regards, Alex - Original Message - From: Osier Yangjy...@redhat.com To: libvir-list@redhat.com Sent: Tuesday, August 28, 2012 11:52:24 PM Subject: [libvirt] [libvirt-perl PATCH] Fix several APIs These APIs accept one more argument (flags), which was ignored in the XS implementations. --- Virt.xs | 46 ++ 1 files changed, 26 insertions(+), 20 deletions(-) ACK, if you also update the Domain.pm docs to mention the new flags parameters Thanks, Pushed with the doc and nits pointed out by gren updated (btw, most of the flags for APIs are not documented, and even some constants, such as constants for virTypedParameterFlags, could be later patch). Regards, Osier -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-perl PATCH] Fix several APIs
On 08/28/2012 11:52 PM, Osier Yang wrote:
These APIs accept one more argument (flags), which was ignored in
the XS implementations.
---
Virt.xs | 46 ++
1 files changed, 26 insertions(+), 20 deletions(-)
diff --git a/Virt.xs b/Virt.xs
index 2b8d74c..100ca43 100644
--- a/Virt.xs
+++ b/Virt.xs
@@ -2844,19 +2844,20 @@ set_scheduler_parameters(dom, newparams, flags=0)
HV *
-get_memory_parameters(dom)
+get_memory_parameters(dom, flags=0)
virDomainPtr dom;
+ unsigned int flags;
PREINIT:
virMemoryParameter *params;
int nparams;
CODE:
nparams = 0;
- if (virDomainGetMemoryParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetMemoryParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virMemoryParameter);
- if (virDomainGetMemoryParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetMemoryParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
@@ -2868,45 +2869,47 @@ get_memory_parameters(dom)
void
-set_memory_parameters(dom, newparams)
+set_memory_parameters(dom, newparams, flags=0)
virDomainPtr dom;
HV *newparams;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
PPCODE:
nparams = 0;
- if (virDomainGetMemoryParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetMemoryParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virMemoryParameter);
- if (virDomainGetMemoryParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetMemoryParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
vir_typed_param_from_hv(newparams, params, nparams);
- if (virDomainSetMemoryParameters(dom, params, nparams, 0) 0)
+ if (virDomainSetMemoryParameters(dom, params, nparams, flags) 0)
_croak_error();
Safefree(params);
HV *
-get_numa_parameters(dom)
+get_numa_parameters(dom, flags)
missing default value assignment
flags=0
virDomainPtr dom;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
CODE:
nparams = 0;
- if (virDomainGetNumaParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetNumaParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virTypedParameter);
- if (virDomainGetNumaParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetNumaParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
@@ -2918,45 +2921,47 @@ get_numa_parameters(dom)
void
-set_numa_parameters(dom, newparams)
+set_numa_parameters(dom, newparams, flags=0)
virDomainPtr dom;
HV *newparams;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
PPCODE:
nparams = 0;
- if (virDomainGetNumaParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetNumaParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virTypedParameter);
- if (virDomainGetNumaParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetNumaParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
vir_typed_param_from_hv(newparams, params, nparams);
- if (virDomainSetNumaParameters(dom, params, nparams, 0) 0)
+ if (virDomainSetNumaParameters(dom, params, nparams, flags) 0)
_croak_error();
Safefree(params);
HV *
-get_blkio_parameters(dom)
+get_blkio_parameters(dom, flags=0)
virDomainPtr dom;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
CODE:
nparams = 0;
- if (virDomainGetBlkioParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetBlkioParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virBlkioParameter);
- if (virDomainGetBlkioParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetBlkioParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
@@ -2968,21 +2973,22 @@ get_blkio_parameters(dom)
void
-set_blkio_parameters(dom, newparams)
+set_blkio_parameters(dom, newparams, flags=0)
virDomainPtr dom;
HV *newparams;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
int needString;
PPCODE:
nparams = 0;
- if (virDomainGetBlkioParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetBlkioParameters(dom, NULL,
Re: [libvirt] [libvirt-perl PATCH] Fix several APIs
On Wed, Aug 29, 2012 at 01:29:37AM -0400, Alex Jia wrote: ACK. -- Regards, Alex - Original Message - From: Osier Yang jy...@redhat.com To: libvir-list@redhat.com Sent: Tuesday, August 28, 2012 11:52:24 PM Subject: [libvirt] [libvirt-perl PATCH] Fix several APIs These APIs accept one more argument (flags), which was ignored in the XS implementations. --- Virt.xs | 46 ++ 1 files changed, 26 insertions(+), 20 deletions(-) ACK, if you also update the Domain.pm docs to mention the new flags parameters Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [libvirt-perl PATCH] Fix several APIs
These APIs accept one more argument (flags), which was ignored in
the XS implementations.
---
Virt.xs | 46 ++
1 files changed, 26 insertions(+), 20 deletions(-)
diff --git a/Virt.xs b/Virt.xs
index 2b8d74c..100ca43 100644
--- a/Virt.xs
+++ b/Virt.xs
@@ -2844,19 +2844,20 @@ set_scheduler_parameters(dom, newparams, flags=0)
HV *
-get_memory_parameters(dom)
+get_memory_parameters(dom, flags=0)
virDomainPtr dom;
+ unsigned int flags;
PREINIT:
virMemoryParameter *params;
int nparams;
CODE:
nparams = 0;
- if (virDomainGetMemoryParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetMemoryParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virMemoryParameter);
- if (virDomainGetMemoryParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetMemoryParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
@@ -2868,45 +2869,47 @@ get_memory_parameters(dom)
void
-set_memory_parameters(dom, newparams)
+set_memory_parameters(dom, newparams, flags=0)
virDomainPtr dom;
HV *newparams;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
PPCODE:
nparams = 0;
- if (virDomainGetMemoryParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetMemoryParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virMemoryParameter);
- if (virDomainGetMemoryParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetMemoryParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
vir_typed_param_from_hv(newparams, params, nparams);
- if (virDomainSetMemoryParameters(dom, params, nparams, 0) 0)
+ if (virDomainSetMemoryParameters(dom, params, nparams, flags) 0)
_croak_error();
Safefree(params);
HV *
-get_numa_parameters(dom)
+get_numa_parameters(dom, flags)
virDomainPtr dom;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
CODE:
nparams = 0;
- if (virDomainGetNumaParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetNumaParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virTypedParameter);
- if (virDomainGetNumaParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetNumaParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
@@ -2918,45 +2921,47 @@ get_numa_parameters(dom)
void
-set_numa_parameters(dom, newparams)
+set_numa_parameters(dom, newparams, flags=0)
virDomainPtr dom;
HV *newparams;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
PPCODE:
nparams = 0;
- if (virDomainGetNumaParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetNumaParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virTypedParameter);
- if (virDomainGetNumaParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetNumaParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
vir_typed_param_from_hv(newparams, params, nparams);
- if (virDomainSetNumaParameters(dom, params, nparams, 0) 0)
+ if (virDomainSetNumaParameters(dom, params, nparams, flags) 0)
_croak_error();
Safefree(params);
HV *
-get_blkio_parameters(dom)
+get_blkio_parameters(dom, flags=0)
virDomainPtr dom;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
CODE:
nparams = 0;
- if (virDomainGetBlkioParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetBlkioParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virBlkioParameter);
- if (virDomainGetBlkioParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetBlkioParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
@@ -2968,21 +2973,22 @@ get_blkio_parameters(dom)
void
-set_blkio_parameters(dom, newparams)
+set_blkio_parameters(dom, newparams, flags=0)
virDomainPtr dom;
HV *newparams;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
int needString;
PPCODE:
nparams = 0;
- if (virDomainGetBlkioParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetBlkioParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virBlkioParameter);
- if (virDomainGetBlkioParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetBlkioParameters(dom, params,
Re: [libvirt] [libvirt-perl PATCH] Fix several APIs
ACK.
--
Regards,
Alex
- Original Message -
From: Osier Yang jy...@redhat.com
To: libvir-list@redhat.com
Sent: Tuesday, August 28, 2012 11:52:24 PM
Subject: [libvirt] [libvirt-perl PATCH] Fix several APIs
These APIs accept one more argument (flags), which was ignored in
the XS implementations.
---
Virt.xs | 46 ++
1 files changed, 26 insertions(+), 20 deletions(-)
diff --git a/Virt.xs b/Virt.xs
index 2b8d74c..100ca43 100644
--- a/Virt.xs
+++ b/Virt.xs
@@ -2844,19 +2844,20 @@ set_scheduler_parameters(dom, newparams, flags=0)
HV *
-get_memory_parameters(dom)
+get_memory_parameters(dom, flags=0)
virDomainPtr dom;
+ unsigned int flags;
PREINIT:
virMemoryParameter *params;
int nparams;
CODE:
nparams = 0;
- if (virDomainGetMemoryParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetMemoryParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virMemoryParameter);
- if (virDomainGetMemoryParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetMemoryParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
@@ -2868,45 +2869,47 @@ get_memory_parameters(dom)
void
-set_memory_parameters(dom, newparams)
+set_memory_parameters(dom, newparams, flags=0)
virDomainPtr dom;
HV *newparams;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
PPCODE:
nparams = 0;
- if (virDomainGetMemoryParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetMemoryParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virMemoryParameter);
- if (virDomainGetMemoryParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetMemoryParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
vir_typed_param_from_hv(newparams, params, nparams);
- if (virDomainSetMemoryParameters(dom, params, nparams, 0) 0)
+ if (virDomainSetMemoryParameters(dom, params, nparams, flags) 0)
_croak_error();
Safefree(params);
HV *
-get_numa_parameters(dom)
+get_numa_parameters(dom, flags)
virDomainPtr dom;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
CODE:
nparams = 0;
- if (virDomainGetNumaParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetNumaParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virTypedParameter);
- if (virDomainGetNumaParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetNumaParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
@@ -2918,45 +2921,47 @@ get_numa_parameters(dom)
void
-set_numa_parameters(dom, newparams)
+set_numa_parameters(dom, newparams, flags=0)
virDomainPtr dom;
HV *newparams;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
PPCODE:
nparams = 0;
- if (virDomainGetNumaParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetNumaParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virTypedParameter);
- if (virDomainGetNumaParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetNumaParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
vir_typed_param_from_hv(newparams, params, nparams);
- if (virDomainSetNumaParameters(dom, params, nparams, 0) 0)
+ if (virDomainSetNumaParameters(dom, params, nparams, flags) 0)
_croak_error();
Safefree(params);
HV *
-get_blkio_parameters(dom)
+get_blkio_parameters(dom, flags=0)
virDomainPtr dom;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
CODE:
nparams = 0;
- if (virDomainGetBlkioParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetBlkioParameters(dom, NULL, nparams, flags) 0)
_croak_error();
Newx(params, nparams, virBlkioParameter);
- if (virDomainGetBlkioParameters(dom, params, nparams, 0) 0) {
+ if (virDomainGetBlkioParameters(dom, params, nparams, flags) 0) {
Safefree(params);
_croak_error();
}
@@ -2968,21 +2973,22 @@ get_blkio_parameters(dom)
void
-set_blkio_parameters(dom, newparams)
+set_blkio_parameters(dom, newparams, flags=0)
virDomainPtr dom;
HV *newparams;
+ unsigned int flags;
PREINIT:
virTypedParameter *params;
int nparams;
int needString;
PPCODE:
nparams = 0;
- if (virDomainGetBlkioParameters(dom, NULL, nparams, 0) 0)
+ if (virDomainGetBlkioParameters(dom, NULL
