[libvirt] [libvirt-sandbox PATCH] docker: Don't ignore qemu-img errors
--- libvirt-sandbox/image/sources/docker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-sandbox/image/sources/docker.py b/libvirt-sandbox/image/sources/docker.py index 43e9c32..aa5675e 100755 --- a/libvirt-sandbox/image/sources/docker.py +++ b/libvirt-sandbox/image/sources/docker.py @@ -662,7 +662,7 @@ class DockerSource(base.Source): cmd.append("-o") cmd.append("backing_fmt=qcow2,backing_file=%s" % diskfile) cmd.append(tempfile) -subprocess.call(cmd) +subprocess.check_call(cmd) return tempfile def get_command(self, template, templatedir, userargs): -- 2.11.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-sandbox PATCH] docker: Don't ignore qemu-img errors
On Sat, 2017-05-27 at 18:30 +0200, Guido Günther wrote: > --- > libvirt-sandbox/image/sources/docker.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libvirt-sandbox/image/sources/docker.py > b/libvirt-sandbox/image/sources/docker.py > index 43e9c32..aa5675e 100755 > --- a/libvirt-sandbox/image/sources/docker.py > +++ b/libvirt-sandbox/image/sources/docker.py > @@ -662,7 +662,7 @@ class DockerSource(base.Source): > cmd.append("-o") > cmd.append("backing_fmt=qcow2,backing_file=%s" % diskfile) > cmd.append(tempfile) > -subprocess.call(cmd) > +subprocess.check_call(cmd) > return tempfile > > def get_command(self, template, templatedir, userargs): ACK -- Cedric -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-sandbox PATCH] docker: Don't ignore qemu-img errors
On Mon, May 29, 2017 at 11:43:53AM +0200, Cedric Bosdonnat wrote: > On Sat, 2017-05-27 at 18:30 +0200, Guido Günther wrote: > > --- > > libvirt-sandbox/image/sources/docker.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libvirt-sandbox/image/sources/docker.py > > b/libvirt-sandbox/image/sources/docker.py > > index 43e9c32..aa5675e 100755 > > --- a/libvirt-sandbox/image/sources/docker.py > > +++ b/libvirt-sandbox/image/sources/docker.py > > @@ -662,7 +662,7 @@ class DockerSource(base.Source): > > cmd.append("-o") > > cmd.append("backing_fmt=qcow2,backing_file=%s" % diskfile) > > cmd.append(tempfile) > > -subprocess.call(cmd) > > +subprocess.check_call(cmd) > > return tempfile > > > > def get_command(self, template, templatedir, userargs): > > ACK Pushed. Thanks -- Guido > > -- > Cedric > -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list