[libvirt] [python PATCH v2 2/5] API: Skip 'virDomainStatsRecordListFree'

[Pavel Hrdina]

From: Peter Krempa pkre...@redhat.com

The new API function doesn't make sense to be exported in python. The
bindings will return native types instead of the struct array.

Signed-off-by: Peter Krempa pkre...@redhat.com
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
 generator.py  | 1 +
 sanitytest.py | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/generator.py b/generator.py
index 0d41e20..c4c12df 100755
--- a/generator.py
+++ b/generator.py
@@ -571,6 +571,7 @@ skip_function = (
 virTypedParamsGetULLong,
 
 'virNetworkDHCPLeaseFree', # only useful in C, python code uses list
+'virDomainStatsRecordListFree', # only useful in C, python uses dict
 )
 
 lxc_skip_function = (
diff --git a/sanitytest.py b/sanitytest.py
index 4f4a648..10cf9f0 100644
--- a/sanitytest.py
+++ b/sanitytest.py
@@ -81,6 +81,9 @@ for cname in wantfunctions:
 if name[0:23] == virNetworkDHCPLeaseFree:
 continue
 
+if name[0:28] == virDomainStatsRecordListFree:
+continue
+
 # These aren't functions, they're callback signatures
 if name in [virConnectAuthCallbackPtr, virConnectCloseFunc,
 virStreamSinkFunc, virStreamSourceFunc, 
virStreamEventCallback,
-- 
1.8.5.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [python PATCH v2 2/5] API: Skip 'virDomainStatsRecordListFree'

[Peter Krempa]

On 09/01/14 22:18, Pavel Hrdina wrote:
 From: Peter Krempa pkre...@redhat.com
 
 The new API function doesn't make sense to be exported in python. The
 bindings will return native types instead of the struct array.
 
 Signed-off-by: Peter Krempa pkre...@redhat.com
 Signed-off-by: Pavel Hrdina phrd...@redhat.com
 ---
  generator.py  | 1 +
  sanitytest.py | 3 +++
  2 files changed, 4 insertions(+)
 

 diff --git a/sanitytest.py b/sanitytest.py
 index 4f4a648..10cf9f0 100644
 --- a/sanitytest.py
 +++ b/sanitytest.py
 @@ -81,6 +81,9 @@ for cname in wantfunctions:
  if name[0:23] == virNetworkDHCPLeaseFree:
  continue
  
 +if name[0:28] == virDomainStatsRecordListFree:
 +continue
 +

Thanks for catching this. I didn't run the sanity test :/

  # These aren't functions, they're callback signatures
  if name in [virConnectAuthCallbackPtr, virConnectCloseFunc,
  virStreamSinkFunc, virStreamSourceFunc, 
 virStreamEventCallback,
 

ACK,

Peter




signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list