Re: [libvirt] [python PATCH v7] Add virDomainCheckpoint APIs

2019-07-29 Thread Eric Blake
On 4/3/19 4:49 AM, Daniel P. Berrangé wrote:
> On Wed, Mar 27, 2019 at 05:09:27AM -0500, Eric Blake wrote:
>> Copies heavily from existing virDomainSnapshot handling, regarding
>> what special cases the generator has to be taught and what overrides
>> need to be written.
>>
>> Signed-off-by: Eric Blake 
>> ---
>>
>> Python counterparts to my incremental backup patches. An earlier
>> version was already reviewed by Dan; the main diff here is the
>> addition of virDomainSnapshotCreateXML2 handling.

Now that 5.6.0 will have the virDomainCheckpoint API but not
virDomainSnapshotCreateXML2, I've reduced this patch down to the
portions still relevant and pushed.  When we later get around to
integrating snapshots and checkpoints, we'll tweak the python bindings
again at that time to cover any additional APIs.


> 
> Reviewed-by: Daniel P. Berrangé 
> 
> 
> Regards,
> Daniel
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [python PATCH v7] Add virDomainCheckpoint APIs

2019-04-03 Thread Daniel P . Berrangé
On Wed, Mar 27, 2019 at 05:09:27AM -0500, Eric Blake wrote:
> Copies heavily from existing virDomainSnapshot handling, regarding
> what special cases the generator has to be taught and what overrides
> need to be written.
> 
> Signed-off-by: Eric Blake 
> ---
> 
> Python counterparts to my incremental backup patches. An earlier
> version was already reviewed by Dan; the main diff here is the
> addition of virDomainSnapshotCreateXML2 handling.
> 
>  HACKING |  2 +
>  MANIFEST.in |  1 +
>  generator.py| 37 --
>  libvirt-override-api.xml| 12 
>  libvirt-override-virDomain.py   | 13 
>  libvirt-override-virDomainCheckpoint.py | 19 +
>  libvirt-override.c  | 96 +
>  sanitytest.py   | 11 +--
>  typewrappers.c  | 13 
>  typewrappers.h  | 10 +++
>  10 files changed, 206 insertions(+), 8 deletions(-)
>  create mode 100644 libvirt-override-virDomainCheckpoint.py

Reviewed-by: Daniel P. Berrangé 


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [python PATCH v7] Add virDomainCheckpoint APIs

2019-03-27 Thread Eric Blake
Copies heavily from existing virDomainSnapshot handling, regarding
what special cases the generator has to be taught and what overrides
need to be written.

Signed-off-by: Eric Blake 
---

Python counterparts to my incremental backup patches. An earlier
version was already reviewed by Dan; the main diff here is the
addition of virDomainSnapshotCreateXML2 handling.

 HACKING |  2 +
 MANIFEST.in |  1 +
 generator.py| 37 --
 libvirt-override-api.xml| 12 
 libvirt-override-virDomain.py   | 13 
 libvirt-override-virDomainCheckpoint.py | 19 +
 libvirt-override.c  | 96 +
 sanitytest.py   | 11 +--
 typewrappers.c  | 13 
 typewrappers.h  | 10 +++
 10 files changed, 206 insertions(+), 8 deletions(-)
 create mode 100644 libvirt-override-virDomainCheckpoint.py

diff --git a/HACKING b/HACKING
index 6eeb9e6..39e7cd3 100644
--- a/HACKING
+++ b/HACKING
@@ -28,6 +28,8 @@ hand written source files
the virConnect class
  - libvirt-override-virDomain.py - high level overrides in
the virDomain class
+ - libvirt-override-virDomainCheckpoint.py - high level overrides in
+   the virDomainCheckpoint class
  - libvirt-override-virDomainSnapshot.py - high level overrides in
the virDomainSnapshot class
  - libvirt-override-virStoragePool.py - high level overrides in
diff --git a/MANIFEST.in b/MANIFEST.in
index b6788f4..5d2f559 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -23,6 +23,7 @@ include libvirt-override.c
 include libvirt-override.py
 include libvirt-override-virConnect.py
 include libvirt-override-virDomain.py
+include libvirt-override-virDomainCheckpoint.py
 include libvirt-override-virDomainSnapshot.py
 include libvirt-override-virStoragePool.py
 include libvirt-override-virStream.py
diff --git a/generator.py b/generator.py
index ffa3ce5..a16f9b1 100755
--- a/generator.py
+++ b/generator.py
@@ -35,6 +35,7 @@ libvirt_headers = [
 "libvirt",
 "libvirt-common",
 "libvirt-domain",
+"libvirt-domain-checkpoint",
 "libvirt-domain-snapshot",
 "libvirt-event",
 "libvirt-host",
@@ -364,6 +365,10 @@ py_types = {
 'virStream *':  ('O', "virStream", "virStreamPtr", "virStreamPtr"),
 'const virStream *':  ('O', "virStream", "virStreamPtr", "virStreamPtr"),

+'virDomainCheckpointPtr':  ('O', "virDomainCheckpoint", 
"virDomainCheckpointPtr", "virDomainCheckpointPtr"),
+'virDomainCheckpoint *':  ('O', "virDomainCheckpoint", 
"virDomainCheckpointPtr", "virDomainCheckpointPtr"),
+'const virDomainCheckpoint *':  ('O', "virDomainCheckpoint", 
"virDomainCheckpointPtr", "virDomainCheckpointPtr"),
+
 'virDomainSnapshotPtr':  ('O', "virDomainSnapshot", 
"virDomainSnapshotPtr", "virDomainSnapshotPtr"),
 'virDomainSnapshot *':  ('O', "virDomainSnapshot", "virDomainSnapshotPtr", 
"virDomainSnapshotPtr"),
 'const virDomainSnapshot *':  ('O', "virDomainSnapshot", 
"virDomainSnapshotPtr", "virDomainSnapshotPtr"),
@@ -536,6 +541,8 @@ skip_function = (
 'virSaveLastError', # We have our own python error wrapper
 'virFreeError', # Only needed if we use virSaveLastError
 'virConnectListAllDomains', # overridden in virConnect.py
+'virDomainListAllCheckpoints', # overridden in virDomain.py
+'virDomainCheckpointListAllChildren', # overridden in 
virDomainCheckpoint.py
 'virDomainListAllSnapshots', # overridden in virDomain.py
 'virDomainSnapshotListAllChildren', # overridden in virDomainSnapshot.py
 'virConnectListAllStoragePools', # overridden in virConnect.py
@@ -582,6 +589,7 @@ skip_function = (
 "virStoragePoolRef",
 "virStorageVolRef",
 "virStreamRef",
+"virDomainCheckpointRef",
 "virDomainSnapshotRef",

 # This functions shouldn't be called via the bindings (and even the docs
@@ -594,6 +602,8 @@ skip_function = (
 "virNWFilterGetConnect",
 "virStoragePoolGetConnect",
 "virStorageVolGetConnect",
+"virDomainCheckpointGetConnect",
+"virDomainCheckpointGetDomain",
 "virDomainSnapshotGetConnect",
 "virDomainSnapshotGetDomain",

@@ -1023,6 +1033,8 @@ classes_type = {
 "virStream *": ("._o", "virStream(self, _obj=%s)", "virStream"),
 "virConnectPtr": ("._o", "virConnect(_obj=%s)", "virConnect"),
 "virConnect *": ("._o", "virConnect(_obj=%s)", "virConnect"),
+"virDomainCheckpointPtr": ("._o", "virDomainCheckpoint(self,_obj=%s)", 
"virDomainCheckpoint"),
+"virDomainCheckpoint *": ("._o", "virDomainCheckpoint(self, _obj=%s)", 
"virDomainCheckpoint"),
 "virDomainSnapshotPtr": ("._o", "virDomainSnapshot(self,_obj=%s)", 
"virDomainSnapshot"),
 "virDomainSnapshot *": ("._o", "virDomainSnapshot(self, _obj=%s)", 
"virDomainSnapshot"),
 }
@@ -1031,7 +1043,7 @@ primary_classes = ["virDomain", "virNetwork", 
"virInterface",