[libvirt] [sandbox PATCH 00/10] Patches for libvirt-sandbox
Hello, These patches provide disk support for libvirt-sandbox. Implemented '--disk' parameter will be useful when integrating Docker image support for libvirt-sandbox. --Main diffs compared to previous patches. Since many hypervisors, including kvm, will not even honour requested names for disk devices we link each device under /dev/disk/by-tag e.g /dev/disk/by-tag/foobar -> /dev/sda We populate disks.cfg with tag to device mapping when we build the sandbox. After that, in each init-process {Common,Qemu}, we basically read the configuration and populate the right symlinks under /dev/disk/by-tag The common functions for modifying directories are moved under Init-util. {Common,Qemu} inits are using them. Cédric Bosdonnat (2): Add gvir_sandbox_config_has_disks function qemu: use devtmpfs rather than tmpfs to auto-populate /dev Eren Yagdiran (8): Add an utility function for guessing filetype from file extension Add configuration object for disk support Add disk parameter to virt-sandbox Add disk support to the container builder Add disk support to machine builder Init-util : Common directory functions for init-common and init-qemu Common-init: Building symlink from disks.cfg Common-builder: /dev/disk/by-tag/thetag to /dev/vdN bin/virt-sandbox.c | 37 +++ libvirt-sandbox/Makefile.am| 7 +- .../libvirt-sandbox-builder-container.c| 36 ++- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 44 ++- libvirt-sandbox/libvirt-sandbox-builder.c | 73 - libvirt-sandbox/libvirt-sandbox-config-disk.c | 274 +++ libvirt-sandbox/libvirt-sandbox-config-disk.h | 82 ++ libvirt-sandbox/libvirt-sandbox-config.c | 300 + libvirt-sandbox/libvirt-sandbox-config.h | 11 + libvirt-sandbox/libvirt-sandbox-init-common.c | 51 +++- libvirt-sandbox/libvirt-sandbox-init-qemu.c| 151 ++- libvirt-sandbox/libvirt-sandbox-init-util.c| 58 libvirt-sandbox/libvirt-sandbox-init-util.h| 41 +++ libvirt-sandbox/libvirt-sandbox-util.c | 72 + libvirt-sandbox/libvirt-sandbox-util.h | 5 + libvirt-sandbox/libvirt-sandbox.h | 1 + libvirt-sandbox/libvirt-sandbox.sym| 5 + libvirt-sandbox/tests/test-config.c| 11 + po/POTFILES.in | 1 + 19 files changed, insertions(+), 149 deletions(-) create mode 100644 libvirt-sandbox/libvirt-sandbox-config-disk.c create mode 100644 libvirt-sandbox/libvirt-sandbox-config-disk.h create mode 100644 libvirt-sandbox/libvirt-sandbox-init-util.c create mode 100644 libvirt-sandbox/libvirt-sandbox-init-util.h create mode 100644 libvirt-sandbox/libvirt-sandbox-util.c -- 2.1.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [sandbox PATCH 00/10] Patches for Libvirt-sandbox
Hello, These patches provide disk support for libvirt-sandbox. Implemented '--disk' parameter will be useful when integrating Docker image support for libvirt-sandbox. --Main diffs compared to previous patches. Since many hypervisors, including kvm, will not even honour requested names for disk devices we link each device under /dev/disk/by-tag e.g /dev/disk/by-tag/foobar -> /dev/sda We populate disks.cfg with tag to device mapping when we build the sandbox. After that, in each init-process {Common,Qemu}, we basically read the configuration and populate the right symlinks under /dev/disk/by-tag The common functions for modifying directories are moved under Init-util. {Common,Qemu} inits are using them. Cédric Bosdonnat (2): Add gvir_sandbox_config_has_disks function qemu: use devtmpfs rather than tmpfs to auto-populate /dev Eren Yagdiran (8): Add an utility function for guessing filetype from file extension Add configuration object for disk support Add disk parameter to virt-sandbox Add disk support to the container builder Add disk support to machine builder Init-util : Common directory functions for init-common and init-qemu Common-init: Building symlink from disks.cfg Common-builder: /dev/disk/by-tag/thetag to /dev/vdN bin/virt-sandbox.c | 37 +++ libvirt-sandbox/Makefile.am| 7 +- .../libvirt-sandbox-builder-container.c| 37 ++- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 44 ++- libvirt-sandbox/libvirt-sandbox-builder.c | 73 - libvirt-sandbox/libvirt-sandbox-config-disk.c | 274 +++ libvirt-sandbox/libvirt-sandbox-config-disk.h | 82 ++ libvirt-sandbox/libvirt-sandbox-config.c | 300 + libvirt-sandbox/libvirt-sandbox-config.h | 11 + libvirt-sandbox/libvirt-sandbox-init-common.c | 51 +++- libvirt-sandbox/libvirt-sandbox-init-qemu.c| 151 ++- libvirt-sandbox/libvirt-sandbox-init-util.c| 58 libvirt-sandbox/libvirt-sandbox-init-util.h| 41 +++ libvirt-sandbox/libvirt-sandbox-util.c | 72 + libvirt-sandbox/libvirt-sandbox-util.h | 5 + libvirt-sandbox/libvirt-sandbox.h | 1 + libvirt-sandbox/libvirt-sandbox.sym| 5 + libvirt-sandbox/tests/test-config.c| 11 + po/POTFILES.in | 1 + 19 files changed, 1112 insertions(+), 149 deletions(-) create mode 100644 libvirt-sandbox/libvirt-sandbox-config-disk.c create mode 100644 libvirt-sandbox/libvirt-sandbox-config-disk.h create mode 100644 libvirt-sandbox/libvirt-sandbox-init-util.c create mode 100644 libvirt-sandbox/libvirt-sandbox-init-util.h create mode 100644 libvirt-sandbox/libvirt-sandbox-util.c -- 2.1.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [sandbox PATCH 00/10] Patches for Libvirt-sandbox
Hello, These patches provide disk support for libvirt-sandbox. Implemented '--disk' parameter will be useful when integrating Docker image support for libvirt-sandbox. --Main diffs compared to previous patches. Since many hypervisors, including kvm, will not even honour requested names for disk devices we link each device under /dev/disk/by-tag e.g /dev/disk/by-tag/foobar -> /dev/sda We populate disks.cfg with tag to device mapping when we build the sandbox. After that, in each init-process {Common,Qemu}, we basically read the configuration and populate the right symlinks under /dev/disk/by-tag The common functions for modifying directories are moved under Init-util. {Common,Qemu} inits are using them. Cédric Bosdonnat (2): Add gvir_sandbox_config_has_disks function qemu: use devtmpfs rather than tmpfs to auto-populate /dev Eren Yagdiran (8): Add an utility function for guessing filetype from file extension Add configuration object for disk support Add disk parameter to virt-sandbox Add disk support to the container builder Add disk support to machine builder Init-util : Common directory functions for init-common and init-qemu Common-init: Building symlink from disks.cfg Common-builder: /dev/disk/by-tag/thetag to /dev/vdN bin/virt-sandbox.c | 37 +++ libvirt-sandbox/Makefile.am| 7 +- .../libvirt-sandbox-builder-container.c| 37 ++- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 44 ++- libvirt-sandbox/libvirt-sandbox-builder.c | 73 - libvirt-sandbox/libvirt-sandbox-config-disk.c | 274 +++ libvirt-sandbox/libvirt-sandbox-config-disk.h | 82 ++ libvirt-sandbox/libvirt-sandbox-config.c | 300 + libvirt-sandbox/libvirt-sandbox-config.h | 11 + libvirt-sandbox/libvirt-sandbox-init-common.c | 51 +++- libvirt-sandbox/libvirt-sandbox-init-qemu.c| 151 ++- libvirt-sandbox/libvirt-sandbox-init-util.c| 58 libvirt-sandbox/libvirt-sandbox-init-util.h| 41 +++ libvirt-sandbox/libvirt-sandbox-util.c | 72 + libvirt-sandbox/libvirt-sandbox-util.h | 5 + libvirt-sandbox/libvirt-sandbox.h | 1 + libvirt-sandbox/libvirt-sandbox.sym| 5 + libvirt-sandbox/tests/test-config.c| 11 + po/POTFILES.in | 1 + 19 files changed, 1112 insertions(+), 149 deletions(-) create mode 100644 libvirt-sandbox/libvirt-sandbox-config-disk.c create mode 100644 libvirt-sandbox/libvirt-sandbox-config-disk.h create mode 100644 libvirt-sandbox/libvirt-sandbox-init-util.c create mode 100644 libvirt-sandbox/libvirt-sandbox-init-util.h create mode 100644 libvirt-sandbox/libvirt-sandbox-util.c -- 2.1.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [sandbox PATCH 00/10] Patches for Libvirt-sandbox
Hello, These patches provide disk support for libvirt-sandbox. Implemented '--disk' parameter will be useful when integrating Docker image support for libvirt-sandbox. --Main diffs compared to previous patches. Since many hypervisors, including kvm, will not even honour requested names for disk devices we link each device under /dev/disk/by-tag e.g /dev/disk/by-tag/foobar -> /dev/sda We populate disks.cfg with tag to device mapping when we build the sandbox. After that, in each init-process {Common,Qemu}, we basically read the configuration and populate the right symlinks under /dev/disk/by-tag The common functions for modifying directories are moved under Init-util. {Common,Qemu} inits are using them. Cédric Bosdonnat (2): Add gvir_sandbox_config_has_disks function qemu: use devtmpfs rather than tmpfs to auto-populate /dev Eren Yagdiran (8): Add an utility function for guessing filetype from file extension Add configuration object for disk support Add disk parameter to virt-sandbox Add disk support to the container builder Add disk support to machine builder Init-util : Common directory functions for init-common and init-qemu Common-init: Building symlink from disks.cfg Common-builder: /dev/disk/by-tag/thetag to /dev/vdN bin/virt-sandbox.c | 37 +++ libvirt-sandbox/Makefile.am| 7 +- .../libvirt-sandbox-builder-container.c| 33 ++- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 44 ++- libvirt-sandbox/libvirt-sandbox-builder.c | 73 - libvirt-sandbox/libvirt-sandbox-config-disk.c | 273 +++ libvirt-sandbox/libvirt-sandbox-config-disk.h | 82 ++ libvirt-sandbox/libvirt-sandbox-config.c | 300 + libvirt-sandbox/libvirt-sandbox-config.h | 11 + libvirt-sandbox/libvirt-sandbox-init-common.c | 54 +++- libvirt-sandbox/libvirt-sandbox-init-qemu.c| 145 ++ libvirt-sandbox/libvirt-sandbox-init-util.c| 57 libvirt-sandbox/libvirt-sandbox-init-util.h| 40 +++ libvirt-sandbox/libvirt-sandbox-util.c | 72 + libvirt-sandbox/libvirt-sandbox-util.h | 5 + libvirt-sandbox/libvirt-sandbox.h | 1 + libvirt-sandbox/libvirt-sandbox.sym| 5 + libvirt-sandbox/tests/test-config.c| 11 + po/POTFILES.in | 1 + 19 files changed, 1105 insertions(+), 146 deletions(-) create mode 100644 libvirt-sandbox/libvirt-sandbox-config-disk.c create mode 100644 libvirt-sandbox/libvirt-sandbox-config-disk.h create mode 100644 libvirt-sandbox/libvirt-sandbox-init-util.c create mode 100644 libvirt-sandbox/libvirt-sandbox-init-util.h create mode 100644 libvirt-sandbox/libvirt-sandbox-util.c -- 2.1.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [sandbox PATCH 00/10] Patches for Libvirt-sandbox
On Thu, Jun 25, 2015 at 01:27:20PM +0200, Eren Yagdiran wrote: > Hello, > > These patches provide disk support for libvirt-sandbox. > Implemented '--disk' parameter will be useful when integrating Docker image > support for libvirt-sandbox. > > --Main diffs compared to previous patches. > > Since many hypervisors, including kvm, will not even honour requested > names for disk devices we link each device under /dev/disk/by-tag > > e.g /dev/disk/by-tag/foobar -> /dev/sda Right, but several patches in this series still deal with allowing the user to specify the /dev/sda name it appears. > > We populate disks.cfg with tag to device mapping when we build the sandbox. > After that, in each init-process {Common,Qemu}, we basically read the > configuration > and populate the right symlinks under /dev/disk/by-tag > > The common functions for modifying directories are moved under Init-util. > {Common,Qemu} inits are using them. On a general point, can you make sure to run 'make syntax-check' on every patch - there are style mistakes on many of these patches that would break the syntax check Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [sandbox PATCH 00/10] Patches for Libvirt-sandbox
On Fri, Jun 26, 2015 at 03:27:35PM +0200, Eren Yagdiran wrote: > Hello, > > These patches provide disk support for libvirt-sandbox. > Implemented '--disk' parameter will be useful when integrating Docker image > support for libvirt-sandbox. > > --Main diffs compared to previous patches. > > Since many hypervisors, including kvm, will not even honour requested > names for disk devices we link each device under /dev/disk/by-tag > > e.g /dev/disk/by-tag/foobar -> /dev/sda > > We populate disks.cfg with tag to device mapping when we build the sandbox. > After that, in each init-process {Common,Qemu}, we basically read the > configuration > and populate the right symlinks under /dev/disk/by-tag > > The common functions for modifying directories are moved under Init-util. > {Common,Qemu} inits are using them. I've pushed this whole series and one fix I needed to make to dealk with fact that LXC uses /dev/sda now, and so we must change disks.cfg to match Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [sandbox PATCH 00/10] Patches for Libvirt-sandbox
Hello Eren, Again, to help your patches review, you will need: * to use -vN when running git send-email to get the version of the patch series in the mail subject * Have a diff with the previous version... your diff never changes. Regards, -- Cedric On Fri, 2015-06-26 at 15:27 +0200, Eren Yagdiran wrote: > Hello, > > These patches provide disk support for libvirt-sandbox. > Implemented '--disk' parameter will be useful when integrating Docker image > support for libvirt-sandbox. > > --Main diffs compared to previous patches. > > Since many hypervisors, including kvm, will not even honour requested > names for disk devices we link each device under /dev/disk/by-tag > > e.g /dev/disk/by-tag/foobar -> /dev/sda > > We populate disks.cfg with tag to device mapping when we build the sandbox. > After that, in each init-process {Common,Qemu}, we basically read the > configuration > and populate the right symlinks under /dev/disk/by-tag > > The common functions for modifying directories are moved under Init-util. > {Common,Qemu} inits are using them. > > Cédric Bosdonnat (2): > Add gvir_sandbox_config_has_disks function > qemu: use devtmpfs rather than tmpfs to auto-populate /dev > > Eren Yagdiran (8): > Add an utility function for guessing filetype from file extension > Add configuration object for disk support > Add disk parameter to virt-sandbox > Add disk support to the container builder > Add disk support to machine builder > Init-util : Common directory functions for init-common and init-qemu > Common-init: Building symlink from disks.cfg > Common-builder: /dev/disk/by-tag/thetag to /dev/vdN > > bin/virt-sandbox.c | 37 +++ > libvirt-sandbox/Makefile.am| 7 +- > .../libvirt-sandbox-builder-container.c| 33 ++- > libvirt-sandbox/libvirt-sandbox-builder-machine.c | 44 ++- > libvirt-sandbox/libvirt-sandbox-builder.c | 73 - > libvirt-sandbox/libvirt-sandbox-config-disk.c | 273 +++ > libvirt-sandbox/libvirt-sandbox-config-disk.h | 82 ++ > libvirt-sandbox/libvirt-sandbox-config.c | 300 > + > libvirt-sandbox/libvirt-sandbox-config.h | 11 + > libvirt-sandbox/libvirt-sandbox-init-common.c | 54 +++- > libvirt-sandbox/libvirt-sandbox-init-qemu.c| 145 ++ > libvirt-sandbox/libvirt-sandbox-init-util.c| 57 > libvirt-sandbox/libvirt-sandbox-init-util.h| 40 +++ > libvirt-sandbox/libvirt-sandbox-util.c | 72 + > libvirt-sandbox/libvirt-sandbox-util.h | 5 + > libvirt-sandbox/libvirt-sandbox.h | 1 + > libvirt-sandbox/libvirt-sandbox.sym| 5 + > libvirt-sandbox/tests/test-config.c| 11 + > po/POTFILES.in | 1 + > 19 files changed, 1105 insertions(+), 146 deletions(-) > create mode 100644 libvirt-sandbox/libvirt-sandbox-config-disk.c > create mode 100644 libvirt-sandbox/libvirt-sandbox-config-disk.h > create mode 100644 libvirt-sandbox/libvirt-sandbox-init-util.c > create mode 100644 libvirt-sandbox/libvirt-sandbox-init-util.h > create mode 100644 libvirt-sandbox/libvirt-sandbox-util.c > -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list