Re: [libvirt] [sandbox PATCH 1/2] configure: Use a single required version for GLib

2018-08-20 Thread Daniel P . Berrangé 
On Mon, Aug 20, 2018 at 10:15:05AM +0200, Andrea Bolognani wrote:
> Both GObject and GIO are part of GLib, so there's no
> point in requiring different versions of the two.
> 
> Signed-off-by: Andrea Bolognani 
> ---
>  configure.ac | 7 +++
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé 


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [sandbox PATCH 1/2] configure: Use a single required version for GLib

2018-08-20 Thread Andrea Bolognani 
Both GObject and GIO are part of GLib, so there's no
point in requiring different versions of the two.

Signed-off-by: Andrea Bolognani 
---
 configure.ac | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index f32c735..d2e2636 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10,8 +10,7 @@ AC_CANONICAL_HOST
 
 AM_SILENT_RULES([yes])
 
-GIO_UNIX_REQUIRED=2.28.0
-GOBJECT_REQUIRED=2.32.0
+GLIB_REQUIRED=2.32.0
 LIBVIRT_REQUIRED=1.0.2
 LIBVIRT_GCONFIG_REQUIRED=0.2.1
 LIBVIRT_GLIB_REQUIRED=0.2.2
@@ -74,8 +73,8 @@ AC_CONFIG_LIBOBJ_DIR([libvirt-sandbox])
 
 LIBVIRT_SANDBOX_COMPILE_WARNINGS
 
-PKG_CHECK_MODULES(GIO_UNIX, gio-unix-2.0 >= $GIO_UNIX_REQUIRED)
-PKG_CHECK_MODULES(GOBJECT, gobject-2.0 >= $GOBJECT_REQUIRED)
+PKG_CHECK_MODULES(GIO_UNIX, gio-unix-2.0 >= $GLIB_REQUIRED)
+PKG_CHECK_MODULES(GOBJECT, gobject-2.0 >= $GLIB_REQUIRED)
 PKG_CHECK_MODULES(LIBVIRT, libvirt >= $LIBVIRT_REQUIRED)
 PKG_CHECK_MODULES(LIBVIRT_GLIB, libvirt-glib-1.0 >= $LIBVIRT_GOBJECT_REQUIRED)
 PKG_CHECK_MODULES(LIBVIRT_GOBJECT, libvirt-gobject-1.0 >= 
$LIBVIRT_GOBJECT_REQUIRED)
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list