Re: [libvirt] [sandbox PATCH v4 04/21] Image: virt-sandbox-image default dir constants

2015-09-04 Thread Daniel P. Berrange
On Fri, Aug 28, 2015 at 01:47:32PM +, Eren Yagdiran wrote:
> Conflicts:
>   virt-sandbox-image/virt-sandbox-image.py
> ---
>  virt-sandbox-image/virt-sandbox-image.py | 8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/virt-sandbox-image/virt-sandbox-image.py 
> b/virt-sandbox-image/virt-sandbox-image.py
> index fa9e1c8..55aea6a 100755
> --- a/virt-sandbox-image/virt-sandbox-image.py
> +++ b/virt-sandbox-image/virt-sandbox-image.py
> @@ -32,6 +32,14 @@ import sys
>  import urllib2
>  import subprocess
>  
> +default_privileged_template_dir = "/var/lib/libvirt/templates"
> +default_home_dir = os.environ['HOME']
> +default_unprivileged_template_dir = default_home_dir + 
> "/.local/share/libvirt/templates"
> +default_privileged_storage_dir = default_privileged_template_dir + "/storage"

This should really be  "/var/lib/libvirt/images"

> +default_unprivileged_storage_dir = default_unprivileged_template_dir + 
> "/storage"

And default_home_dir + "/.local/share/libvirt/images"


Regards,
Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [sandbox PATCH v4 04/21] Image: virt-sandbox-image default dir constants

2015-08-28 Thread Eren Yagdiran
Conflicts:
virt-sandbox-image/virt-sandbox-image.py
---
 virt-sandbox-image/virt-sandbox-image.py | 8 
 1 file changed, 8 insertions(+)

diff --git a/virt-sandbox-image/virt-sandbox-image.py 
b/virt-sandbox-image/virt-sandbox-image.py
index fa9e1c8..55aea6a 100755
--- a/virt-sandbox-image/virt-sandbox-image.py
+++ b/virt-sandbox-image/virt-sandbox-image.py
@@ -32,6 +32,14 @@ import sys
 import urllib2
 import subprocess
 
+default_privileged_template_dir = "/var/lib/libvirt/templates"
+default_home_dir = os.environ['HOME']
+default_unprivileged_template_dir = default_home_dir + 
"/.local/share/libvirt/templates"
+default_privileged_storage_dir = default_privileged_template_dir + "/storage"
+default_unprivileged_storage_dir = default_unprivileged_template_dir + 
"/storage"
+debug = False
+verbose = False
+
 import importlib
 def dynamic_source_loader(name):
 name = name[0].upper() + name[1:]
-- 
2.1.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list