Re: [libvirt] ANNOUNCE: virt-manager 1.1.0 released

2014-12-02 Thread Cole Robinson 

On 12/01/2014 08:52 PM, Jason Helfman wrote:

On Fri, Nov 21, 2014 at 10:13 AM, Jason Helfman j...@freebsd.org
mailto:j...@freebsd.org wrote:

On Fri, Nov 21, 2014 at 5:09 AM, Cole Robinson crobi...@redhat.com
mailto:crobi...@redhat.com wrote:

On 11/20/2014 11:15 PM, Jason Helfman wrote:

Hello,

I was able to get this imported for FreeBSD, but had to implement
a couple of
patches for it to work:


https://svnweb.freebsd.org/__ports/head/deskutils/virt-__manager/files/patch-__virtManager_config.py?view=__markuppathrev=372972

https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_config.py?view=markuppathrev=372972

https://svnweb.freebsd.org/__ports/head/deskutils/virt-__manager/files/patch-__virtManager_console.py?view=__markuppathrev=372972

https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_console.py?view=markuppathrev=372972

This was taken obtained from:

https://build.opensuse.org/__package/view_file/openSUSE:__Factory/virt-manager/virt-__manager-Gtk-30.patch#

https://build.opensuse.org/package/view_file/openSUSE:Factory/virt-manager/virt-manager-Gtk-30.patch#

And is reference by a bug here:
https://bugzilla.suse.com/__show_bug.cgi?id=901869
https://bugzilla.suse.com/show_bug.cgi?id=901869

Comments and suggestions are welcome...


Thanks for the heads up. I added a comment in that suse bug asking for
the patch to be submitted upstream. But if that doesn't materialize in
a week, ping back here

Any word?



Nope. And looking at the suse RPMs I see a ton of patches that they've never 
submitted upstream, some which are clear bug fixes... quite frustrating. I've 
attached their patch, can you try it locally and ensure it fixes your issues? 
If so I'll push it upstream


Thanks,
Cole

Index: virt-manager-1.1.0/virtManager/config.py
===
--- virt-manager-1.1.0.orig/virtManager/config.py
+++ virt-manager-1.1.0/virtManager/config.py
@@ -20,8 +20,10 @@
 import os
 import logging
 
+import gi
 from gi.repository import Gio
 from gi.repository import GLib
+gi.require_version('Gtk', '3.0')
 from gi.repository import Gtk
 
 from virtinst import CPU
Index: virt-manager-1.1.0/virtManager/console.py
===
--- virt-manager-1.1.0.orig/virtManager/console.py
+++ virt-manager-1.1.0/virtManager/console.py
@@ -20,10 +20,13 @@
 # MA 02110-1301 USA.
 #
 
+import gi
 from gi.repository import GObject
 from gi.repository import Gtk
 from gi.repository import Gdk
+gi.require_version('GtkVnc', '2.0')
 from gi.repository import GtkVnc
+gi.require_version('SpiceClientGtk', '3.0')
 from gi.repository import SpiceClientGtk
 from gi.repository import SpiceClientGLib
 
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] ANNOUNCE: virt-manager 1.1.0 released

2014-12-02 Thread Jason Helfman 
On Tue, Dec 2, 2014 at 7:28 AM, Cole Robinson crobi...@redhat.com wrote:

 On 12/01/2014 08:52 PM, Jason Helfman wrote:

 On Fri, Nov 21, 2014 at 10:13 AM, Jason Helfman j...@freebsd.org
 mailto:j...@freebsd.org wrote:

 On Fri, Nov 21, 2014 at 5:09 AM, Cole Robinson crobi...@redhat.com
 mailto:crobi...@redhat.com wrote:

 On 11/20/2014 11:15 PM, Jason Helfman wrote:

 Hello,

 I was able to get this imported for FreeBSD, but had to
 implement
 a couple of
 patches for it to work:

 https://svnweb.freebsd.org/__ports/head/deskutils/virt-__
 manager/files/patch-__virtManager_config.py?view=__markuppathrev=372972
 https://svnweb.freebsd.org/ports/head/deskutils/virt-
 manager/files/patch-virtManager_config.py?view=markuppathrev=372972
 https://svnweb.freebsd.org/__ports/head/deskutils/virt-__
 manager/files/patch-__virtManager_console.py?view=__markuppathrev=372972
 https://svnweb.freebsd.org/ports/head/deskutils/virt-
 manager/files/patch-virtManager_console.py?view=markuppathrev=372972

 This was taken obtained from:
 https://build.opensuse.org/__package/view_file/openSUSE:__
 Factory/virt-manager/virt-__manager-Gtk-30.patch#
 https://build.opensuse.org/package/view_file/openSUSE:
 Factory/virt-manager/virt-manager-Gtk-30.patch#

 And is reference by a bug here:
 https://bugzilla.suse.com/__show_bug.cgi?id=901869
 https://bugzilla.suse.com/show_bug.cgi?id=901869

 Comments and suggestions are welcome...


 Thanks for the heads up. I added a comment in that suse bug
 asking for
 the patch to be submitted upstream. But if that doesn't
 materialize in
 a week, ping back here

 Any word?


 Nope. And looking at the suse RPMs I see a ton of patches that they've
 never submitted upstream, some which are clear bug fixes... quite
 frustrating. I've attached their patch, can you try it locally and ensure
 it fixes your issues? If so I'll push it upstream

 Thanks,
 Cole


Works great. Thanks!

It is too bad that their patches aren't contributed back. My advice is use
their patches (if they work) and note Obtained from SUSE in commitlogs.
When their software build process breaks with the next update, they will
look at the logs and find out why. This may encourage them to contribute
more to the project :)

Thanks,
Jason



-- 
Jason Helfman  | FreeBSD Committer
j...@freebsd.org | http://people.freebsd.org/~jgh  | The Power to Serve
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] ANNOUNCE: virt-manager 1.1.0 released

2014-12-02 Thread Cole Robinson 

On 12/02/2014 01:47 PM, Jason Helfman wrote:

On Tue, Dec 2, 2014 at 7:28 AM, Cole Robinson crobi...@redhat.com
mailto:crobi...@redhat.com wrote:

On 12/01/2014 08:52 PM, Jason Helfman wrote:

On Fri, Nov 21, 2014 at 10:13 AM, Jason Helfman j...@freebsd.org
mailto:j...@freebsd.org
mailto:j...@freebsd.org mailto:j...@freebsd.org wrote:

 On Fri, Nov 21, 2014 at 5:09 AM, Cole Robinson
crobi...@redhat.com mailto:crobi...@redhat.com
 mailto:crobi...@redhat.com mailto:crobi...@redhat.com wrote:

 On 11/20/2014 11:15 PM, Jason Helfman wrote:

 Hello,

 I was able to get this imported for FreeBSD, but had to
implement
 a couple of
 patches for it to work:


https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_config.py?view=markuppathrev=372972

https://svnweb.freebsd.org/__ports/head/deskutils/virt-__manager/files/patch-__virtManager_config.py?view=__markuppathrev=372972


https://svnweb.freebsd.org/__ports/head/deskutils/virt-__manager/files/patch-__virtManager_config.py?view=__markuppathrev=372972

https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_config.py?view=markuppathrev=372972

https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_console.py?view=markuppathrev=372972

https://svnweb.freebsd.org/__ports/head/deskutils/virt-__manager/files/patch-__virtManager_console.py?view=__markuppathrev=372972


https://svnweb.freebsd.org/__ports/head/deskutils/virt-__manager/files/patch-__virtManager_console.py?view=__markuppathrev=372972

https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_console.py?view=markuppathrev=372972

 This was taken obtained from:

https://build.opensuse.org/package/view_file/openSUSE:Factory/virt-manager/virt-manager-Gtk-30.patch#

https://build.opensuse.org/__package/view_file/openSUSE:__Factory/virt-manager/virt-__manager-Gtk-30.patch#


https://build.opensuse.org/__package/view_file/openSUSE:__Factory/virt-manager/virt-__manager-Gtk-30.patch#

https://build.opensuse.org/package/view_file/openSUSE:Factory/virt-manager/virt-manager-Gtk-30.patch#

 And is reference by a bug here:
https://bugzilla.suse.com/show_bug.cgi?id=901869
https://bugzilla.suse.com/__show_bug.cgi?id=901869
 https://bugzilla.suse.com/__show_bug.cgi?id=901869
https://bugzilla.suse.com/show_bug.cgi?id=901869

 Comments and suggestions are welcome...


 Thanks for the heads up. I added a comment in that suse bug
asking for
 the patch to be submitted upstream. But if that doesn't
materialize in
 a week, ping back here

Any word?


Nope. And looking at the suse RPMs I see a ton of patches that they've
never submitted upstream, some which are clear bug fixes... quite
frustrating. I've attached their patch, can you try it locally and ensure
it fixes your issues? If so I'll push it upstream

Thanks,
Cole


Works great. Thanks!



Thanks for testing, I pushed a variant upstream now:

commit 0b391fe9eda81e6c01ba37171190a8d9b2a51aad
Author: Cole Robinson crobi...@redhat.com
Date:   Tue Dec 2 14:01:28 2014 -0500

virt-manager: Enforce gobject introspection versions


It is too bad that their patches aren't contributed back. My advice is use
their patches (if they work) and note Obtained from SUSE in commitlogs. When
their software build process breaks with the next update, they will look at
the logs and find out why. This may encourage them to contribute more to the
project :)


suse benefits from the work of the upstream virt-manager community, least they 
can do when they find bugs and write patches is send them to the upstream 
mailing list. Requiring the upstream maintainer to go crawling through 
downstream RPMs for bug fixes does not scale.


- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] ANNOUNCE: virt-manager 1.1.0 released

2014-12-01 Thread Jason Helfman 
On Fri, Nov 21, 2014 at 10:13 AM, Jason Helfman j...@freebsd.org wrote:

 On Fri, Nov 21, 2014 at 5:09 AM, Cole Robinson crobi...@redhat.com
 wrote:

 On 11/20/2014 11:15 PM, Jason Helfman wrote:

 Hello,

 I was able to get this imported for FreeBSD, but had to implement a
 couple of
 patches for it to work:

 https://svnweb.freebsd.org/ports/head/deskutils/virt-
 manager/files/patch-virtManager_config.py?view=markuppathrev=372972
 https://svnweb.freebsd.org/ports/head/deskutils/virt-
 manager/files/patch-virtManager_console.py?view=markuppathrev=372972

 This was taken obtained from:
 https://build.opensuse.org/package/view_file/openSUSE:
 Factory/virt-manager/virt-manager-Gtk-30.patch#

 And is reference by a bug here:
 https://bugzilla.suse.com/show_bug.cgi?id=901869

 Comments and suggestions are welcome...


 Thanks for the heads up. I added a comment in that suse bug asking for
 the patch to be submitted upstream. But if that doesn't materialize in a
 week, ping back here


Any word?

-jgh

-- 
Jason Helfman  | FreeBSD Committer
j...@freebsd.org | http://people.freebsd.org/~jgh  | The Power to Serve
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] ANNOUNCE: virt-manager 1.1.0 released

2014-11-21 Thread Cole Robinson 

On 11/20/2014 11:15 PM, Jason Helfman wrote:

Hello,

I was able to get this imported for FreeBSD, but had to implement a couple of
patches for it to work:

https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_config.py?view=markuppathrev=372972
https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_console.py?view=markuppathrev=372972

This was taken obtained from:
https://build.opensuse.org/package/view_file/openSUSE:Factory/virt-manager/virt-manager-Gtk-30.patch#

And is reference by a bug here:
https://bugzilla.suse.com/show_bug.cgi?id=901869

Comments and suggestions are welcome...



Thanks for the heads up. I added a comment in that suse bug asking for the 
patch to be submitted upstream. But if that doesn't materialize in a week, 
ping back here


Thanks,
Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] ANNOUNCE: virt-manager 1.1.0 released

2014-11-21 Thread Jason Helfman 
On Fri, Nov 21, 2014 at 5:09 AM, Cole Robinson crobi...@redhat.com wrote:

 On 11/20/2014 11:15 PM, Jason Helfman wrote:

 Hello,

 I was able to get this imported for FreeBSD, but had to implement a
 couple of
 patches for it to work:

 https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-
 virtManager_config.py?view=markuppathrev=372972
 https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-
 virtManager_console.py?view=markuppathrev=372972

 This was taken obtained from:
 https://build.opensuse.org/package/view_file/openSUSE:
 Factory/virt-manager/virt-manager-Gtk-30.patch#

 And is reference by a bug here:
 https://bugzilla.suse.com/show_bug.cgi?id=901869

 Comments and suggestions are welcome...


 Thanks for the heads up. I added a comment in that suse bug asking for the
 patch to be submitted upstream. But if that doesn't materialize in a week,
 ping back here


 Thanks,
 Cole


Your welcome, Cole. Thank you also for noting this in the upstream bug.
I didn't see a patch for the actual software in the bugzilla link, however
the opensuse link I noted above seems to address the issue, however
I'm sure there is a more clean way of doing it, or perhaps some software
dependencies haven't caught up respectively to different versions of gtk.

Thanks, again!
-jgh
-- 
Jason Helfman  | FreeBSD Committer
j...@freebsd.org | http://people.freebsd.org/~jgh  | The Power to Serve
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] ANNOUNCE: virt-manager 1.1.0 released

2014-11-20 Thread Jason Helfman 
Hello,

I was able to get this imported for FreeBSD, but had to implement a couple
of patches for it to work:

https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_config.py?view=markuppathrev=372972
https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_console.py?view=markuppathrev=372972

This was taken obtained from:
https://build.opensuse.org/package/view_file/openSUSE:Factory/virt-manager/virt-manager-Gtk-30.patch#

And is reference by a bug here:
https://bugzilla.suse.com/show_bug.cgi?id=901869

Comments and suggestions are welcome...

-jgh

On Sun, Sep 7, 2014 at 1:59 PM, Cole Robinson crobi...@redhat.com wrote:

 I'm happy to announce the release of virt-manager 1.1.0!

 virt-manager is a desktop application for managing KVM, Xen, and LXC
 virtualization via libvirt.

 The release can be downloaded from:

 http://virt-manager.org/download/

 The direct download links are:


 http://virt-manager.org/download/sources/virt-manager/virt-manager-1.1.0.tar.gz

 This release includes:

 - Switch to libosinfo as OS metadata database (Giuseppe Scrivano)
 - Use libosinfo for OS detection from CDROM media labels (Giuseppe
   Scrivano)
 - Use libosinfo for improved OS defaults, like recommended disk size
   (Giuseppe Scrivano)
 - virt-image tool has been removed, as previously announced
 - Enable Hyper-V enlightenments for Windows VMs
 - Revert virtio-console default, back to plain serial console
 - Experimental q35 option in new VM 'customize' dialog
 - UI for virtual network QoS settings (Giuseppe Scrivano)
 - virt-install: --disk discard= support (Jim Minter)
 - addhardware: Add spiceport UI (Marc-André Lureau)
 - virt-install: --events on_poweroff etc. support (Chen Hanxiao)
 - cli --network portgroup= support and UI support
 - cli --boot initargs= and UI support
 - addhardware: allow setting controller model (Chen Hanxiao)
 - virt-install: support setting hugepage options (Chen Hanxiao)

 Thanks to everyone who has contributed to this release through testing,
 bug reporting, submitting patches, and otherwise sending in feedback!

 Thanks,
 Cole

 --
 libvir-list mailing list
 libvir-list@redhat.com
 https://www.redhat.com/mailman/listinfo/libvir-list




-- 
Jason Helfman  | FreeBSD Committer
j...@freebsd.org | http://people.freebsd.org/~jgh  | The Power to Serve
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] ANNOUNCE: virt-manager 1.1.0 released

2014-09-07 Thread Cole Robinson 
I'm happy to announce the release of virt-manager 1.1.0!

virt-manager is a desktop application for managing KVM, Xen, and LXC
virtualization via libvirt.

The release can be downloaded from:

http://virt-manager.org/download/

The direct download links are:

http://virt-manager.org/download/sources/virt-manager/virt-manager-1.1.0.tar.gz

This release includes:

- Switch to libosinfo as OS metadata database (Giuseppe Scrivano)
- Use libosinfo for OS detection from CDROM media labels (Giuseppe
  Scrivano)
- Use libosinfo for improved OS defaults, like recommended disk size
  (Giuseppe Scrivano)
- virt-image tool has been removed, as previously announced
- Enable Hyper-V enlightenments for Windows VMs
- Revert virtio-console default, back to plain serial console
- Experimental q35 option in new VM 'customize' dialog
- UI for virtual network QoS settings (Giuseppe Scrivano)
- virt-install: --disk discard= support (Jim Minter)
- addhardware: Add spiceport UI (Marc-André Lureau)
- virt-install: --events on_poweroff etc. support (Chen Hanxiao)
- cli --network portgroup= support and UI support
- cli --boot initargs= and UI support
- addhardware: allow setting controller model (Chen Hanxiao)
- virt-install: support setting hugepage options (Chen Hanxiao)

Thanks to everyone who has contributed to this release through testing,
bug reporting, submitting patches, and otherwise sending in feedback!

Thanks,
Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list