Re: [libvirt] CLZERO support for AMD

2019-12-03 Thread Ani Sinha
Thanks. I have sent a patch based off the tip here:
https://www.redhat.com/archives/libvir-list/2019-December/msg00086.html

I also have a patch off libvirt-4.5 which I have tested on our HW. If needed, I 
can send that patch as well.

Ani

On Dec 2, 2019, 5:22 PM +0530, Daniel P. Berrangé , wrote:
On Wed, Nov 27, 2019 at 11:10:21AM +, Ani Sinha wrote:
Hi :

I see a commit in qemu that adds support for CLZERO but in CPUIDs. :

commit e900135dcfb676a4019dc206395e02db5d1de0d6
Author: Sebastian Andrzej Siewior 
Date: Wed Sep 25 23:49:48 2019 +0200

i386: Add CPUID bit for CLZERO and XSAVEERPTR

The CPUID bits CLZERO and XSAVEERPTR are availble on AMD's ZEN platform
and could be passed to the guest.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Paolo Bonzini 

Is there a corresponding change in libvirt adding this capability? Libvirt 
complains when I add it manually in the vm xml:

# virsh create newvm.xml
error: Failed to create domain from newvm.xml
error: unsupported configuration: unknown CPU feature: clzero

# grep clzero newvm.xml


Should we add it?

Yes, if it is supported by QEMU to expose to a guest, then it should be
added to libvirt too.

Presumably only needs add an addition to src/cpu_maps/x86_features.xml

Regards,
Daniel
--
|: 
https://urldefense.proofpoint.com/v2/url?u=https-3A__berrange.com=DwIFaQ=s883GpUCOChKOHiocYtGcg=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI=HIAImXOwBBjDjbozqHZOBn1uaSs-AU3LugXqoQrrLko=
 -o- 
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.flickr.com_photos_dberrange=DwIFaQ=s883GpUCOChKOHiocYtGcg=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI=6zWQAT7zkr1fFfhCvnSAN6tLwYa1vFb0m66XYH46Vgw=
 :|
|: 
https://urldefense.proofpoint.com/v2/url?u=https-3A__libvirt.org=DwIFaQ=s883GpUCOChKOHiocYtGcg=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI=mSj1Kh5NlO-NiBTedJkvXyreeEvNDLcEAkxVV8TxUmY=
 -o- 
https://urldefense.proofpoint.com/v2/url?u=https-3A__fstop138.berrange.com=DwIFaQ=s883GpUCOChKOHiocYtGcg=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI=mw-XirgI1BWzbKo6zZTTY_SMrUw0aD1j6CiHYAhTVJw=
 :|
|: 
https://urldefense.proofpoint.com/v2/url?u=https-3A__entangle-2Dphoto.org=DwIFaQ=s883GpUCOChKOHiocYtGcg=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI=gDp9hO9xGy4cPvntUrsFe_9iiycTQSeX7II4_RzQeA0=
 -o- 
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.instagram.com_dberrange=DwIFaQ=s883GpUCOChKOHiocYtGcg=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI=_vzLCn26_4Iv36BEhb8Et71nUZIB6-m6JTa97ffbqMM=
 :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] CLZERO support for AMD

2019-12-02 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 11:10:21AM +, Ani Sinha wrote:
> Hi :
> 
> I see a commit in qemu that adds support for CLZERO but in CPUIDs. :
> 
> commit e900135dcfb676a4019dc206395e02db5d1de0d6
> Author: Sebastian Andrzej Siewior 
> Date: Wed Sep 25 23:49:48 2019 +0200
> 
> i386: Add CPUID bit for CLZERO and XSAVEERPTR
> 
> The CPUID bits CLZERO and XSAVEERPTR are availble on AMD's ZEN platform
> and could be passed to the guest.
> 
> Signed-off-by: Sebastian Andrzej Siewior 
> Signed-off-by: Paolo Bonzini 
> 
> Is there a corresponding change in libvirt adding this capability? Libvirt 
> complains when I add it manually in the vm xml:
> 
> # virsh create newvm.xml 
> error: Failed to create domain from newvm.xml
> error: unsupported configuration: unknown CPU feature: clzero
> 
> # grep clzero newvm.xml 
> 
> 
> Should we add it?

Yes, if it is supported by QEMU to expose to a guest, then it should be
added to libvirt too.

Presumably only needs add an addition to src/cpu_maps/x86_features.xml

Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list



[libvirt] CLZERO support for AMD

2019-11-27 Thread Ani Sinha
Hi :

I see a commit in qemu that adds support for CLZERO but in CPUIDs. :

commit e900135dcfb676a4019dc206395e02db5d1de0d6
Author: Sebastian Andrzej Siewior 
Date: Wed Sep 25 23:49:48 2019 +0200

i386: Add CPUID bit for CLZERO and XSAVEERPTR

The CPUID bits CLZERO and XSAVEERPTR are availble on AMD's ZEN platform
and could be passed to the guest.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Paolo Bonzini 

Is there a corresponding change in libvirt adding this capability? Libvirt 
complains when I add it manually in the vm xml:

# virsh create newvm.xml 
error: Failed to create domain from newvm.xml
error: unsupported configuration: unknown CPU feature: clzero

# grep clzero newvm.xml 


Should we add it?

thanks
ani




--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list