Re: [libvirt] Entering freeze for libvirt-3.6.0
On Thu, Jul 27, 2017 at 17:20:22 +0100, Daniel Berrange wrote: > On Thu, Jul 27, 2017 at 06:14:58PM +0200, Andrea Bolognani wrote: > > On Thu, 2017-07-27 at 22:42 +0800, Daniel Veillard wrote: > > > As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 > > > signed tarball and rpms available from the usual place: > > > > > > ftp://libvirt.org/libvirt/ > > > > > > > > > seems to work in my limited testing, https://ci.centos.org/view/libvirt/ > > > is all green (except for mingw maybe there is a portability issue) > > > > That's because after 5aec02dc3762 dlopen() and friends are > > required for building, and mingw doesn't provide them. > > No that's not correct - dlopen() is only required if building stateful > drivers with libvirtd enabled, and that's not needed with mingw. The > biuld failure is actually simpler - its just a test case that's not > compiling > > ../../tests/virdrivermoduletest.c: In function 'mymain': > ../../tests/virdrivermoduletest.c:55:33: error: unused variable 'data' > [-Werror=unused-variable] > struct testDriverModuleData data; > ^~~~ > At top level: > ../../tests/virdrivermoduletest.c:39:12: error: 'testDriverModule' defined > but not used [-Werror=unused-function] > static int testDriverModule(const void *args) > ^~~~ > cc1: all warnings being treated as errors > make[2]: *** [Makefile:5331: virdrivermoduletest.o] Error 1 > > > We simply need to conditionalize that test properly Oh, right. I was too eager when deleting the conditionally compiled code. I'll post a patch ... signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Entering freeze for libvirt-3.6.0
On Thu, Jul 27, 2017 at 06:14:58PM +0200, Andrea Bolognani wrote: > On Thu, 2017-07-27 at 22:42 +0800, Daniel Veillard wrote: > > As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 > > signed tarball and rpms available from the usual place: > > > > ftp://libvirt.org/libvirt/ > > > > > > seems to work in my limited testing, https://ci.centos.org/view/libvirt/ > > is all green (except for mingw maybe there is a portability issue) > > That's because after 5aec02dc3762 dlopen() and friends are > required for building, and mingw doesn't provide them. No that's not correct - dlopen() is only required if building stateful drivers with libvirtd enabled, and that's not needed with mingw. The biuld failure is actually simpler - its just a test case that's not compiling ../../tests/virdrivermoduletest.c: In function 'mymain': ../../tests/virdrivermoduletest.c:55:33: error: unused variable 'data' [-Werror=unused-variable] struct testDriverModuleData data; ^~~~ At top level: ../../tests/virdrivermoduletest.c:39:12: error: 'testDriverModule' defined but not used [-Werror=unused-function] static int testDriverModule(const void *args) ^~~~ cc1: all warnings being treated as errors make[2]: *** [Makefile:5331: virdrivermoduletest.o] Error 1 We simply need to conditionalize that test properly Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Entering freeze for libvirt-3.6.0
On Thu, 2017-07-27 at 22:42 +0800, Daniel Veillard wrote: > As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 > signed tarball and rpms available from the usual place: > > ftp://libvirt.org/libvirt/ > > > seems to work in my limited testing, https://ci.centos.org/view/libvirt/ > is all green (except for mingw maybe there is a portability issue) That's because after 5aec02dc3762 dlopen() and friends are required for building, and mingw doesn't provide them. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] Entering freeze for libvirt-3.6.0
As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 signed tarball and rpms available from the usual place: ftp://libvirt.org/libvirt/ seems to work in my limited testing, https://ci.centos.org/view/libvirt/ is all green (except for mingw maybe there is a portability issue) Please give it a try, check other systems, and if everything goes well I will make RC2 over the week-end and 3.6.0 may land on Tuesday the 1st ! Thanks in advance, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veill...@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
