[libvirt] Re: [Libvir] [PATCH] sound support for qemu and xen
Hi, Cole and Dan I have a question about the reason why it does not support in xen_proxy. Would you explain why it does not support in xen_proxy? This policy comes from security issue or other? If it does already commented on this please show me a pointer. P.S. I raise this question when I see the patch of follows. But I cannot find the reason. Disable sound functions when in proxy http://git.et.redhat.com/?p=libvirt.git;a=commit;h=0f7619f25e7dd03296c95241c1de06953ac110c3 Thanks Atsushi SAKAI Cole Robinson [EMAIL PROTECTED] wrote: The patch below adds xml support for the soundhw option to qemu and xen. The new xml element takes the form: sound driver='drivername'/ Where driver name can be pcspk, sb16, es1370, or all. Everything seems to be in working order but I have a few implementation questions: 1) Should multiple drivers be able to be specified? qemu accommodates this, allowing '-soundhw sb16,pcspk' for example. If this should be allowed, what should the xml format be? 2) Should acceptable driver options be hardcoded? The other option is to just pass the input straight to qemu. This patch has the options hardcoded. Also I realize this will probably need to be rediff'd around Dan's serial + parallel device patch, but I figured I would just get this out there. Thanks, Cole -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] Re: [Libvir] [PATCH] sound support for qemu and xen
On Fri, May 09, 2008 at 06:33:19PM +0900, Atsushi SAKAI wrote: Hi, Cole and Dan I have a question about the reason why it does not support in xen_proxy. Would you explain why it does not support in xen_proxy? That changeset was just disabling a couple of functions there were not needed in the proxy. The proxy is read-only, so doesn't need ability to create VMs thus those sound functions were disabled. Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Re: [Libvir] [PATCH] sound support for qemu and xen
On Tue, May 06, 2008 at 10:25:37PM +0100, Daniel P. Berrange wrote: On Tue, May 06, 2008 at 10:39:53AM -0400, Cole Robinson wrote: Cole Robinson wrote: The patch below adds xml support for the soundhw option to qemu and xen. Third iteration. Changes include: - Rediffd against current code - Reading 'all' from a xend sexpr or xm config does the right thing. - Added test files. Great, this looks good now Excellent, this is now commited. One thing left to do is document the associated XML extentions for the devices sections. Should be easier now with Dan's new HTML generation, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED] | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] Re: [Libvir] [PATCH] sound support for qemu and xen
On Tue, May 06, 2008 at 10:39:53AM -0400, Cole Robinson wrote: Cole Robinson wrote: The patch below adds xml support for the soundhw option to qemu and xen. Third iteration. Changes include: - Rediffd against current code - Reading 'all' from a xend sexpr or xm config does the right thing. - Added test files. Great, this looks good now - Addressed most of Jim's feedback. Unfortunately I could not reuse the qemu sound functions, as xen (on f8 at least) doesn't support the pcspk model, so the whitelist isn't the same between the two. I don't think its a huge deal to have separate code for Xen vs QEMU. The entire XML parser needs to be merged - just dealing with the sound functions is such a minor deal its not worth it. Regards, Daniel. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
