Re: [libvirt PATCH 06/12] ci: jobs.sh: integration: Use --quiet with virsh

2023-09-18 Thread Daniel P . Berrangé
On Mon, Sep 18, 2023 at 12:22:42PM +0200, Erik Skultety wrote:
> We've not been interested in any extra output from the command at all
> since we always redirected both stdout and stderr to /dev/null. Future
> patch will change that slightly, so --quiet will start making sense.
> 
> Signed-off-by: Erik Skultety 
> ---
>  ci/jobs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé 


With regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|



[libvirt PATCH 06/12] ci: jobs.sh: integration: Use --quiet with virsh

2023-09-18 Thread Erik Skultety
We've not been interested in any extra output from the command at all
since we always redirected both stdout and stderr to /dev/null. Future
patch will change that slightly, so --quiet will start making sense.

Signed-off-by: Erik Skultety 
---
 ci/jobs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ci/jobs.sh b/ci/jobs.sh
index 04e776e9be..75ea638580 100644
--- a/ci/jobs.sh
+++ b/ci/jobs.sh
@@ -104,7 +104,7 @@ run_integration() {
 sudo systemctl restart ${daemon}.socket
 done
 
-sudo virsh net-start default &>/dev/null || true
+sudo virsh --quiet net-start default &>/dev/null || true
 
 cd "$SCRATCH_DIR"
 git clone --depth 1 https://gitlab.com/libvirt/libvirt-tck.git
-- 
2.41.0