Re: [PATCH] the leading space in volmode check will never match the leading tab output from zfs get

[Michal Privoznik]

On 10/2/20 4:42 PM, Daniel Henrique Barboza wrote:

The code is ok but the commit message can be improved. Usually
we want a commit title with a single-line summary of what you're
changing, a blank line, and a description describes in more
the change, and your signed-off tag. This guideline can be
found here:

https://libvirt.org/best-practices.html


For this patch, one possibility would be:

---
storage_backend_zfs.c: remove leading space in volmode check

The leading space in volmode check will never match the leading
tab output from zfs get.


Signed-off-by: Richard Burakowski 
---




Agree with Daniel here. Richard, can you please send v2 with the commit 
message fixed? We can merge it then.


Michal

Re: [PATCH] the leading space in volmode check will never match the leading tab output from zfs get

[Daniel Henrique Barboza]

The code is ok but the commit message can be improved. Usually
we want a commit title with a single-line summary of what you're
changing, a blank line, and a description describes in more
the change, and your signed-off tag. This guideline can be
found here:

https://libvirt.org/best-practices.html


For this patch, one possibility would be:

---
storage_backend_zfs.c: remove leading space in volmode check

The leading space in volmode check will never match the leading
tab output from zfs get.


Signed-off-by: Richard Burakowski 
---


Thanks,


DHB

On 9/23/20 9:48 PM, richardburakow...@gmail.com wrote:

Signed-off-by: Richard Burakowski 
---
  src/storage/storage_backend_zfs.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/storage/storage_backend_zfs.c 
b/src/storage/storage_backend_zfs.c
index dc692f47ed..439f5b2fd5 100644
--- a/src/storage/storage_backend_zfs.c
+++ b/src/storage/storage_backend_zfs.c
@@ -71,7 +71,7 @@ virStorageBackendZFSVolModeNeeded(void)
  return ret;
  }
  
-if (strstr(error, " volmode "))

+if (strstr(error, "volmode "))
  return 1;
  else
  return 0;