Re: [PATCH libvirt v1 2/6] tests: qemu: add tests for ZPCI on s390

2020-06-08 Thread Shalini Chellathurai Saroja 

Hi Andrea,

Thank you for the review.

On 6/3/20 12:11 PM, Andrea Bolognani wrote:

On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:

Add test to verify ZPCI address validation with uid set to 0x0

Signed-off-by: Bjoern Walk 
Signed-off-by: Shalini Chellathurai Saroja 
Reviewed-by: Bjoern Walk 
Reviewed-by: Boris Fiuczynski 
---
  .../hostdev-vfio-zpci-uid-set-zero.xml| 20 +++
  tests/qemuxml2argvtest.c  |  3 +++
  2 files changed, 23 insertions(+)
  create mode 100644 tests/qemuxml2argvdata/hostdev-vfio-zpci-uid-set-zero.xml

The test cases for the new behavior should go into the patch that
implements it.

ok.



+++ b/tests/qemuxml2argvtest.c
@@ -1650,6 +1650,9 @@ mymain(void)
  DO_TEST("hostdev-vfio-zpci-autogenerate",
  QEMU_CAPS_DEVICE_VFIO_PCI,
  QEMU_CAPS_DEVICE_ZPCI);
+DO_TEST_PARSE_ERROR("hostdev-vfio-zpci-uid-set-zero",
+QEMU_CAPS_DEVICE_VFIO_PCI,
+QEMU_CAPS_DEVICE_ZPCI);

Indentation is off.

ok, I will correct it.

Re: [PATCH libvirt v1 2/6] tests: qemu: add tests for ZPCI on s390

2020-06-03 Thread Andrea Bolognani 
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
> Add test to verify ZPCI address validation with uid set to 0x0
> 
> Signed-off-by: Bjoern Walk 
> Signed-off-by: Shalini Chellathurai Saroja 
> Reviewed-by: Bjoern Walk 
> Reviewed-by: Boris Fiuczynski 
> ---
>  .../hostdev-vfio-zpci-uid-set-zero.xml| 20 +++
>  tests/qemuxml2argvtest.c  |  3 +++
>  2 files changed, 23 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/hostdev-vfio-zpci-uid-set-zero.xml

The test cases for the new behavior should go into the patch that
implements it.

> +++ b/tests/qemuxml2argvtest.c
> @@ -1650,6 +1650,9 @@ mymain(void)
>  DO_TEST("hostdev-vfio-zpci-autogenerate",
>  QEMU_CAPS_DEVICE_VFIO_PCI,
>  QEMU_CAPS_DEVICE_ZPCI);
> +DO_TEST_PARSE_ERROR("hostdev-vfio-zpci-uid-set-zero",
> +QEMU_CAPS_DEVICE_VFIO_PCI,
> +QEMU_CAPS_DEVICE_ZPCI);

Indentation is off.

-- 
Andrea Bolognani / Red Hat / Virtualization