Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release
On Thu, Jun 01, 2017 at 09:48:45AM +0200, Andrea Bolognani wrote: On Wed, 2017-05-31 at 17:44 +0200, Martin Kletzander wrote: > @@ -407,7 +404,7 @@ > NVDIMM is new type of memory introduced into QEMU 2.6. The idea is > that we have a non-volatile memory module that keeps the data > persistent across domain reboots and offers much faster data > - accesses. However, due to a bug in QEMU, this feature is not enabled > + accesses. However, due to a bug in QEMU, this feature is not enabled > for QEMUs older than 2.9.0. Of course except this last hunk as that is for an older version, I'm rushing too much, I'll rather send a v2 tomorrow then regret the bunny ears yet again. I don't feel like news entries become entirely immutable after the release is out; in particular, performing minor style tweaks like this one or fixing typos is perfectly acceptable IMHO, as it improves the overall document without changing its meaning or attempting to rewrite history. Sure, I just meant it's not part of this patch. I pushed both of them now, hopefully it looks like it should, feel free to check it out ;) And I'm pretty sure removing an extra space from this file will not cause the build to fail, so no risk of bunny ears ;) -- Andrea Bolognani / Red Hat / Virtualization signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release
On Wed, 2017-05-31 at 17:44 +0200, Martin Kletzander wrote: > > @@ -407,7 +404,7 @@ > > NVDIMM is new type of memory introduced into QEMU 2.6. The idea is > > that we have a non-volatile memory module that keeps the data > > persistent across domain reboots and offers much faster data > > - accesses. However, due to a bug in QEMU, this feature is not > > enabled > > + accesses. However, due to a bug in QEMU, this feature is not > > enabled > > for QEMUs older than 2.9.0. > > Of course except this last hunk as that is for an older version, I'm > rushing too much, I'll rather send a v2 tomorrow then regret the bunny > ears yet again. I don't feel like news entries become entirely immutable after the release is out; in particular, performing minor style tweaks like this one or fixing typos is perfectly acceptable IMHO, as it improves the overall document without changing its meaning or attempting to rewrite history. And I'm pretty sure removing an extra space from this file will not cause the build to fail, so no risk of bunny ears ;) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release
On Wed, May 31, 2017 at 17:35:52 +0200, Martin Kletzander wrote: > On Wed, May 31, 2017 at 04:22:07PM +0200, Peter Krempa wrote: > > On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote: > > > Signed-off-by: Martin Kletzander > > > --- > > > I could not be bothered to split the patches. Also, please review > > > whatever you know about as this is just a compilation of stuff from > > > the git log. > > > > > > docs/news.xml | 166 > > > +- > > > 1 file changed, 165 insertions(+), 1 deletion(-) > > > > > > diff --git a/docs/news.xml b/docs/news.xml > > > index 649350a904d3..d34e8beae4c0 100644 > > > --- a/docs/news.xml > > > +++ b/docs/news.xml > > > @@ -45,6 +45,38 @@ > > > > [...] > > > > > + > > > + > > > + Repository now has new README.md file > > > + > > > + > > > + The new file uses markdown syntax, so it looks better on > > > + github and possibly other web pages, but it has also more > > > + useful information. The old README is now symlink to the > > > + new file. > > > + > > > + > > > > This does not seem to be a feature to me in any possible way. > > > > I probably wanted to put it in Improvements, can that be? I don't feel that adding that file improved anything, but yes, that is the more appropriate place. > > > > @@ -67,10 +99,142 @@ > > > > [...] > > > > > + > > > + > > > + libxl: NUMA sibling distances are now reported in host > > > capabilities > > > + > > > + > > > + > > > + > > > + Support for VMDK files with version 3 > > > + > > > + > > > + VMDK version 3 files are now properly detected. > > > > Was this description suggested by the department of redundancy > > department? > > > > I'll go with just "VMDK version 3 files are now properly detected" as a > summary. That's exactly what I've meant :) > > > > > + > > > + > > > + > > > + > > > + Interrupt remapping and Extended interrupt mode for IOMMU > > > devices > > > + > > > + > > > + These two new features can now be controlled with new > > > +> > > + tag for iommu devices. > > > + > > > + > > > > Why was the other iommu change considered a feature and this is an > > improvement? > > > > What other iommu change? I can't find any in this file. > > > > > ACK to everything excepthe readme.md section. ACK signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release
On Wed, May 31, 2017 at 05:35:52PM +0200, Martin Kletzander wrote: On Wed, May 31, 2017 at 04:22:07PM +0200, Peter Krempa wrote: On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- I could not be bothered to split the patches. Also, please review whatever you know about as this is just a compilation of stuff from the git log. docs/news.xml | 166 +- 1 file changed, 165 insertions(+), 1 deletion(-) diff --git a/docs/news.xml b/docs/news.xml index 649350a904d3..d34e8beae4c0 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -45,6 +45,38 @@ [...] + + + Repository now has new README.md file + + + The new file uses markdown syntax, so it looks better on + github and possibly other web pages, but it has also more + useful information. The old README is now symlink to the + new file. + + This does not seem to be a feature to me in any possible way. I probably wanted to put it in Improvements, can that be? @@ -67,10 +99,142 @@ [...] + + + libxl: NUMA sibling distances are now reported in host capabilities + + + + + Support for VMDK files with version 3 + + + VMDK version 3 files are now properly detected. Was this description suggested by the department of redundancy department? I'll go with just "VMDK version 3 files are now properly detected" as a summary. + + + + + Interrupt remapping and Extended interrupt mode for IOMMU devices + + + These two new features can now be controlled with new ++ tag for iommu devices. + + Why was the other iommu change considered a feature and this is an improvement? What other iommu change? I can't find any in this file. ACK to everything excepthe readme.md section. Please, reconsider with this squashed in, since there was off-list reply with double spaces as well: diff --git i/docs/news.xml w/docs/news.xml index d34e8beae4c0..b351f22990a1 100644 --- i/docs/news.xml +++ w/docs/news.xml @@ -57,17 +57,6 @@ - Repository now has new README.md file - - - The new file uses markdown syntax, so it looks better on - github and possibly other web pages, but it has also more - useful information. The old README is now symlink to the - new file. - - - - The reason for VM shutdown is reported, if known @@ -81,6 +70,17 @@ + Repository now has new README.md file + + + The new file uses markdown syntax, so it looks better on + github and possibly other web pages, but it has also more + useful information. The old README is now symlink to the + new file. + + + + qemu: Use GICv2 by default for aarch64/virt TCG guests @@ -117,7 +117,7 @@ If supported in the kernel, host capabilities will now list - L3 caches. The code for other levels was added as well, but + L3 caches. The code for other levels was added as well, but only L3 caches are reported currently. @@ -136,11 +136,8 @@ - Support for VMDK files with version 3 + VMDK version 3 files are now properly detected - - VMDK version 3 files are now properly detected. - @@ -158,7 +155,7 @@ Even though there were default addresses before this change, - they were not saved in the XML. It is now possible to see + they were not saved in the XML. It is now possible to see and control the listen addresses properly. @@ -169,7 +166,7 @@ Even though they were added automatically when USB device was attached, they could've been missing in some other - cases. The logic is now fixed so there are always USB + cases. The logic is now fixed so there are always USB controllers, even if there was none of them in the specified XML. @@ -181,7 +178,7 @@ Hitting the RPC limits we have is easier every day, so they were increased once again and some guessing logic was - improved as well. It is now possible to get more stats than + improved as well. It is now possible to get more stats than ever using the virConnectGetAllDomainStats() call and push through even bigger requests and replies for all APIs. @@ -195,7 +192,7 @@ It could h
Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release
On Wed, May 31, 2017 at 04:22:07PM +0200, Peter Krempa wrote: On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- I could not be bothered to split the patches. Also, please review whatever you know about as this is just a compilation of stuff from the git log. docs/news.xml | 166 +- 1 file changed, 165 insertions(+), 1 deletion(-) diff --git a/docs/news.xml b/docs/news.xml index 649350a904d3..d34e8beae4c0 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -45,6 +45,38 @@ [...] + + + Repository now has new README.md file + + + The new file uses markdown syntax, so it looks better on + github and possibly other web pages, but it has also more + useful information. The old README is now symlink to the + new file. + + This does not seem to be a feature to me in any possible way. I probably wanted to put it in Improvements, can that be? @@ -67,10 +99,142 @@ [...] + + + libxl: NUMA sibling distances are now reported in host capabilities + + + + + Support for VMDK files with version 3 + + + VMDK version 3 files are now properly detected. Was this description suggested by the department of redundancy department? I'll go with just "VMDK version 3 files are now properly detected" as a summary. + + + + + Interrupt remapping and Extended interrupt mode for IOMMU devices + + + These two new features can now be controlled with new ++ tag for iommu devices. + + Why was the other iommu change considered a feature and this is an improvement? What other iommu change? I can't find any in this file. ACK to everything excepthe readme.md section. Please, reconsider with this squashed in, since there was off-list reply with double spaces as well: diff --git i/docs/news.xml w/docs/news.xml index d34e8beae4c0..b351f22990a1 100644 --- i/docs/news.xml +++ w/docs/news.xml @@ -57,17 +57,6 @@ - Repository now has new README.md file - - - The new file uses markdown syntax, so it looks better on - github and possibly other web pages, but it has also more - useful information. The old README is now symlink to the - new file. - - - - The reason for VM shutdown is reported, if known @@ -81,6 +70,17 @@ + Repository now has new README.md file + + + The new file uses markdown syntax, so it looks better on + github and possibly other web pages, but it has also more + useful information. The old README is now symlink to the + new file. + + + + qemu: Use GICv2 by default for aarch64/virt TCG guests @@ -117,7 +117,7 @@ If supported in the kernel, host capabilities will now list - L3 caches. The code for other levels was added as well, but + L3 caches. The code for other levels was added as well, but only L3 caches are reported currently. @@ -136,11 +136,8 @@ - Support for VMDK files with version 3 + VMDK version 3 files are now properly detected - - VMDK version 3 files are now properly detected. - @@ -158,7 +155,7 @@ Even though there were default addresses before this change, - they were not saved in the XML. It is now possible to see + they were not saved in the XML. It is now possible to see and control the listen addresses properly. @@ -169,7 +166,7 @@ Even though they were added automatically when USB device was attached, they could've been missing in some other - cases. The logic is now fixed so there are always USB + cases. The logic is now fixed so there are always USB controllers, even if there was none of them in the specified XML. @@ -181,7 +178,7 @@ Hitting the RPC limits we have is easier every day, so they were increased once again and some guessing logic was - improved as well. It is now possible to get more stats than + improved as well. It is now possible to get more stats than ever using the virConnectGetAllDomainStats() call and push through even bigger requests and replies for all APIs. @@ -195,7 +192,7 @@ It could happen that the link speed for PCIe devices was not - proper
Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release
On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > I could not be bothered to split the patches. Also, please review > whatever you know about as this is just a compilation of stuff from > the git log. > > docs/news.xml | 166 > +- > 1 file changed, 165 insertions(+), 1 deletion(-) > > diff --git a/docs/news.xml b/docs/news.xml > index 649350a904d3..d34e8beae4c0 100644 > --- a/docs/news.xml > +++ b/docs/news.xml > @@ -45,6 +45,38 @@ [...] > + > + > + Repository now has new README.md file > + > + > + The new file uses markdown syntax, so it looks better on > + github and possibly other web pages, but it has also more > + useful information. The old README is now symlink to the > + new file. > + > + This does not seem to be a feature to me in any possible way. > @@ -67,10 +99,142 @@ [...] > + > + > + libxl: NUMA sibling distances are now reported in host capabilities > + > + > + > + > + Support for VMDK files with version 3 > + > + > + VMDK version 3 files are now properly detected. Was this description suggested by the department of redundancy department? > + > + > + > + > + Interrupt remapping and Extended interrupt mode for IOMMU devices > + > + > + These two new features can now be controlled with new > +> + tag for iommu devices. > + > + Why was the other iommu change considered a feature and this is an improvement? ACK to everything excepthe readme.md section. signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
