Re: [libvirt] [PATCH] Allow RO connections to interface udev backend

2013-06-28 Thread Ján Tomko
On 06/28/2013 03:48 AM, Doug Goldstein wrote:
 The udev based interface backend did not allow querying data over a
 read-only connection which is different than how the netcf backend
 operates. This brings the behavior inline with the default, netcf
 backend.
 ---
  src/interface/interface_backend_udev.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 

ACK

Jan

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH] Allow RO connections to interface udev backend

2013-06-28 Thread Doug Goldstein
On Fri, Jun 28, 2013 at 2:49 AM, Ján Tomko jto...@redhat.com wrote:

 On 06/28/2013 03:48 AM, Doug Goldstein wrote:
  The udev based interface backend did not allow querying data over a
  read-only connection which is different than how the netcf backend
  operates. This brings the behavior inline with the default, netcf
  backend.
  ---
   src/interface/interface_backend_udev.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
 

 ACK

 Jan


Ok to push for 1.1.0? This really should be included IMHO to unbreak the
API.

-- 
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Allow RO connections to interface udev backend

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 06:43:37AM -0500, Doug Goldstein wrote:
 On Fri, Jun 28, 2013 at 2:49 AM, Ján Tomko jto...@redhat.com wrote:
 
  On 06/28/2013 03:48 AM, Doug Goldstein wrote:
   The udev based interface backend did not allow querying data over a
   read-only connection which is different than how the netcf backend
   operates. This brings the behavior inline with the default, netcf
   backend.
   ---
src/interface/interface_backend_udev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
  
 
  ACK
 
  Jan
 
 
 Ok to push for 1.1.0? This really should be included IMHO to unbreak the
 API.

ACK

Minimal risk, so fine to push.

Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list